From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C51A3C944A for ; Wed, 5 Aug 2026 04:29:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785904175; cv=none; b=asykzhb1n82KMqxoHrwQb1FboMwJdJfewpd54T9ZfzdJ7fyB0L6mEHmVKpVosgNIZW/yUTG+u3PmPAqePhrmDR9kyd1pvJM8lELA5VCP/nnYkk+gWFHlm7s8BR30kHDgk+WEcEIC9LPCjU9BUdbid3NqXABx/xdUJ6usH8nI+Ew= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785904175; c=relaxed/simple; bh=c6qaAcE400LJQHv0RvofYMrC+28wDjxX/9YIHIm3+ls=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=FPMhiAVHXMegXZdpji1DdDuaB1XpXrd4wA31HvRBvwkRvXpggKECkMSIms89WDGTNp4zAHgWSmOy2dCmzIjPhtW1cWKO0QwrB0pjJAOe5BSqw/z21lFZ57eBsCg7DmYwFsBGYHoIrOrn3kfxm1KszYOYpTET45qEMHZq/wpy19M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SprYMmcJ; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SprYMmcJ" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-2ceaf8a1265so9054445ad.2 for ; Tue, 04 Aug 2026 21:29:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785904174; x=1786508974; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=CsJQ1UBzULplQjauLQuztygbP37D8KegaQ/fwFL4BdY=; b=SprYMmcJeiLourbT8vmrrUv+HGexNhwXAW6c8bl6FcjRYDHpFfGYgdX6OfiUtuCdEH TDhbfh4QS2CgOXusMlDzdh6TWTvwBWtg4AEsKr+IMV4LIfkyNw6MYh6OHwozKBSP2lub zxog2D12kyPHCAIn8YuZ9TArtJOR5Oc20P9zl8JZdnljMyTbokcaqqPoRw9ED0dSIVMX 2KSW3gx/g9J9JyqMCVd2jBliOQ0etKIimNzAn4wuMiA1B5abEJHvP0dNCXOpWIKGKlnQ T1w6TOTJ6YJFhDNI5fgIRp37uUNbXTaOVSOtyz5hxm3dx7r1joqOZMvDZa8n3pqbRrcL 9XBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785904174; x=1786508974; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=CsJQ1UBzULplQjauLQuztygbP37D8KegaQ/fwFL4BdY=; b=kiFRoVQ/60YXZ6+ytnD1GZ6A1nY3525Yy+R6D6RTFRJqrI4x4HKLV47txpFBI6LpuT w1GIppjbdi+4N1hrF9QZaet472MSX/5CHKpn1n+xx7bQ/Yq+S0nuBzxcrJekQqm9L40j E3CTla/3jx/N94U0nn0zVwQol7525uF8HGskF4cW2sOuHiTkpQz9U6Kl2B5aolJZtGOA Oa+miiqYfvKbqMZcpmYjpuBC81nFBn9UYehBMRV9ocL09rjb7UzLHBsg0QZZ0YSjHdGU R7jeBx1ELyWm5tkf6zfu0hPdIKRFdjhQcqIx2KhR5R8ZbTOe02sKslqSTZLEEpdQODZs 72cA== X-Forwarded-Encrypted: i=1; AHgh+RoxcHEJeRUA8725xEIjmU/YbXT+xEoVCSRbNHgkJTT9bJJWIA0Vp08LL68nGfl2NaVQKm7K3lztnMiSG18=@vger.kernel.org X-Gm-Message-State: AOJu0Yz10Ni/OPmDVaqKSgsznndEJwZiy/Co7LIFBZfI2+uyiwdoyobS +kYAoNgdi8UMadcT1DugKiZuAOBLt1O1q8cNBOWT4ebXO2CNXFRrumB3 X-Gm-Gg: AR+sD12TncCbUGDGc4dCox8vgUNgGIby34zlWcmTAwie/aLLHJCJSfldrM7eujLMppY xwlTAWCQQzf3QliMXg5zNaSZaMiZZRRsJv5g5UyiUmrBc1EYxK/aaev9+uWmhOWdT1vGapgZSPy ZFFe+Wiod2z6kNr538vNJZnhB/ElOBX+ek2hvXtEZRwhqCzq2Wn1OIBGPbKMR10b/2J2/OIc0VM T6OO4BnzgWR1Mx/WwD2vIOom74Q++z+lPoKyOMltufKtSleXxkE2Vnap7AXpjIYj98hoY9f5gaT rioPQmxxgBj+hXgCwiRMLXMuOALCCXMbAfyFa1Xp4yfxt1pkEEJUgB5xUAYullJXoceA3uaPq32 l7SPfCmIw9Rk6AOiiDgoVfFom4fBpB1L9lwH3i317wOXEJ42ws+KQa9iY+BQahwtIUW0PRXtmrS 3MPr2cAKZV5Q1qUb8qPWY7zSoynEM31Fzn2JW+KByVyZ3eCpVfs5KDpxU6wxhh1uUEtKdOq3VGC 4iQybg2aJE9yO53W3yV/1DLtIX8wA== X-Received: by 2002:a05:6a20:6a06:b0:3c3:7179:a640 with SMTP id adf61e73a8af0-3cb85df09famr4045038637.3.1785904173734; Tue, 04 Aug 2026 21:29:33 -0700 (PDT) Received: from google.com ([2a00:79e0:2ebe:8:bf3a:ac93:79c4:84fd]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-315867bc261sm10862873eec.28.2026.08.04.21.29.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Aug 2026 21:29:32 -0700 (PDT) Date: Tue, 4 Aug 2026 21:29:29 -0700 From: Dmitry Torokhov To: Sang-Heon Jeon Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/3] Input: clean up conditional returns with no effect Message-ID: References: <20260729171001.260698-1-ekffu200098@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260729171001.260698-1-ekffu200098@gmail.com> On Thu, Jul 30, 2026 at 02:09:32AM +0900, Sang-Heon Jeon wrote: > Hello, > > This series cleans up conditional returns where both branches return > the same value, so the check has no effect. The Input patch of the > treewide v1 series [1] is split per driver and posted separately. > > Patches 1-2 are generated by the Coccinelle script, which you can > find in v1. > > Patch 3 keeps the check in synaptics_i2c_reg_set() and returns 0 > explicitly instead, which is the preferred way when there are > multiple failure points. Applied the lot, thank you. -- Dmitry