From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: "Barry Song (Xiaomi)" <baohua@kernel.org>
Cc: senozhatsky@chromium.org, akpm@linux-foundation.org,
bigeasy@linutronix.de, hdanton@sina.com,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
minchan@kernel.org, ryncsn@gmail.com, yosry.ahmed@linux.dev,
surenb@google.com, Dongdong Zhang <zhangdongdong5@xiaomi.com>
Subject: Re: [RFC PATCH] zram: avoid preemption with CPU-based compression backends
Date: Wed, 5 Aug 2026 16:30:49 +0900 [thread overview]
Message-ID: <anLmcHXqEX3HvSpZ@google.com> (raw)
In-Reply-To: <20260805005545.66112-1-baohua@kernel.org>
On (26/08/05 08:55), Barry Song (Xiaomi) wrote:
> @@ -128,14 +128,20 @@ struct zcomp_strm *zcomp_stream_get(struct zcomp *comp)
> * so then unlock and re-try on the current CPU.
> */
> mutex_lock(&zstrm->lock);
> + if (!comp->ops->async && !IS_ENABLED(CONFIG_PREEMPT_RT))
> + preempt_disable();
We take slot_lock(), which is preemptible, under stream lock on
some paths.
> if (likely(zstrm->buffer))
> return zstrm;
> mutex_unlock(&zstrm->lock);
> }
> }
prev parent reply other threads:[~2026-08-05 7:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-05 0:55 [RFC PATCH] zram: avoid preemption with CPU-based compression backends Barry Song (Xiaomi)
2026-08-05 1:27 ` Sergey Senozhatsky
2026-08-05 1:57 ` Barry Song
2026-08-05 2:09 ` Sergey Senozhatsky
2026-08-05 5:09 ` Barry Song
2026-08-05 5:21 ` Sergey Senozhatsky
2026-08-05 7:50 ` Barry Song
2026-08-05 8:46 ` Sergey Senozhatsky
2026-08-05 9:01 ` Sergey Senozhatsky
2026-08-05 10:07 ` Barry Song (Xiaomi)
2026-08-05 10:25 ` Sergey Senozhatsky
2026-08-05 10:34 ` Barry Song
2026-08-05 10:37 ` Sergey Senozhatsky
2026-08-05 2:19 ` Bo Zhang
2026-08-05 2:31 ` Barry Song
2026-08-05 7:30 ` Sergey Senozhatsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=anLmcHXqEX3HvSpZ@google.com \
--to=senozhatsky@chromium.org \
--cc=akpm@linux-foundation.org \
--cc=baohua@kernel.org \
--cc=bigeasy@linutronix.de \
--cc=hdanton@sina.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=ryncsn@gmail.com \
--cc=surenb@google.com \
--cc=yosry.ahmed@linux.dev \
--cc=zhangdongdong5@xiaomi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox