From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C2BB4315A for ; Wed, 5 Aug 2026 16:36:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785947819; cv=none; b=LFqoWe87eyZWU4aHxFmNmKPO7MWKN2EoUuIhTIdnQzF0QnvPoqPE350NadEG/Gp7CPz2min19vRynuPF59esj2ug+1QK15xnpq7vR7AifCDLXKDv1XuCGdlheVHP7Her6JkFjg1nNrOjQRmUd/1C1skkEijgwjTbQ/7EJx8U5ek= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785947819; c=relaxed/simple; bh=NKXrbjm/zMNFvvXbQ+/jm42iOyhabs4DLjHwCiwQ1kU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=LDXhm60wGHatQ85fbogIkxeWQNLN7HQn7xN18Vt/k0pZDxBPTqyMvsgOrRLYk+m2zaT9vwhCGezKPrTkYdljFz6RqWwd+govaRQl8perueSHYHU5W37bOERpIHWCh5NXbDyuLf9WIquqSATWtIpRLkZeEZSNNtEbJdT4HK2e+VI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=wCLwgL12; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="wCLwgL12" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-4954afac04bso13047425e9.0 for ; Wed, 05 Aug 2026 09:36:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1785947816; x=1786552616; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=/axujK7LrHeb1d0FXfagnmvZblyReIfTbnI7OxB4cHo=; b=wCLwgL12wgmStfdWh1cGuXkAodlB3wrHjsguFKbKVCxmwyKGMbdnewc9o5clh8hcbP 6oEGmfHC3KnZSQeDV0Lpy+vOtPTXLGowP0gv1DudgSlcqbyxR1HZ4UzgiT9cfyWLu9kX BaoUvEjRCbVIExapCwYXmEdEhQMUY1GSsdLgqcqhZVpL9yvj/QNKqHigfDfjBkpcq8/o eTUcRAl3b4pQVXJ6KKqu6PKIyflUblVKLZsYTacxDxn3EAWiErKnkT0jHwIEEyGo/BRr 97uhZIGVjIQj0hw9MUso3UvBSK/++M26FxmtyZE7P1wmqmpkpgKdFrfUOESotMWGALeN j5jQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785947816; x=1786552616; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=/axujK7LrHeb1d0FXfagnmvZblyReIfTbnI7OxB4cHo=; b=UZZjGsoIMNBKDWZns+VcJ2wDZnXiDSGI+h6cBuoBjfmPqasM3mSbBDy/AYj9N77lhU CuhW/NEcmuR3KawcDRgIqZrG5edLo612mbGxkymHtjzqHZ3lnU0juC0K4+ldbGui6oOO jIbzW/gnZU+h7K6LMPPckvW8tHZQycNRlIQ83XMY/GisHXBbwF2XD7dDuoPqsqSHxf5k htLWbtCS2yiwBvUbUKrPA2eK++oakKKHspws0g4OxKlFiJG/6Y0hTrVrU7SYThhi8EmA zpch/nGMaPbPtDhvqZbiqR+nmc2m10nnLBgF31hVN52TvhqepH2Y4IrPDPPMnMv4S9rK AE1A== X-Forwarded-Encrypted: i=1; AHgh+RoZEQfewIQMI2PmQiY20CRmb0i+9PJ9+BfFc0Dat31Ikl01qwlfoB6rOB3/5+unxBTOnZnWzYg73FNYfZ4=@vger.kernel.org X-Gm-Message-State: AOJu0YxRoahIQuIgaSYC5sdr3O7Ll7YWq2RnrGpVpKIp6APSyFORAQVo 2IOOYO4UoHp+mpeO6IqcTmc3cuszuSWnLzL1SJ3ydYae0BkpbGJwF+yQHiEk0LRYCw== X-Gm-Gg: AR+sD11L/3eyfw3tPmk2uNcsN6Gz5ar7b8AoTFdCZMXKqF36bboT4ZIK3PSQKGKAIDU zRHTUYGsKDsixmMgwgKnd8Yu0Ey13rvBiQRYLBfJIxvbHQIZxUZabPcu909YRZAb3Hk9fhRV8w9 yGMTIeIB26JM0zljmpB84sHrE235qhvcdqrd4agoRwQNJnb/UhNrUBl3sjEw08m5VeOxstElRVs RHq0estZUKFaI6YZ55PnmvPzPtPyBqUyjL9tbcS4tLokuXVC6U9sop06X5QHbcP5Wis7JwLv3XX Wllmh/oRyBTngpHUBN3PlTaqWYJYklbaSIKwP8F+xd672An+DN3RoeA/NLOv+ryOwWZxnJedpMy MoY38ASFQMjNz+UJSurdxBD2oPJAtTFikF52VQi8V6lnDhjP7gFkl6eaUEAy0nO+9uk3uUJeh3t yROgKZTIOWzKvYOkoqP5DEtdEKrEwVaJULFojRZ5MEGvgjCZ/itQMgnpX2yoS+kTBdkAJFPBQaD G/tTqcCgIJ/rRg3nk8Hmwy/5rbN29cL X-Received: by 2002:a05:600d:8489:10b0:495:4749:16a7 with SMTP id 5b1f17b1804b1-4994e7c5e9bmr97339835e9.14.1785947815752; Wed, 05 Aug 2026 09:36:55 -0700 (PDT) Received: from google.com (135.91.155.104.bc.googleusercontent.com. [104.155.91.135]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4994e035900sm103071685e9.11.2026.08.05.09.36.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Aug 2026 09:36:55 -0700 (PDT) Date: Wed, 5 Aug 2026 17:36:51 +0100 From: Vincent Donnefort To: rostedt@goodmis.org, mhiramat@kernel.org, linux-trace-kernel@vger.kernel.org Cc: mathieu.desnoyers@efficios.com, kernel-team@android.com, linux-kernel@vger.kernel.org, syzbot+e0cc44465d6bae735679@syzkaller.appspotmail.com Subject: Re: [PATCH] ring-buffer: Prevent subbuf order change when resizing is disabled Message-ID: References: <20260805153225.2096152-1-vdonnefort@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260805153225.2096152-1-vdonnefort@google.com> On Wed, Aug 05, 2026 at 04:32:24PM +0100, Vincent Donnefort wrote: > Because ring_buffer_subbuf_order_set() frees buffer pages, we can't > allow it when risizing is disabled. A non-consuming reader is at risk of > use-after-free (rb_advance_iter()). > > Return -EBUSY on resize_disabled, matching ring_buffer_resize() > behaviour. > > Fixes: f9b94daa542a ("ring-buffer: Set new size of the ring buffer sub page") > Reported-by: syzbot+e0cc44465d6bae735679@syzkaller.appspotmail.com > Signed-off-by: Vincent Donnefort > > diff --git a/kernel/trace/ring_buffer.c b/kernel/trace/ring_buffer.c > index 8e2485bb3aa8..414bca2121a7 100644 > --- a/kernel/trace/ring_buffer.c > +++ b/kernel/trace/ring_buffer.c > @@ -7358,7 +7358,7 @@ int ring_buffer_subbuf_order_set(struct trace_buffer *buffer, int order) > > cpu_buffer = buffer->buffers[cpu]; > > - if (cpu_buffer->mapped) { > + if (atomic_read(&cpu_buffer->resize_disabled)) { Ha, my bad I forgot that mapped is not just "user-space mapped" but also "range-mapped". However probably the best is just to record_disable range mapped buffers in rb_allocate_cpu_buffer()... especially ring_buffer_resize() doesn't use cpu_buffer->mapped > err = -EBUSY; > goto error; > } > > base-commit: 075b74841bd0065a3bda3440873c747938e69b68 > -- > 2.55.0.571.g244d577d93-goog > -- Vincent