From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 67C6838E13F for ; Thu, 6 Aug 2026 05:30:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785994208; cv=none; b=AtZwRcW0Nvwo7r23df51Hqr0TGvcZW1oV183+ZfNXJnfSY2j6gD+Q/UH2rhC0XCkr/YOP9KgWsiidTrf3FbeUQGShidEgSL44yZWl9MkKoKQAIQDbVw6VMSbmUZbtqnWxSnVNhIuQ5bjmBvr6ci1lbjkSiXu3yriV0Z/ZJWHDLU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785994208; c=relaxed/simple; bh=b31zKUsU0T4DkjD+vdPYPtU9ZHrv1f+KUUqYIlZdmzg=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=tnrL8UaD64Jf9Ev8LYWScFu75K4Vv29L4LetptQMU/WafFj+GhASnWmLavpb6eKucE9aJdi7GPAKZ46fgWUou6mpK31nQg3i6WbyOdp+ELom+T+4XQrLjM9WmjSr/B89xHplWKs4FqKvzzEpJxMJqe/Oybv1MG1h7lvjUTJHzrM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=E85knDSm; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="E85knDSm" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-2cc7ef7ec27so22908575ad.1 for ; Wed, 05 Aug 2026 22:30:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785994207; x=1786599007; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:date:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=Gkqr2GZb86x9tP0LnxOy+56n+S3UugpLCf+3RJbnTVE=; b=E85knDSmzmS0iA2mPPMQOk2EamL7rOCDjY79JBrBfLSR9gwU6sV8ILQE1q9XKE002D kSUsrjrTiBGsKpxOMeIR8ETL35gT7UDOV+g1uJajScKcgrDyuHq5LIBBONNUUiyrfeoL IDNw+oXML+Hz/FqvUOg7sK13KxihrCuTOUta927QFxaBFv3XHAqZXh1nXp4sUTofolpu wCxqmrRVUTlbUH5uV9I7Fi33X1tSLtJWpng6wb6sEVeYEYVrShQqG8qDb232BUFHN+um 9f5cKHb7w1nNgjpNuSKFojUfKVWHBwerwo6c8V/RAaEzQn/Vm2awVMD54L//19WSneQ/ LTsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785994207; x=1786599007; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Gkqr2GZb86x9tP0LnxOy+56n+S3UugpLCf+3RJbnTVE=; b=enCePTyBpOKR5l2OlvblWWJaqVO3AqvxMRxhHPVdjdUV3W/qU/31BO62KLkJAz02v+ vYPyeTWOxE3svtPj45TbuNp0iwxfU/g7rVZir5uPTEpqqo4onl+NRFhZht8ykjNcsRPz PjUbn5ujiCE3vCn2JzKwUsjk11vTAHgtD9uyx3+8yb99DG9hwSdnJ5guFarUF2zFtnki GsukFQSlZdwx57ob10pLiFL6RAMU/W7385XhlchWb2f5fF2JfUzvvXGWR7cZ0eSbk2MA wo0JRBasKiwtemAPRmS5pXDaATzVpxU6im62i05O5NFesNM2MbOWfowgWPErAvfwh+UQ 4HSQ== X-Forwarded-Encrypted: i=1; AHgh+RrLx7xiWV6/8RWQR86OQ3Uj33dzjpwkOk9kQkCXcHM5Kwh71XNCX97v+Q6yfrbk6tP4SaIKOglvNlZly7I=@vger.kernel.org X-Gm-Message-State: AOJu0YwS8PxXYrPr/12f6rggafH4GT6hF4fO48YWLtT8cJ8+Obec/hs/ Bp91hazoqLgJ76k/vU0gxMvpMRxIwFhINgm77rP9z6lhboyKVdFX8c1K X-Gm-Gg: AR+sD11uYfE95lMrJ+d7+MMSaCJJNi6vFy+NWH7RH5U1dUOBWGICDCMAPNdgvSF3/+M fo5/ENPMXhIz1nrKDI4x6QxLZJuINX1cZRsnYB5zkdQHGMH8ScvolaCUHnT9SdcT0VGNuvVDOY9 LRBheSq0+8fp+D6FxjX0Y0YL5tz3nuvYwxjw2Jl88aaP0YLUyTCdv7nQnPXvGcdubiDtBgKGe8m Rm4eFkorLqoWRND6MztRrayGI0uRKWjZs6UQz93+U9Jzuehw6LoAOEMnN5ohHeVVoDossnRUYDU 5strTq0sBcFPcLtCIqFag3guv//J72M5w98g1ql2JWxjvlxflvznuaMBvosZZWtVcSdwpNhp1lS KfAoaanUx9PsBmTQPMxe9cprHAEdXKfdviUzYcqd96miDXudUzYJW2/TyDYp7tlPdNPIUGVCg9d 8Go764rxWzDlyqn/Pc89k5TGwdj/UX2PzCTTze/+IToqP5XHO6Nf5Qnw== X-Received: by 2002:a17:903:1b70:b0:2d0:cc92:f7c2 with SMTP id d9443c01a7336-2d0cc930325mr149023775ad.1.1785994206714; Wed, 05 Aug 2026 22:30:06 -0700 (PDT) Received: from localhost ([2a09:bac5:55f3:25af::3c1:3f]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2d0aa4c911esm25202225ad.66.2026.08.05.22.30.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Aug 2026 22:30:06 -0700 (PDT) From: Coiby Xu X-Google-Original-From: Coiby Xu Date: Thu, 6 Aug 2026 13:27:37 +0800 To: Sourabh Jain Cc: kexec@lists.infradead.org, Andrew Morton , Baoquan He , Dave Young , Pratyush Yadav , Mike Rapoport , Pasha Tatashin , Coiby Xu , open list Subject: Re: [PATCH v3 06/10] crash_dump: Only use kexec_dprintk during the kexec_file_load syscall Message-ID: References: <20260729033654.311541-1-coiby.xu@gmail.com> <20260729033654.311541-7-coiby.xu@gmail.com> <4eb634a2-375b-45ae-8cc0-7d5ea9f6e264@linux.ibm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <4eb634a2-375b-45ae-8cc0-7d5ea9f6e264@linux.ibm.com> On Wed, Aug 05, 2026 at 05:06:39PM +0530, Sourabh Jain wrote: > > >On 29/07/26 09:06, Coiby Xu wrote: >>kexec_dprintk will only be activated by "kexec -d" during >>kexec_file_load syscall. So use pr_* outside of this syscall. >> >>Fixes: 9ebfa8dcaea7 ("crash_dump: reuse saved dm crypt keys for CPU/memory hot-plugging") >>Fixes: 62f17d9df692 ("crash_dump: retrieve dm crypt keys in kdump kernel") >>Signed-off-by: Coiby Xu >>--- >> kernel/crash_dump_dm_crypt.c | 15 +++++++-------- >> 1 file changed, 7 insertions(+), 8 deletions(-) >> >>diff --git a/kernel/crash_dump_dm_crypt.c b/kernel/crash_dump_dm_crypt.c >>index 9a64e2d6841b..3ee01996778f 100644 >>--- a/kernel/crash_dump_dm_crypt.c >>+++ b/kernel/crash_dump_dm_crypt.c >>@@ -75,10 +75,10 @@ static int add_key_to_keyring(struct dm_crypt_key *dm_key, >> if (!IS_ERR(key_ref)) { >> r = key_ref_to_ptr(key_ref)->serial; >> key_ref_put(key_ref); >>- kexec_dprintk("Success adding key %s", dm_key->key_desc); >>+ pr_debug("Success adding key %s", dm_key->key_desc); > >Missing a newline in the above debug message. > >> } else { >> r = PTR_ERR(key_ref); >>- kexec_dprintk("Error when adding key"); >>+ pr_warn("Error when adding key"); >> } > >Missing a newline. Also, I think printing the error code (r) would be >helpful. Good catches! And I'll apply your suggestion! > >Apart from these two minor nits, the changes look good to me. > >Reviewed-by: Sourabh Jain Thanks for reviewing the patch! [...] -- Best regards, Coiby