From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C9365390CAC for ; Thu, 6 Aug 2026 06:30:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785997810; cv=none; b=kA8pfadWI9J2qAKf3ipNsDc9jaXcKYWXPV0doq5g47GFR+V89v22pmXa3DEMfSc791YTUZuO/LWnjdGn0/Y3LZfugJIl5elUOoFwFyygdVN8RV3e5uD2F7hFqXh8OW4q6QxlMAdn79o9X0wuvm4M1lB9wJHgD1itL3c962QC+Eo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785997810; c=relaxed/simple; bh=NnL3mXYWYKqHgOcHcUMcADt+IZQgLvS10ydauuY3FiE=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ZdMJ8VRIX0JuYhvNyRfQHSim15ZrqitZLbhiCkac54QFgPhZllfwFibreFdTGMQ0BxBfvIIjsQA2H2kWipNXakDH5M8xvXJmlc8YayAbVw/N4J9VKGov4+ZUH1FVVeQq+AwpeOi/W/wziKhXxpyLELkrcpiX8o/lM07TwxFkPBI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XZF03fUu; arc=none smtp.client-ip=209.85.216.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XZF03fUu" Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-38e3efab7e0so570127a91.0 for ; Wed, 05 Aug 2026 23:30:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785997808; x=1786602608; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:date:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=B/NHFXtKvpJgNsrg54qLLAZzpdpKsGUenXdJI9IHZDc=; b=XZF03fUubBLCksgj8SADthsVRfJXWmPMvwi+TGxlGrADrnSTBglswXaK9rUX1g1OBO ESkJVQNidH6KKBZEBjTdQlZz/6koKtOvezg6JW//+y9DI+o4NQzSsnqUdCgEflo800eH X7Lnx7bhg6EeOT/ZgSKqfqJY5PaGXxfB7ZfAdtvLhfzhmsz2BWTDcPZbaEu0j7sl/wDj e4go3fmkTjWMKetGCNYSr5aDmvDCpjeAK82BwiCakplkxwQxzFdYu9RPB8lW4R7cv5Xe H3c95ajIpH2d5dlXQgeM57c4QlIi+YIOY9BsaCRQ65WvGMtbgo/gX5CBtH9SwE5btu8+ 4rdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785997808; x=1786602608; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=B/NHFXtKvpJgNsrg54qLLAZzpdpKsGUenXdJI9IHZDc=; b=tSc8tK28u7kaUmu75etjdm0noeqDpVLEtSejCHpm4j1w29QnxvUTC61woMnj/SAw0n 8CDMKcS2xa7gZusaH6KIh3CvMrRS8lWxsluO6OwxojkZWweXw+hiMN+oJzD1ITOfq/c6 htS2T/4u7gnoyuk6OdxrR8onQWrS3kcgc4iVbmU9AffFvORIGiiqrxI+wLVQwmyZdgIE dF0toh7uBN3QZ6SDiyzTaxycql8f7a3YtncUGibexIT4y4/5XPH8i/AH+CZtZAtW9NBr 9nMg34yOB3bLczqP9gEPGhuEGAOlanHus1ooF5XNa/fdWowR+h8fKMcmd6Z6OfV/a1f6 dzMg== X-Forwarded-Encrypted: i=1; AHgh+RqGxXlBl1DhpveY4xIUe9s2vKk/hP3Cpqb6WCSkRal8FI+uHdZAvIOUK16yFJ51sl8tqXm5meKLmr4yAGI=@vger.kernel.org X-Gm-Message-State: AOJu0YxCLwlIGcF6gUOIgu9tTAvu08SAWTO0gXbo2tc3dLHatOEBgWE4 VMtuP0ElDoeYVyrcHfxvQ5tfWqNhmGgCtEGKYvbSnRtcBvzVn5q9eftxoqE62Oxv X-Gm-Gg: AR+sD10zyvIpxxjEJkXbOUzaeGjB3HEtxVXKxB1D4e48rWi+XGm4Hi3lgGFGa9EojyI oNQLHH4Tc36qBv2cd/gdPDiMypEs66Vz/KLb0B9YhD+s8f2BRR7z7LlYTdM7+WBC1NN+qIGo/OY x+XrFt7J8HrRr12pOrxF6OkjfjCY5eK/9t0xhhvtsQHQ7qBko5Uy/Axdp6LRJTC/n8/VPGn36rw De2DO2OsPpXlHm7TpEKKSsstwKFPwjLtvTQquiFeaiW4U1C+54va8bLimy7FzmJoG6wKN0Qmy7J UTnz2ufKMeeesAdiBGW56AQu8En0yi62ICjZ5BE8LhhVIxGQCqFe0R7OIa867GPjuMHT2CWAVow SptlrwnsCg9DsMqzYcm62mfYse8pMyN5zwBJ1AiYQf6Doq1RUkpLrDiCAkI+PffjRe1Sw93aZLB CjI6Ht1y+JgeQEcjyaslJhKTniE5vRsT5Ae+YuKb0eFHxeESXzqMDY/A== X-Received: by 2002:a17:90b:2d87:b0:385:3ab:fecb with SMTP id 98e67ed59e1d1-3908972ccc2mr916287a91.4.1785997808126; Wed, 05 Aug 2026 23:30:08 -0700 (PDT) Received: from localhost ([2a09:bac5:55f3:25af::3c1:3f]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39085de9f6asm853476a91.7.2026.08.05.23.30.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Aug 2026 23:30:07 -0700 (PDT) From: Coiby Xu X-Google-Original-From: Coiby Xu Date: Thu, 6 Aug 2026 14:26:27 +0800 To: Sourabh Jain Cc: kexec@lists.infradead.org, Andrew Morton , Baoquan He , Dave Young , Pratyush Yadav , Mike Rapoport , Pasha Tatashin , Coiby Xu , open list Subject: Re: [PATCH v3 07/10] crash_dump: Improve readability of config_keys_restore_store Message-ID: References: <20260729033654.311541-1-coiby.xu@gmail.com> <20260729033654.311541-8-coiby.xu@gmail.com> <816ce698-c4f1-4179-9741-798f5842742e@linux.ibm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <816ce698-c4f1-4179-9741-798f5842742e@linux.ibm.com> On Wed, Aug 05, 2026 at 05:22:39PM +0530, Sourabh Jain wrote: > > >On 29/07/26 09:06, Coiby Xu wrote: >>config_keys_restore_store currently doesn't validate the user input >>before restoring dm-crypt keys. Although it's not necessary for the case >>of vmcore dumping, it's better to do it for the sake of consistency and >>code readability. Also check the return code of >>restore_dm_crypt_keys_to_thread_keyring. >> >>Fixes: 62f17d9df692 ("crash_dump: retrieve dm crypt keys in kdump kernel") >>Signed-off-by: Coiby Xu >>--- >> kernel/crash_dump_dm_crypt.c | 13 ++++++++++--- >> 1 file changed, 10 insertions(+), 3 deletions(-) >> >>diff --git a/kernel/crash_dump_dm_crypt.c b/kernel/crash_dump_dm_crypt.c >>index 3ee01996778f..1f4549956824 100644 >>--- a/kernel/crash_dump_dm_crypt.c >>+++ b/kernel/crash_dump_dm_crypt.c >>@@ -370,12 +370,19 @@ static ssize_t config_keys_restore_show(struct config_item *item, char *page) >> static ssize_t config_keys_restore_store(struct config_item *item, >> const char *page, size_t count) >> { >>- if (!restore) >>- restore_dm_crypt_keys_to_thread_keyring(); >>+ bool val; >>- if (kstrtobool(page, &restore)) >>+ if (kstrtobool(page, &val)) >> return -EINVAL; >>+ if (val) { >>+ if (restore) { >>+ pr_warn("dm-crypt keys already restored!\n"); >>+ return count; >>+ } else if (!restore_dm_crypt_keys_to_thread_keyring()) >>+ restore = true; >>+ } >>+ >> return count; > >Nit: returns count even when restore fails. I'll change it in next version, thanks! > >Rest of changes looks good to me. >Reviewed-by: Sourabh Jain And thanks for reviewing and ack'ing the patch! > >> } > -- Best regards, Coiby