From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-001ae601.pphosted.com (mx0b-001ae601.pphosted.com [67.231.152.168]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D63641E6AD for ; Thu, 6 Aug 2026 08:47:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=67.231.152.168 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786006023; cv=fail; b=TeXEo2S1uGFYsHO0toqJTt3XdYeM0JvKqM9hAsI8prR9MLwrTwb7TxR87SJeZhP9bANKGCDe/lit0y1JP/96LpT6jWMd4EYYy9AlIjXR2HIflxiWRASy7GAYXNyhrIJDZLy9VZYC2J3xkrTUTu6vXyPt2E1CgBnKZxsxKxRPU90= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786006023; c=relaxed/simple; bh=kMxvQW0Jk6dCfpN+V6Yq4NPu9dfEhI4VvzMKqWGljSE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=smjmJLRUMHe1x32d8JF0sw+4exxZJDNrM73vKHKAFGO4OefMKwcU7SP49lgqsIqIo9iaaP/PM1OWgO6YFloL2X5KQ65NbilKjH3vP4DptO9rvkSabR6JTtTWgy17hG2cbghma190Vg+WMs/TSrJHXgSNSp+GjnjSijnDFeqrrGY= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com; spf=pass smtp.mailfrom=opensource.cirrus.com; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b=hhbnoPAX; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b=NJZkqIii; arc=fail smtp.client-ip=67.231.152.168 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b="hhbnoPAX"; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b="NJZkqIii" Received: from pps.filterd (m0077474.ppops.net [127.0.0.1]) by mx0b-001ae601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67626lja527299; Thu, 6 Aug 2026 03:46:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=PODMain02222019; bh=HpAlfSJ7k29KYq+VKy CLnnReFsZx2Zz9w43+Z8/XME0=; b=hhbnoPAXd5QfAyWQQSr8Kwfx1h2W2LMsjF hpcGWot2cNm8QTbdkbQWGwR75Lzt15DAc3Zb3lWbw5gYI+w4WIAwl9eiOZYvNtcx PFlMF9Ca6GyHISCTqvF5UJLL8qgJ+X0wBvb18jqAMmvD8Rn0kNH7N04E0V49USmU iK3TBrAZ6QMZiyXRN9gHnf0wkcwT4Bdav5Vd8nTl2glBdAPbs7eVPR37O6JEak8e NNw5hMYyoMCIhFhaRMgcpKIhuJWd24jyeP8q0qz5NIxDd4jlq8MoBlg9Ofyy3aTF tSIqp61J07Pc/YD8fBbxG/q+AaKc56bGNS6Klw9uu2ecxJOvdLrg== Received: from sn4pr0501cu005.outbound.protection.outlook.com (mail-southcentralusazon11021084.outbound.protection.outlook.com [40.93.194.84]) by mx0b-001ae601.pphosted.com (PPS) with ESMTPS id 4fv9s4hak6-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 06 Aug 2026 03:46:55 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=t7ZAlqfm41jaujItzZoitOcE2NQgf+fDii37gkqZsiWhFRmVLvMlYQwwPUB3nRWu3XCoC/cvZ0iOfbPc+BaFKzxpJCwKeqxThRfeincW3/hvX4TkLn+z4XEcpy0nWWOP3HeUwrQDS4/oAaFp6B56TXCUdCYbzDx8iTMhMLDCn4R6OIq7vvL+8OBbNQgMVptKMm21YSgtX00fvI2xryd6wxiaIrcYmUfSbAvggH3ZwzFG/8wa+DI4V+EC0qM+XFdvd4rhqTXIS+7a2B4zqbuY0d4xkIH6T8QQsormivbAzZSkvD/0Eb63EK28S3Ii8ixwSCMuS9MECt0vsa9WJhU+vA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HpAlfSJ7k29KYq+VKyCLnnReFsZx2Zz9w43+Z8/XME0=; b=BJBayV7NV8SGQG46Ohd5AM6nxobJnhAdBQQxtl6hg3ktfQMCnZo1BRpmSBieYo9XX7pylNRpk4+peJqJzsrucmZS9O2aBcG8/6vNtNSf8bva15+QJQjvvPcUzRIIbk1n1xZbD1tGKXcoyL+hitbNg9zUK0FG9CXYV1eFS3vOnRPW7NxHdDvIaGYqrZXnZd28xb5jUTZA60iu9njbChjHVc2Z5sp1WJecr0Eh2GOIw3OOH46mKrTks8ts+AUOWagqEbA6bB0686k48m4fv070oax7GO8NqIeZymHgXnmp6DfJuyXJXKnJR+VXQ1y+V05YrpUTMgjLDpnOahGi1BZhqQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=softfail (sender ip is 84.19.233.75) smtp.rcpttodomain=kernel.org smtp.mailfrom=opensource.cirrus.com; dmarc=fail (p=reject sp=reject pct=100) action=oreject header.from=opensource.cirrus.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus4.onmicrosoft.com; s=selector2-cirrus4-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HpAlfSJ7k29KYq+VKyCLnnReFsZx2Zz9w43+Z8/XME0=; b=NJZkqIiiMd9bH9kr327TdF757GZMNA3q3pknkcB9c2mSRsOSqXSBF/8zhNEwlgsNxbLvD8/meTzkMSggR4HzNfYUDo/HZf9sm3vjVLQBe9qvz+8XAktRlqlOSlF3RbKwzR0hcd2xEoeb2r7kj9B3MjTv6iOlhrZlcmOrxKuBtB8= Received: from SJ0PR05CA0167.namprd05.prod.outlook.com (2603:10b6:a03:339::22) by SN7PR19MB6784.namprd19.prod.outlook.com (2603:10b6:806:260::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.19; Thu, 6 Aug 2026 08:46:50 +0000 Received: from SJ5PEPF000001C9.namprd05.prod.outlook.com (2603:10b6:a03:339:cafe::1f) by SJ0PR05CA0167.outlook.office365.com (2603:10b6:a03:339::22) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.315.6 via Frontend Transport; Thu, 6 Aug 2026 08:46:50 +0000 X-MS-Exchange-Authentication-Results: spf=softfail (sender IP is 84.19.233.75) smtp.mailfrom=opensource.cirrus.com; dkim=none (message not signed) header.d=none;dmarc=fail action=oreject header.from=opensource.cirrus.com; Received-SPF: SoftFail (protection.outlook.com: domain of transitioning opensource.cirrus.com discourages use of 84.19.233.75 as permitted sender) Received: from edirelay1.ad.cirrus.com (84.19.233.75) by SJ5PEPF000001C9.mail.protection.outlook.com (10.167.242.37) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.315.6 via Frontend Transport; Thu, 6 Aug 2026 08:46:49 +0000 Received: from ediswmail9.ad.cirrus.com (ediswmail9.ad.cirrus.com [198.61.86.93]) by edirelay1.ad.cirrus.com (Postfix) with ESMTPS id 25BD5406544; Thu, 6 Aug 2026 08:46:48 +0000 (UTC) Received: from opensource.cirrus.com (ediswmail9.ad.cirrus.com [198.61.86.93]) by ediswmail9.ad.cirrus.com (Postfix) with ESMTPSA id 1039782025A; Thu, 6 Aug 2026 08:46:48 +0000 (UTC) Date: Thu, 6 Aug 2026 09:46:46 +0100 From: Charles Keepax To: Mark Brown Cc: Peter Ujfalusi , Richard Fitzgerald , Pierre-Louis Bossart , linux-kernel@vger.kernel.org Subject: Re: [PATCH] regcache: Use a consistent sort for defaults table Message-ID: References: <20260805-regmap-regcache-sort-v1-1-162186aad8b9@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260805-regmap-regcache-sort-v1-1-162186aad8b9@kernel.org> X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ5PEPF000001C9:EE_|SN7PR19MB6784:EE_ X-MS-Office365-Filtering-Correlation-Id: d43dabd8-9214-4421-7300-08def3974196 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|61400799027|36860700016|376014|23010399003|22082099003|16102099003|18002099003|56012099006|11063799006|10067099003; X-Microsoft-Antispam-Message-Info: CiQ+lL+AyirYYmkWMz32BQNhnr3W0l26bDYodc+R8pUfavf6l/g6EBEpVDsM9iltjgBvKUXlXUc9vzGDU1/Psn3CfS52tVzGfUIgYBjbTeli0d1xpc7bECDo1ZGwDCDbAN1f+pm64mHfWU3HXnln4wGX9xnLDcLnqhFULWt89SsBgx3AogKvv6kxRMw3bj9lWGl5ma85P244clm0LjQ8GOA3Rrhff4RDg+R19Hwip5XPxOgGREyktMnSqhOSybe2xr6vF0Ukpj/UVTxDynE/qv4BzNTN0vvkuSFRTtmH55IfY7qRcyCUSmgv/puVpJgsXB8813F6ijQO/aME5N1dWEpXBUChPDD/q39TnjJPhT1swcuVMG3GfKoprKbhzVlQuF2AwlpvYZBp1qu5369GF8JCAnXw9bzWlAyiIJkzWaq3oedifMl1OahWjHARzMvTqauf7B3I4axCB0Y/9ZJy3CS7r1ImbHnPF8yjGC/McV5+7mhGWMiWAE7O7JteM/pdInhYcT/CipmJYmvDf+TWa01eC0uCJRaQfs8Lm9drlrJDg1Ev+2wPHkBKbhlylc7vVgsb4tK62+Vr8Bjy4Kv3380hQRHo7fp0QbjZ4wN2c8J6iFnJEcGJs/EBAb8gZXLead3xnKJp54YMj81DeiHTOa9g/Hs1rBjrfpD1PesvgUv4tnoCCJIDFeM0I9G3j2rdwQr/0lw0jnwowEFApNGmNg== X-Forefront-Antispam-Report: CIP:84.19.233.75;CTRY:GB;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:edirelay1.ad.cirrus.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(61400799027)(36860700016)(376014)(23010399003)(22082099003)(16102099003)(18002099003)(56012099006)(11063799006)(10067099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: x0fn1aWcQye1ZfNbiD/pMNAEhjd0kD3mhQO3jCZVslhmx0xFd8r+GB3qzPtSW/NxGXVIJBp6E8GAlGiuqgMJs09rfId8NiGnFqyb7gMJFLbCvkIDK2XjuwEk9M19Ysh7gL+bKl1c9ZItg2UDMTSgqbY+St6LH9ublHqcK4CtQ3Djzp8Ge1iH1rtR9QSFeo87LbyyvM98of4uR6i8k/Cakh68CIEj14C2E2QL/LhjEVnL3Vw6527vsgdmwl4gMm4lDErNZos2cggEDm0SfBfebD/h5MrqzypPkqZWgWmzA+ZMzV8KC1hO7sr1HSsqAFPDbh9qpBRpUnB8/ZSQvMMm3+YIgfQSTGCflDG6usdQHOqsQFxbcpRocWnxQRE6DWYYFK+1hOOpSm4WmsPP8gMlHO4uyFA2DO5WowqX4Sd/OC8I0IJ/EfYHntTwwhNZPoX7 X-Exchange-RoutingPolicyChecked: KB4y1CKF4Pp3eEcyrp5MYDRPMPT5T/F4dJ68n05sYHT9PLrT7Iz8Oiv6michH53HQZPB5x5JABtKCpM/mcqgaQNvlPccJrKatMPee4VGZIU2MS53UI5V3BI6t9syyfHONWTzdUSck9t8B5v7H0HpS3xWZ2vm8O3ieCIPza1RgraxWtU8vrcakm/pthDVzZmE+YIaP3UvnQ9nLPMsIQGlJ0rbp4nPHgm+sJ6stjVBtc8URH3BoNM/1aGXEDNSUj6N0basFm3wkWUN5wmOAJAkNu6uF5fRtWXMaI2sJ50uQPFtMppuir649fTJZv6D8Z69m+bF5wZphBY14l8XZJI4BA== X-OriginatorOrg: opensource.cirrus.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Aug 2026 08:46:49.5905 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d43dabd8-9214-4421-7300-08def3974196 X-MS-Exchange-CrossTenant-Id: bec09025-e5bc-40d1-a355-8e955c307de8 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bec09025-e5bc-40d1-a355-8e955c307de8;Ip=[84.19.233.75];Helo=[edirelay1.ad.cirrus.com] X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TreatMessagesAsInternal-SJ5PEPF000001C9.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR19MB6784 X-Proofpoint-GUID: otPaFywu6NFi9WdhBfa_RBeiVG0B_hE1 X-Proofpoint-Spam-Info: AW1haW4tMjYwODA2MDA2NyBTYWx0ZWRfX47R98Xa/0KNZ YKpoTO5iUdtgtqymvloh/fGHDuIy3oZGFFJTUES+EDhCL2TWfcdWCSypMbBUGi4rFsV+QVy/+Ve B9zoyOBmNtD+3x92+HG6DrxIi2wg0b8= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODA2MDA2NyBTYWx0ZWRfX9huN5eZd4WVr QS2H2U8k0jyLFvSkbz4ZrtbKvqwFEiXweoBc1LttJsZ5KqygbgytBcgKDeXhstBNC3AzV0O0VRs d2b0VW6A3SuZT+nkZauP4rBaDHddU+9hSxVBB8oLtobDkUYVBKb7zlJnK7VnRiB2P1dqmITIg8d 6Z1EHa1Rb9EGIj8ChnrnJM3AWOpk+XdiaO8s/2ZSuAoDj65kRzRrcmWclWkBdn9SB1ZM91hkZdg G1zKdN7n4VGlyUpiYKnETh3Dh8L996yZKNEO6vKbpgAXk77agwilX97bsGqgNG5NWJ360jNFGDC pz/jcd5T2GAuRmiKpei4RNrYSPwrBoP1IIi/CB//e9XLCXbxqRYBXj4fzBq5Q9UVWBB6ZW2PEFa /BenbFWQqVCKJuZSKh0iIazFSNBP9fhrYlGjIbxD607AyAK3Abs1UFSnWkATJ9xr2jTGjOl1Yee uoES6wNNE/xhqIbfN8Q== X-Proofpoint-ORIG-GUID: otPaFywu6NFi9WdhBfa_RBeiVG0B_hE1 X-Authority-Analysis: v=2.4 cv=G5cs1dk5 c=1 sm=1 tr=0 ts=6a7449ff cx=c_pps a=FdfMFdOEn1VR10XCui1xPA==:117 a=h1hSm8JtM9GN1ddwPAif2w==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=kj9zAlcOel0A:10 a=Sv0fKeRqtYgA:10 a=s63m1ICgrNkA:10 a=RWc_ulEos4gA:10 a=VkNPw1HP01LnGYTKEx00:22 a=iX4cTi3TZMoOKdANLEfx:22 a=KfkQE9S9VqCBgivYGm0O:22 a=VwQbUJbxAAAA:8 a=w1d2syhTAAAA:8 a=2cQ26MNXuCa4EmXORkMA:9 a=CjuIK1q_8ugA:10 X-Proofpoint-Spam-Reason: safe On Wed, Aug 05, 2026 at 06:51:00PM +0100, Mark Brown wrote: > When we look up registers in the defaults table we use a binary search, > and we have a regcache_sort_defaults() API to help drivers that constuct > their defaults tables on the fly. Unfortunately the lookup and the sort > don't use the same comparison function, and to make matters worse the > comparison function used during lookups is written for signed register > numbers rather than the unsigned ones we actually have so can produce > suprising results when some of the addresses have the top bit set. > > Standardise on the more explicitly coded function to ensure consistent > results. > > Signed-off-by: Mark Brown > --- Reviewed-by: Charles Keepax Tested-by: Charles Keepax Thanks, Charles