From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7AE02429031 for ; Thu, 6 Aug 2026 09:45:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786009506; cv=none; b=Njh/2cg7YapNeakbUeS0maosfBKvnAtSAP+xtMVhFl7jTeBpPJulEW+Wp+MpxwuHztN0zL2rTCmb7ZWH2qogm2S1rfc2zaJz4/LsO6BqvInuBuVWW/jgkMBB9Z/oNdCZOdCaj1/iwtVbyfT9D7j3sutwnVeNLyyYNz7z4QI+K/g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786009506; c=relaxed/simple; bh=TeAZHoCbWw14IefsUCwbSK6oDvJqdpRiQEV6O22Uwdo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=EFNPFGK9KLNMrezUri/34cwpr7CuyD+7Icz8ZwNATTWfvMStfPzvqEljumpUveCcdh2NjotNx+HahSsNsnN4796hByE2o90NNjkueVC59ztM74tt+kCaLu92Zm5LhekjKxzaaHaWGh4LTgZQ9R1kvfsV4o6sA9bSSkJaJVoiCCM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=szjr0vtA; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="szjr0vtA" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-49554ebb87dso17723475e9.3 for ; Thu, 06 Aug 2026 02:45:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786009503; x=1786614303; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to:content-type; bh=G2/mFRvlwdBz00We0HdqUhSQE0scSFWYjxULPu/jANo=; b=szjr0vtABgDNLyJLaIOUkNG4QiFcJuC7rtENQqJ5To1adbXwnZ3PHeoSehHSyCWPYT ZamsyWainDw38aNnbKu5r5bfCnwyAQo4M62fQsKKguB8tVYzLocf+3lDHGN0ck/ob/TL hNvZIdRL6UXS7nleOEx7DVt1YC5s8OjNGvaLNxbgxknXnBFJ86OmDwbxvR8qYaqWiJH7 ABwjxWnN/ANtN873GWzzRP/00rvclcLBuLaEPmhEtjtRFr5l6FIMczWAAXO0l5P9Kqpl 1/8q+AGNW9h9inJXWwVwWiI0vJfRrCrRmuWdCJpGtq+0FCDKqRVWcWXvlS6t4y+M1873 OFJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786009503; x=1786614303; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=G2/mFRvlwdBz00We0HdqUhSQE0scSFWYjxULPu/jANo=; b=bA+HD7EABUtAiUoZ93eOt6MvgFs481Q2EF6sgcIsFwJ5l7K4z6asvtYhbDGhPHfi5X SRIKiFrJWV3kAm8lIiJGoqbyPxgpralZsNfGdA4LEpsts82JlfTdPpfIX87wy46TH6oB +L35Z/JfwZfjhmPWUp1q4WiCroLTnBbEk6uyQHwLJ9i627g9DMqUpbnsOAuKufcbkBjD kwO8PT3WgZs/VOP/Aav2wAuoQATND7WbtDfE6n8NSWIw3vV1HFDbT32tieON9jOGCv+n dLY5CBUE0O1uxylLTRvAOx+WoIeNxSXNOSne4OC17o9Kj4TkKvFxIQ0sau0VhPXg8Fuv Hdtw== X-Forwarded-Encrypted: i=1; AHgh+RptVXIUzg0G8gD/IKBMHxD4Hpu2hat6dtbdo+GdHeJT4uRomD04yfI1x7CVv1XMuHAR3ZYHucb3hNhJQMQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzzQG7qbkcxgMX0r5UHxob1VhP9FoL8mxr03pgP3KjcOBrcDyxJ mGkbYsUC6OywCYOB9wHRm85KOWaqO+iHXqFLxEAPptUJ4TPBIObqAJCF X-Gm-Gg: AR+sD107HQkrO/J2vg+GSEAuBqTkS6bkus0MiO5mjNloYwIEd128N1aCTerdkcTdZzL IRxI81K3LbMXfHCTTh4W20D1pTpjeVUEwopyyfhrkJOfC0D6H4GJ8ltZB6FvrgaB3g1dktgj+kk M4rJAUXza2/4gmEMkuhRDW+leW9Z/4BB6EIUCt64EF2+QvApveZlEyjBUNJ4z9ckCoMCeQuFN3x dnSo4IzK2tFtkpBoHvnc53TNn2V+Gt8g6iiomYjSD/Izr0OGNOxp1D8ZU6tcJvGPD15WTgixdow uGif0D7mq+N0KGBdY07miA0WeYkKGHH4SyeNoPiffiAosPj0EsHYagv7KDK6WaJPmOJFBAuixsp Yun3+ZtmjNEtrIKWsLsAe4DePF0ic/KiNQjJuOWaz3ElPUThHCisQV/TE6J3T2fNlXcwPWICBxt Ea3aFjmFj0lUvhJrmThCgR1PVBznr4pxF71x7jW7hDUifXhExyNSb7 X-Received: by 2002:a05:600c:4444:b0:493:a438:7f98 with SMTP id 5b1f17b1804b1-4994e7d4057mr171030015e9.18.1786009502685; Thu, 06 Aug 2026 02:45:02 -0700 (PDT) Received: from nsa ([148.63.225.166]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4994e99b8b5sm76385095e9.2.2026.08.06.02.45.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Aug 2026 02:45:02 -0700 (PDT) Date: Thu, 6 Aug 2026 10:46:13 +0100 From: Nuno =?utf-8?B?U8Oh?= To: =?utf-8?Q?Nicol=C3=A1s?= Antinori Cc: Jonathan Cameron , Andy Shevchenko , Brigham Campbell , David Lechner , Jori Koolstra , Nuno =?utf-8?B?U8Oh?= , Shuah Khan , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linux.dev Subject: Re: [PATCH] iio: humidity: am2315: add am2320 to i2c_device_id table Message-ID: References: <20260805183733.1000550-1-nico.antinori.7@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260805183733.1000550-1-nico.antinori.7@gmail.com> On Wed, Aug 05, 2026 at 03:37:26PM -0300, Nicolás Antinori wrote: > The AM2320 is fully compatible with the AM2315 sensor in terms of I2C > communication protocol and measurement conversions. > > Add the "am2320" entry to the i2c_device_id table. > > Signed-off-by: Nicolás Antinori > --- One minor comment from me (maybe Jonathan can tweak it while applying). With that: Reviewed-by: Nuno Sá > Tested with Raspberry Pi 3b+ > > Used as reference AM2315 Datasheet [1] and AM2320 datasheet [2] > > [1] https://cdn-shop.adafruit.com/datasheets/AM2315.pdf > [2] https://cdn-shop.adafruit.com/product-files/3721/AM2320.pdf > > drivers/iio/humidity/Kconfig | 4 ++-- > drivers/iio/humidity/am2315.c | 3 ++- > 2 files changed, 4 insertions(+), 3 deletions(-) > > diff --git a/drivers/iio/humidity/Kconfig b/drivers/iio/humidity/Kconfig > index 54f11f000b6f..6907805945f3 100644 > --- a/drivers/iio/humidity/Kconfig > +++ b/drivers/iio/humidity/Kconfig > @@ -5,13 +5,13 @@ > menu "Humidity sensors" > > config AM2315 > - tristate "Aosong AM2315 relative humidity and temperature sensor" > + tristate "Aosong AM2315/AM2320 relative humidity and temperature sensor" > depends on I2C > select IIO_BUFFER > select IIO_TRIGGERED_BUFFER > help > If you say yes here you get support for the Aosong AM2315 > - relative humidity and ambient temperature sensor. > + and AM2320 relative humidity and ambient temperature sensors. The above (same on the tristate title) does not really scale nicely and we've seen too often already. So I use something like "... and similar devices" - Nuno Sá > > This driver can also be built as a module. If so, the module will > be called am2315. > diff --git a/drivers/iio/humidity/am2315.c b/drivers/iio/humidity/am2315.c > index f29baa251f9f..5bce5eec45cc 100644 > --- a/drivers/iio/humidity/am2315.c > +++ b/drivers/iio/humidity/am2315.c > @@ -1,6 +1,6 @@ > // SPDX-License-Identifier: GPL-2.0-only > /* > - * Aosong AM2315 relative humidity and temperature > + * Aosong AM2315/AM2320 relative humidity and temperature > * > * Copyright (c) 2016, Intel Corporation. > * > @@ -251,6 +251,7 @@ static int am2315_probe(struct i2c_client *client) > > static const struct i2c_device_id am2315_i2c_id[] = { > { .name = "am2315" }, > + { .name = "am2320" }, > { } > }; > MODULE_DEVICE_TABLE(i2c, am2315_i2c_id); > -- > 2.47.3 >