From: Vincent Donnefort <vdonnefort@google.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Fuad Tabba <fuad.tabba@linux.dev>,
maz@kernel.org, oupton@kernel.org,
linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev,
catalin.marinas@arm.com, will@kernel.org, mhiramat@kernel.org,
alexandru.elisei@arm.com, joey.gouly@arm.com,
seiden@linux.ibm.com, suzuki.poulose@arm.com,
yuzenghui@huawei.com, qperret@google.com, ardb@kernel.org,
linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCH v3 01/11] tracing: Include linux/types.h in trace_remote_event.h
Date: Thu, 6 Aug 2026 13:35:40 +0100 [thread overview]
Message-ID: <anR_nEDeWLYKIs7P@google.com> (raw)
In-Reply-To: <20260806081952.5cbd8170@gandalf.local.home>
On Thu, Aug 06, 2026 at 08:19:52AM -0400, Steven Rostedt wrote:
> On Thu, 6 Aug 2026 09:43:00 +0100
> Fuad Tabba <fuad.tabba@linux.dev> wrote:
>
> > > My ack still stands, but I wonder if we should just not use the include and
> > > instead s/bool/_Bool/ ?
> >
> > I'd prefer to keep the include, if you don't mind.
> >
> > As far as I can tell, apart from the typedef itself, the only headers
> > built into the kernel that use _Bool as a type are a uapi one and
> > arch/um's user.h when it's built for the host, neither of which has
> > bool available, plus what looks like a leftover in bcache_ondisk.h
> > from when it was uapi.
> >
> > The include also covers whatever field gets added next.
> >
> > Happy to switch if you'd still prefer _Bool.
>
> The reason I suggested this is because I'm not sure how much we want to add
> Linux headers to files built for the hypervisor.
>
> If Vincent is good with adding this, then so am I.
>
> But I rather have him give an ack before we do.
>
> -- Steve
We have types.h already in several places in the hypervisor, so I think it's
alright to include it here also.
Reviewed-by: Vincent Donnefort <vdonnefort@google.com>
--
Vincent
next prev parent reply other threads:[~2026-08-06 12:35 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-04 11:23 [PATCH v3 00/11] KVM: arm64: Restore type-checking across the host/hyp hypercall boundary Fuad Tabba
2026-08-04 11:23 ` [PATCH v3 01/11] tracing: Include linux/types.h in trace_remote_event.h Fuad Tabba
2026-08-05 20:54 ` Steven Rostedt
2026-08-06 8:43 ` Fuad Tabba
2026-08-06 12:19 ` Steven Rostedt
2026-08-06 12:35 ` Vincent Donnefort [this message]
2026-08-04 11:23 ` [PATCH v3 02/11] KVM: arm64: nVHE: Share the stacktrace per-CPU declarations with EL2 Fuad Tabba
2026-08-04 11:23 ` [PATCH v3 03/11] KVM: arm64: nVHE: Declare the hyp event IDs before defining them Fuad Tabba
2026-08-04 11:23 ` [PATCH v3 04/11] KVM: arm64: nVHE: Use NULL to reset the trace buffer backing pointer Fuad Tabba
2026-08-04 11:23 ` [PATCH v3 05/11] KVM: arm64: nVHE: Run the source checker under C=2 Fuad Tabba
2026-08-04 11:23 ` [PATCH v3 06/11] arm64: pi: Run the source checker on the libfdt objects " Fuad Tabba
2026-08-04 11:23 ` [PATCH v3 07/11] KVM: arm64: nVHE: Pass host VA arguments as pointers Fuad Tabba
2026-08-04 11:23 ` [PATCH v3 08/11] KVM: arm64: Move the host hypercall interface to its own header Fuad Tabba
2026-08-04 11:23 ` [PATCH v3 09/11] KVM: arm64: Type-check hypercall arguments at the caller Fuad Tabba
2026-08-04 11:23 ` [PATCH v3 10/11] KVM: arm64: nVHE: Check hypercall handlers against the declared ABI Fuad Tabba
2026-08-04 11:23 ` [PATCH v3 11/11] KVM: arm64: Tag host-VA hypercall parameters __kern Fuad Tabba
2026-08-06 9:17 ` [PATCH v3 00/11] KVM: arm64: Restore type-checking across the host/hyp hypercall boundary Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=anR_nEDeWLYKIs7P@google.com \
--to=vdonnefort@google.com \
--cc=alexandru.elisei@arm.com \
--cc=ardb@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=fuad.tabba@linux.dev \
--cc=joey.gouly@arm.com \
--cc=kvmarm@lists.linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=mhiramat@kernel.org \
--cc=oupton@kernel.org \
--cc=qperret@google.com \
--cc=rostedt@goodmis.org \
--cc=seiden@linux.ibm.com \
--cc=suzuki.poulose@arm.com \
--cc=will@kernel.org \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox