From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 847C83191D6 for ; Thu, 6 Aug 2026 17:09:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786036159; cv=none; b=thdXdVwLGNRH/JYsCTCjwqQrBTPwnakFm2YAUcnJ012CbxguoiTou1+d4TN0oBzdQ9uNR/dLXtMRCwRi+pxclqs+f+1qyVP+LFwl+T+OB+ipgS6pH5A6SMkT0e+qkdA+DPe1nq0T3jImObdKmNQjB2ovIBkpPULJdFXEDWjbcPs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786036159; c=relaxed/simple; bh=EwJlQhSQMk4+H4UB1KrYYY0nmJriPg4JWMQ7dVhbqPk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=cLJ4MtRb2TVvGjcZqj2/rlfk8Zoc8xaYCS+GVwvmCDb3T2efZJ3sOKdccMZ6RMBLWNRP5QFeH2K9LH9EDz9Bqo4ifyG2A6WXNwMCmLTnZJJNgi7Wr91wYjUQGCg0awMh8CJKN1/87i1A3mfrLwLQxeu+UbmGmgc7SfdsxK0LIbk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net; spf=pass smtp.mailfrom=gourry.net; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b=qxsg8e2q; arc=none smtp.client-ip=209.85.216.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gourry.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b="qxsg8e2q" Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-38e347638adso2774623a91.0 for ; Thu, 06 Aug 2026 10:09:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1786036157; x=1786640957; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=BrNvbsHqFNUR3TBZVVh5jck8vhH3UNtuIjBL6oQXZGU=; b=qxsg8e2qyS7f5u5NV+W5JItv7tI++Zhj3QN2MDmu1ZBvQcpran/Zu/GAPR9yl1z63F CXyg6pVO15jRT5LSAloY8FmNnPNr2ih6tieuKgAWvN291UiFKuH5tapjExv3rDon8+Hn ZKrXppYgVkoNhvquNCDVojMjHmpY84ydsP5HxoixMhFxfIAxewsUA3OXKC0VaUDsa5lo BJqAlaSh1Ez+r8dS7iVprrL8z+0rIEaSMjEClc12NhLqpaE/xPrsCKEw/MF7PYpZflgc LlLusPvxLQgiDuVlbkBeSkiCIzWz3l9qKv2wjNGvktkPsS0JyqCDfhAsVEkXBpCUc2rT CbfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786036157; x=1786640957; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=BrNvbsHqFNUR3TBZVVh5jck8vhH3UNtuIjBL6oQXZGU=; b=UmdKuvVrZAnD8WVYPV7gaSdw/K/rwU8Ud60qItBZwEMqp/PPGhMI/ojjIDBhsLp8Bi UVWP+XYKjL5aIX2LWeHndg81AWMLrdRRHEC1CddJJA5FH/jNCPzRx8f5M1oTNZX9PfLq r3ZctWtnI18rmtDdbO13ikw5Kbik1mY8Ypj53gruXnSbwuEFnT9dZext//fSgF/yxqxK Nd6EDbUDqqTm2K41479kbedfVv6QBlYERFcvGqOxPftkLalvQ+hBCJnn+ExOvpZ6jWM7 0lq2tfD0MzcGLd3EbYvvCpXRIbE2AhbNYCVT2vHBI2JwwzDNpFnaixOVjGU7QqDFFUpf QFow== X-Forwarded-Encrypted: i=1; AHgh+Rqi1C1c+9fumxeHCj4DU5tKRHc+K5nchsc8qj/Kk3lmQdTkvHRPIv8LVD0bR2hqkHaxJpXUZApoKgD9XHQ=@vger.kernel.org X-Gm-Message-State: AOJu0YxFLAlTLyic3q0mU8fut8blOYqTBacX3ATOpfLMZXxUkL1IySzL eB1NW16sIR5bKpMhQo1E+p8avP/hU/0ZIBEg1HZLuvQ1BjCYBp8VUg+yf894RIcb3N4zhni3Erb KtNoMiYg= X-Gm-Gg: AR+sD137nbnjhjzqGE39B+sUoSxCqtNsqLoUBx5AgVgN+KHh8r8c4x4YfTmguJSxgNM tCfbnOdCOKEOqQ8r+1jKWC+zQooOdiUnu4zITTLSS12RVkzkYuoUZXCLHF6UcjV8uH0nmElSRwl bgFAUpZe6OJiy9vVQA2a6wmhvW75btDGDyngPJFzX2kRowB4ds8My/NcB5OfqNzpYhPlRfsrCZS 6u4yMMptP+BHImDPozSMyRaACHgiV/s8Ew7/tzkBQovKz4imj2+Bdokz+BKAAJJ9qO+FcUpRubD umvKgfjSU2Cz9SGZVDWMpdrhved0J8lU1hEd+WfWhGQ88spyJe643D1l47AODw2fnKOtL+J7768 MnDRJGE+YF4pu3WRbLZq7JsIgJG7D5aybI7HbG5UikweZvbBubtWdvuUxZvpjodtGLuSwSgON7H aLId4tF0HTnqbRkm9thf7bS5wzaQiWLx5rWBZbyTaKc39IN/Nazb7bkA== X-Received: by 2002:a17:90b:4c86:b0:37f:c22a:c188 with SMTP id 98e67ed59e1d1-3903c5590dfmr14716699a91.4.1786036156912; Thu, 06 Aug 2026 10:09:16 -0700 (PDT) Received: from fedora ([2607:fb91:201f:cebc:3a68:390a:144e:1b87]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-140f744adb2sm13381819c88.2.2026.08.06.10.09.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Aug 2026 10:09:16 -0700 (PDT) Date: Thu, 6 Aug 2026 12:09:12 -0500 From: Gregory Price To: "Lorenzo Stoakes (ARM)" Cc: "David Hildenbrand (Arm)" , linux-mm@kvack.org, damon@lists.linux.dev, linux-kernel@vger.kernel.org, kernel-team@meta.com, sj@kernel.org, akpm@linux-foundation.org, ziy@nvidia.com, baolin.wang@linux.alibaba.com, liam@infradead.org, npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com, baohua@kernel.org, lance.yang@linux.dev, usama.arif@linux.dev, vbabka@kernel.org, jannh@google.com, matthew.brost@intel.com, joshua.hahnjy@gmail.com, rakie.kim@sk.com, byungchul@sk.com, ying.huang@linux.alibaba.com, apopple@nvidia.com Subject: Re: [PATCH 4/4] mm/mempolicy: skip zone device folios when queueing folios Message-ID: References: <20260728194714.3713735-1-gourry@gourry.net> <20260728194714.3713735-5-gourry@gourry.net> <82f6afba-756c-4ffd-bd5d-c3432179af28@kernel.org> <0c90b9ae-48ac-407f-9d73-4c501c82cf40@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Aug 06, 2026 at 03:16:03PM +0100, Lorenzo Stoakes (ARM) wrote: > On Thu, Aug 06, 2026 at 04:11:21PM +0200, David Hildenbrand (Arm) wrote: > > On 8/6/26 15:36, Lorenzo Stoakes (ARM) wrote: > > > On Thu, Aug 06, 2026 at 03:25:50PM +0200, David Hildenbrand (Arm) wrote: > > >> On 7/28/26 21:47, Gregory Price wrote: > > >>> mm/mempolicy.c | 4 ++++ > > >>> @@ -797,6 +799,8 @@ static int queue_folios_hugetlb(pte_t *pte, unsigned long hmask, > > >>> folio = pfn_folio(pte_pfn(ptep)); > > >>> if (!queue_folio_required(folio, qp)) > > >>> goto unlock; > > >>> + if (folio_is_zone_device(folio)) > > >>> + goto unlock; > > >> > > >> Leave the hugetlb part alone. hugetlb folios will never be ZONE_DEVICE. > > > > > > :P > > > > > > But dear God we have got to find ways to stop hugetlb being this big stupid > > > nightmare that every single path of mm has to put an asterix next to itself > > > about! > > > > Yeah, possibly unifying the code (possibly, because it's a mess) but not > > replicating checks that don't make any sense for hugetlb. > > Yup agreed. > No disagreement here. I'll drop this. ~Geregory