From: Breno Leitao <leitao@debian.org>
To: Gustavo Luiz Duarte <gustavold@gmail.com>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 3/4] netconsole: reject enabling a target with no remote IP address
Date: Thu, 6 Aug 2026 08:58:15 -0700 [thread overview]
Message-ID: <anSvBeRT4vqq5uZV@gmail.com> (raw)
In-Reply-To: <20260805-netcons_ipv6-v1-3-170a35b92da1@gmail.com>
On Wed, Aug 05, 2026 at 10:33:03PM +0100, Gustavo Luiz Duarte wrote:
> The command-line path already requires a remote address, but if a user
> creates a dynamic target and enables it without setting a remote
> address, we currently try sending netconsole traffic to "0.0.0.0".
>
> Refuse to enable a target if the remote address is unset.
>
> Signed-off-by: Gustavo Luiz Duarte <gustavold@gmail.com>
> ---
> drivers/net/netconsole.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/net/netconsole.c b/drivers/net/netconsole.c
> index 070bae7b4fd7..a41b0a5ce64f 100644
> --- a/drivers/net/netconsole.c
> +++ b/drivers/net/netconsole.c
> @@ -471,6 +471,12 @@ static int netcons_netpoll_setup(struct netconsole_target *nt)
> int err;
>
> rtnl_lock();
> + if (nt->remote_ip.family == AF_UNSPEC) {
> + np_err(np, "remote IP address not configured, aborting\n");
> + err = -EDESTADDRREQ;
> + goto unlock;
> + }
Why not doing it before the rtnl lock?
next prev parent reply other threads:[~2026-08-06 15:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-05 21:33 [PATCH net-next 0/4] netconsole: validate a target's IP address configuration Gustavo Luiz Duarte
2026-08-05 21:33 ` [PATCH net-next 1/4] netconsole: add an address family to struct inet_addr Gustavo Luiz Duarte
2026-08-06 15:49 ` Breno Leitao
2026-08-07 11:21 ` Gustavo Luiz Duarte
2026-08-05 21:33 ` [PATCH net-next 2/4] netconsole: use the address family instead of the ipv6 flag Gustavo Luiz Duarte
2026-08-06 15:55 ` Breno Leitao
2026-08-07 12:00 ` Gustavo Luiz Duarte
2026-08-07 13:11 ` Breno Leitao
2026-08-05 21:33 ` [PATCH net-next 3/4] netconsole: reject enabling a target with no remote IP address Gustavo Luiz Duarte
2026-08-06 15:58 ` Breno Leitao [this message]
2026-08-07 12:11 ` Gustavo Luiz Duarte
2026-08-05 21:33 ` [PATCH net-next 4/4] netconsole: reject a target mixing IPv4 and IPv6 addresses Gustavo Luiz Duarte
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=anSvBeRT4vqq5uZV@gmail.com \
--to=leitao@debian.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gustavold@gmail.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox