From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 21090377AAF for ; Thu, 6 Aug 2026 18:00:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786039254; cv=none; b=lKvzSQBewNvWgqXi1Uc1fNUPV5xeSN78la4bSwF4PdcGsHkOWRn0sgcGk52PqPixn2T3McfclvXqDHDrQW0eW103M/jZBPShHhIu0w+cVoa+VvIjItgscdtIT3aTnov0d2oqhlLqjMlgcmsQih/SM+rpqr2JkPOP/T35md88Y8s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786039254; c=relaxed/simple; bh=J3avfEfW9gW/TN5lEejRtS4N/STs0EUCkLfklwncbOM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=rOSYAMsbBxk9+M3vHEUeoc4+qqY1djJT75maqlXa5n59ndFAFmi7yFAnef8IyvV2LRYCezHxuArG9EJd8IbhokIalkmG/bxEkY1yZHYiqeuHM5sa4NuoeB3vyF6FM1YTNkUYWdOKsiRP27lPdVFYqpIFTcFGrzi0GwgnoZvgcME= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XNG/e6uO; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XNG/e6uO" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-490cf322ed0so21321035e9.1 for ; Thu, 06 Aug 2026 11:00:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786039251; x=1786644051; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=RRbzzkyTb3jdfnCCyeAUeJJsqm0ppzhdGbvkGq0K/Zs=; b=XNG/e6uO/Es6cJOT/3YjkVedJsPT3nnFnN9KzD/uEtAOlLpFFRwngawhuXLwwAMjHo t1bGWqoDouYZLiZ9CZB5bCUERKqpXdiKec3mdRxt7lyeaGFJw/tXt2L3W1fYOP72J/ei s7uVawnnkG9JHelGWqHzruR2qVq+G19wbrEmMRj+SPHvqmkxmkGN8DetPgrDBmOIrZB+ a3dG7zLf2WvkDT6M1nl0AyyIYCV/C8yo3EqRpmB68YJrWbMRa28fz7Wk4SnavNDtwoi9 sZ+IDWzORRMAd6Yv+WKn4KAy1CLiXK4IS4pqEvzvYBQMaoK5XgS1jATUfzOzmhXdhe4G eBtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786039251; x=1786644051; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=RRbzzkyTb3jdfnCCyeAUeJJsqm0ppzhdGbvkGq0K/Zs=; b=kC8LennJ5gj0HJHDB+SPDB5FbOGzIRkwi0Pe0zroIEqSnDPc27Vyxucc63eHcIq2FL PIhQq+f1uiZcxsWBtdWkfD4t4aK3EJXWT4RAaSzIkRIHwNxKn7rluQWxg7heFCIX+GUM YA+VMgxUVMcXZqW7SBfiR5JRbLhe+6fPaK/eyq4BWafMXuvTA8HFuuMHA+rq0ksXpWM3 jt4F1PiOiJzRZuDFAfvUbf2reCUtNgZR40IlPirxJmSmgEcXfDBUYvlw+XTazPhKbR9F 8RBjR3mvA6aeo/XQQrnuibfyMJV1LhEXF1KmQpR27c7QH/JBd1KqYgVlpTV4VMKRaSTm cQVw== X-Forwarded-Encrypted: i=1; AHgh+RrRNPX3zwlBoy/4vur3EostuOZ4krGgYq4ZTmJVkCHxZkJLPZyZaEy3iK+2fUTF9aMrzaH+kH8uwSoYBM4=@vger.kernel.org X-Gm-Message-State: AOJu0Yy1NV8TU2uHCymXI430NKzszK9pzsg8PxYYWeUA+VfGzM+E5Byf ofvP1lBEg8oqZ9DfBxTjnHPbHMtWW3S/I/db6s7kyppnLFZC9fdeCYYn X-Gm-Gg: AR+sD10KY/zD243m5AQoNfDNlsxhFuNzt0VZ8rSJgTS3EB2xLCBGMOhavxfvUgnsw1C FcganBC5fhh7DBh5PKnniApEXJ5naZnBBG7I1zzJHbftqEkGouBiz4E7QfKILV31PvkqUs5Cc0C 4nTTlLvg1FPJ5Z1cPd1S5lyeNzY3fjTUjVPWHnVg3Mnx5KqrLtzzFwF2ROlIVn8U7K6lfBHiq8B HT4TnYoCsQD3F07M29opJAypqm1oCmDiLOLiy8e70vHARNT5E4+HeWiIb7UP03vHWnbS2HmmtHS B/Fm1rH20ArYlzmi+7VSk1W32R67rvovEuN0dKX6Z9iAy3KHfNQ7eBCR55vIT3blvYANU4JhZ/n +Y55Xy5ymhpNKZzsRiP3zZcNhqDrwKfdmHHKmr/180l6FUpx2EDLQWA5x0LroyTibgfgAV00b6O N+++voS6nnBboHTWttrzxBQczsYSCD8AT+BXuFSR8MD2ocr6seKARQYV3ZjSKBlRYUe/6Atx1GJ acfPt59ycBnlzp35n+VYkUc67/KpBZvGdouCcmlBiXMqjx8vcKcqgUChmaWI9SFyskwaMxKd/pJ wjcxlNoBNFoTqxcn9gQ7l1SLtixM4GF6y2bkfb7qb+tM0Zs01gsNOybWvijikLqcLiwgCgMq X-Received: by 2002:a05:600c:3422:b0:496:c18c:f9a1 with SMTP id 5b1f17b1804b1-4994e7cb6abmr177384855e9.14.1786039251156; Thu, 06 Aug 2026 11:00:51 -0700 (PDT) Received: from MBP-von-Karl (dynamic-2a02-3100-adf9-2301-8c14-6be6-a9e6-a2d4.310.pool.telefonica.de. [2a02:3100:adf9:2301:8c14:6be6:a9e6:a2d4]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-499541b86f5sm78547805e9.0.2026.08.06.11.00.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Aug 2026 11:00:50 -0700 (PDT) Date: Thu, 6 Aug 2026 20:00:49 +0200 From: Karl Mehltretter To: Wei-Lin Chang Cc: Marc Zyngier , Oliver Upton , Fuad Tabba , Joey Gouly , Steffen Eiden , Suzuki K Poulose , Zenghui Yu , Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org, stable@vger.kernel.org, grayhat@foxmail.com Subject: Re: [PATCH v2] KVM: arm64: nv: Keep the shadow S2 MMUs at fixed addresses Message-ID: References: <20260806062352.93489-1-kmehltretter@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Aug 06, 2026 at 03:49:35PM +0100, Wei-Lin Chang wrote: > > I felt the commit message needs to be tightened a bit, so I restructured > it slightly and removed some information I found unneeded. Here is my > attempt, feel free to use it if you find it better or further improve it: Hi Wei-Lin, Thanks for the review! This is clearer, I'll tighten the commit message. > > > + /* Allocate the fixed-size pointer table once per VM. */ > > This comment seems a bit redundant. > Agreed, I will drop it. > > - for (int i = kvm->arch.nested_mmus_size; !ret && i < num_mmus; i++) > > - ret = init_nested_s2_mmu(kvm, &kvm->arch.nested_mmus[i]); > > + write_lock(&kvm->mmu_lock); > > Opportunity to use guard() or scoped_guard() here. > Good point. I seem to forget about guard. I will use it and send v3. Thanks, Karl