From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CE0C03093DB for ; Thu, 6 Aug 2026 18:39:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786041587; cv=none; b=KA8We1jUI1Oi8xDqIcjFfjaUfzZVBa9iWss3IJdxY+xg06qDduBulLIdT6Q7qdzH0NQQAHMaHXPGbMvd7xFA8MdWbSPE/H/kdrVhseE/SpnrtpBBTqTbW6GPHUEpTKMtWLeoBIMPqgK2go7hdBf7YDgEvXIXAcgi4z0qyc5UcYY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786041587; c=relaxed/simple; bh=NV+IA53dz9VkHcKJtbdngrpQGXRELNM+2tXFLrXNSLw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=VJ7PiayF73uei4Penq+slSlUUX3tnHgQ2ilqcYb/vlrv68ZH0Gbhxs8uEqhHa1A8zWbQ9MQkY5AKV9oov4cUO+pchD1vL0Gc28aDbjA/lidxRwZC3096c1AJgIfA8zwxx+PoNfunjaIRWDG9EYW/EM3yFfrcErv7lRyVbpdPCZ0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gu/ZNCnw; arc=none smtp.client-ip=209.85.216.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gu/ZNCnw" Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-382ef647e20so2778577a91.1 for ; Thu, 06 Aug 2026 11:39:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786041585; x=1786646385; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=p+7d30qMdbhTyDmqMFX+O8IHOCgpcLlN0txxCdEaKHI=; b=gu/ZNCnwMY0RwVy2TX2eeTkA+CTJ5L/7Mzw3s++mL71Dm3IBu//M6bTE7vy8bPwlUa 7mOwfR0R+WtbOCP2LSgpryv13nHlUVZjBzI2XiPNwN9C96K7F1QnKGNc8QwD4mr0kPrD wEDr0jZQk3m2UO1KKKDznIlWef9PVo0dnkT7ObzGG8q/dg0wDFK9buDkPwRd3j5+0JBx 6NrgIuCRpZbUmyuUI6PTeIIUkMMutJw28MItExDdLHbaILuLOFMElALMfNlOrU+gGnlx lggGKAL54Dqz8OFu75c/pBak5eOCm6IwYeP/GNnAF6DeWF38mbLRkCIVd4l4mPjKchtu mJxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786041585; x=1786646385; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=p+7d30qMdbhTyDmqMFX+O8IHOCgpcLlN0txxCdEaKHI=; b=TF1kMs6dVk0FeImrh9VICoH1Sg6dWmE7JhMRv+h3WfqL7gvEU8CtvD8Nw+KTlQDu9T BmSRxJSJO55VdkmtrzAzqgYb/DSXM9THHpOwXGEB64ryfJybt/dhdJIWbdwZA0CA2UVN UpxYwwe/7tIW8vn+sIToFcgN7GDs5g91w8ahl7KP6kOxpRwWjxbwAHor43nhYFOhViNX IHMV6XCTz9ubqCddor6HaK0AiNG1yWTbZeWf4v8hJ3QaOZonrbTYQqWRk0VPtLC2cbEX SAoQlB54zg00L/brrXEY6maFhPgxYWoqVC0WheWgxyYhxqir5sIzY6xTShSUE1Z7USKG suJQ== X-Forwarded-Encrypted: i=1; AHgh+RrPNE14hxW9wnzQFdh4V03oc+c0nXSkQPxr/K4F62vRFZF5VVeecRqat+O3yjvVNLHRZB3qTSZISk3TVw8=@vger.kernel.org X-Gm-Message-State: AOJu0YxO1kroAVLXi0ijKC5VLOguMxRJcft/vXuNJpPLhXtz0UpTrOMs aRkhIFu6k4kWNo6PIXAWsaQlkLl3lQYTlTJ9rKXFB9fQl04CTA+W72dW X-Gm-Gg: AR+sD107ZO8bJAis1SDFaGkeg1YcDRa7pmCTunDqyuzNJdSW4AkD6NtcK7LtxlmHXRW Rz3Qjqyjt5get0esx2RNSXCYkWkNTbw6Q7bt9hsL5lVB6N/22g3rBS7DuWI2fZLKY52/whGoR42 2DwqymwIZhLYplfoc0BmCqxAc/FchaSdodNR2fS/O2BE3nrw04ONe+1/SRV+9Ngqjk1TmArlr5z YpVo0PziiAuYN3skNfzKDvez5tynL+wdhgNkXNZpWvHzDHLQwGHx+jgzY0gype7ONEtqvYm/LJC 6q1IBiepFLeZrD8v+4qw41HNHdQCryQvWJ3qib5fLnJAxSmF+2NkNylmGSfmj7yMPPcZ7DD+UyP qmCOEAQeDEzSKgBNHl4pxaZOZL6HLHdlIEsT8Fps8uyj/7qnYQXAptvkO2jwYnbIDGIpOKfyCWa DP6EXNcYx9W+UFeVm+DlTuPPnpph57j78gaYZqOGrp5n7dtFRviuAw0nhKRgofiPUCnFg6GF72H NFODoqrary8QvLbrvJIO86/RI1nwQ== X-Received: by 2002:a17:90b:5484:b0:37f:c69d:ce69 with SMTP id 98e67ed59e1d1-3903c581f08mr17425221a91.10.1786041585118; Thu, 06 Aug 2026 11:39:45 -0700 (PDT) Received: from google.com ([2a00:79e0:2ebe:8:b209:871b:9f7e:a5e4]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-141009ab943sm503689c88.7.2026.08.06.11.39.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Aug 2026 11:39:44 -0700 (PDT) Date: Thu, 6 Aug 2026 11:39:41 -0700 From: Dmitry Torokhov To: linux-input@vger.kernel.org Cc: Andrew Duggan , linux-kernel@vger.kernel.org Subject: Re: [PATCH] Input: synaptics-rmi4 - fix GPF in suspend and resume when unbound Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Aug 05, 2026 at 10:44:23PM -0700, Dmitry Torokhov wrote: > Transport drivers (such as rmi_i2c and rmi_spi) invoke > rmi_driver_suspend() and rmi_driver_resume() on their child rmi_dev > device during system power management events. However, transport drivers > are fully registered and operational even if the physical RMI driver > failed to bind or probe the rmi_dev device. > > When rmi_driver_suspend() or rmi_driver_resume() is called on an unbound > rmi_dev, dev_get_drvdata() returns NULL. Calling rmi_disable_irq() or > rmi_enable_irq() without driver data attached causes a NULL pointer > dereference and General Protection Fault when attempting to lock > data->enabled_mutex. > > Fix this by checking if driver data is attached to rmi_dev in > rmi_driver_suspend() and rmi_driver_resume(), exiting early if > no driver data is present. Note that better fix would be to have RMI driver implement PM methods (suspend, resume) but that requires more careful planning, especially around RMI-HID. Thanks. -- Dmitry