From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f172.google.com (mail-qk1-f172.google.com [209.85.222.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D358635202E for ; Thu, 6 Aug 2026 19:52:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786045935; cv=none; b=C/eZxPCNte4mg8PGotBiVR5Fw5+0CjFgc28fos7VfqMNF+pfh39UW1WwAgceJTWGaWIIPSQgbNp+9r0vmIcBJtLImNSHmf5ORtAUoumlSh0JHEkqueBLv85WPM4PR3VsW3bM8ANxzYOCU/EUw9bSgnKT/HLpy/FV7IRT+h72cX8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786045935; c=relaxed/simple; bh=IpMscn/8w/97nB3HoVYNokih0gy9XCLfRj7GJELncJM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=LNPV1ITy6phZzb2amjkkzl4FUtVLNR2y+MZ9914dpwwiadHKTotxB2Lwa18O3uMROHv8u8nF3iCLFFuS2hrCOAMCfTodgTaT/yP2O2I0oofQTNk6pfOGOjxLyh9jhgz8S1F6M5Mi+NtOerr4W6y/yNzaszThLQ/mhuARE5Yyzhw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cmpxchg.org; spf=pass smtp.mailfrom=cmpxchg.org; dkim=pass (2048-bit key) header.d=cmpxchg.org header.i=@cmpxchg.org header.b=P3nP9jsd; arc=none smtp.client-ip=209.85.222.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cmpxchg.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cmpxchg.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cmpxchg.org header.i=@cmpxchg.org header.b="P3nP9jsd" Received: by mail-qk1-f172.google.com with SMTP id af79cd13be357-92ea24a2dbfso205181285a.0 for ; Thu, 06 Aug 2026 12:52:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg.org; s=google; t=1786045928; x=1786650728; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=8WUS5fNfGQjbWAXdAqP1J4eQkadhTyRU3K4yvUsCnhM=; b=P3nP9jsdOHSGpxcsp5EE0XNshFe634dowcedSdIlh2Y+x3XegbKZDHl+XYNPtY1xTW e8/GHhyfn51JvIhUcgxw0b7alOnY92nQGHr8AKdHrNFxtvcjHt0NgwgcZBwqcyw6uDYm JjCP0Annu6WwW//EWPBqYdI3obRorAh9OPDkw1JlcqDerbpF649dimc2pMHCv2dFTXSj VcDVYQKXPeBeT3WQCQQSSBrIbpDXczXX/XAJrT8MNaZQgeZhnZomtMWwyD2bOJUSUl5C ndVEUkUr/gqT2hmiwHCmJ21gki0WgfMUFD+jKQcBWt1ja5eSEk92LeuNw4gJBhAy9u3u fbbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786045928; x=1786650728; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=8WUS5fNfGQjbWAXdAqP1J4eQkadhTyRU3K4yvUsCnhM=; b=UdNCgHRjkqpaasEKZHLgJJYwhcJYxwUIYDL6+JPAC3C4r4kYIGJcwZAR0vg3X7s1UQ hqEAfRz3mP7C3aFFbmI8ZJHtU/nebxHxwDg9BI9nFwLlQKbuQR8L2msL7H2HYsgpJZ6A vlww982JmnSedAbUtJ7YHqJvEpCFfxtovAahIQBvfGpTV+s4ose+TTionQVYgAtSZnur erccyuvQDWTW1BZdnm+SdmLjqubc6XtRkLwS56s0Ufyd9JTywv+5F3dh2Wr/8I1WPLHi pFZmGtPAuDrEteC6/XKv3LRtoQ0rb1WlMKL3p7knM6U9b7se+WbbzdGiCzJG8PPolD5z JkKg== X-Forwarded-Encrypted: i=1; AHgh+Rrk1fTrHQRzpY246QdsO/QeU50EFtFY6LgS+7ME/4GLprQocgjj4ie7sP5SpMr0qlV/QqCYSpsl6wm80ng=@vger.kernel.org X-Gm-Message-State: AOJu0Yyd5kNUwvMCbqBh2BpSCh/yflqRBknCaXyvJMsR2Ioc/mtisM6c QWpUiP7L67wVROsiEOWwK8AL0Vc2gWKXHGHty1S8/jZmgihW5gppE/luQXjXfxNnsOw= X-Gm-Gg: AR+sD11gM3kJybv+IuoK+x+t419W3UrBAwDnD14n7yuvExAGtkFUP9qBMj9MOO1e9cl xTKRDEtmxB8XqvNjfQkNAQ4dOb/GIwYvTrv4YoZJjgTBqf7AVSvpcb1IzW3xdDDZ0ABoYixg4/x Ugvu06aKqWbep7l5i3nrsbV+MyCaDZlEl7z1q965wJnYHpWPWRvnRZ+pILDi0aV/ANv0qsxyj31 BC+VgmvU67/Z0Eh/I5mHZembpm1Ft2m92xjmqwG0Oq0qfvsJVDU46VkMNd1KPHVi8bXGiNbMMBi allX6q1afUJZT0Ub1vS0s4uOXGCtUSo9EMR0hBzfs0okktQWud5hpv4nNq6BRfMbnNFoJplsjha bBJPdVOe6mARoLPt8pt1S6vPxFbREXtXEuOixpoeWZfwyTOoB6AxMdoewVvypsvHIn/dzEna6Bx C23GQiJ2XbAjBCNHlgQl0pStXykn/GkzR0ejOKUuQ2Ljuux7rc0M8jIF6bAztHT/FWAIvJVR4= X-Received: by 2002:a05:620a:198d:b0:92e:6b16:6a0a with SMTP id af79cd13be357-936491fe653mr1593017085a.40.1786045927815; Thu, 06 Aug 2026 12:52:07 -0700 (PDT) Received: from localhost ([2603:7001:f100:500:365a:60ff:fe62:ff29]) by smtp.gmail.com with ESMTPSA id af79cd13be357-9364a59552esm489438885a.42.2026.08.06.12.52.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Aug 2026 12:52:07 -0700 (PDT) Date: Thu, 6 Aug 2026 15:52:03 -0400 From: Johannes Weiner To: Ye Liu Cc: Andrew Morton , Vlastimil Babka , Ye Liu , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Zi Yan , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/show_mem: fix format string inconsistencies and type mismatches Message-ID: References: <20260805021556.1908807-1-ye.liu@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260805021556.1908807-1-ye.liu@linux.dev> On Wed, Aug 05, 2026 at 10:15:55AM +0800, Ye Liu wrote: > From: Ye Liu > > Fix five format string issues in show_free_areas() and __show_mem(): > > 1-2. reserved_highatomic and free_highatomic: %luKB -> %lukB > The uppercase "KB" is inconsistent with all other fields in the > same output block and with /proc/meminfo convention. > > 3. local_pcp: %ukB -> %lukB with explicit (unsigned long) cast > per_cpu_pages.count is int, so K(count) yields int. Using %u > was a signed/unsigned mismatch. Cast to unsigned long and use > %lu for consistency with all other K() usages in the file. > > 4. total pagecache pages: %ld -> %lu > global_node_page_state() returns unsigned long. Using %ld is a > signedness mismatch caught by gcc -Wformat-signedness. > > 5. hwpoisoned pages: %lu -> %ld > atomic_long_read() returns long (signed). Using %lu is a > signedness mismatch caught by gcc -Wformat-signedness. > > Verified with: make KCFLAGS="-Wformat -Wformat-signedness" mm/show_mem.o > > Signed-off-by: Ye Liu Acked-by: Johannes Weiner