From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f177.google.com (mail-oi1-f177.google.com [209.85.167.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 797764B049E for ; Thu, 6 Aug 2026 23:56:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786060598; cv=none; b=i9YO74MlJvEUl3LMDW5qNTyEL07CRfSATHSGf0CelC/QvSaVQUoUXVLiZP8aVIym7jpjpJSeMdRIhjE87aX7avQmSJpmPO7AEL24INVeWLneC5Xaae48F/zLhOApxpYXd7OdhAHOs5qqjt5AU3WJf/270kAakVA5SUjslDHnPls= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786060598; c=relaxed/simple; bh=96ZEA2a1Vw4qdFxsCMi3RI6flKGOp0r+XLJ+/uHU8aY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=nAhHgm8BFUFRSaQrt+UKuo12OK7DwVeAcCz5wQ+lI6MnrLejrq1ccVsybVEzQXaToX7j7PZtBEyJmDDGbAR5FULFiXqoR1TjAUdYS4R35Q18zOUEes9HgipoqetGumKk84csbXFnlI8mJ2zpigsQJZWfK76nDXSkjFlvs+e34mA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=minyard.net; spf=pass smtp.mailfrom=minyard.net; dkim=pass (2048-bit key) header.d=minyard.net header.i=@minyard.net header.b=hx37udJE; arc=none smtp.client-ip=209.85.167.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=minyard.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=minyard.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=minyard.net header.i=@minyard.net header.b="hx37udJE" Received: by mail-oi1-f177.google.com with SMTP id 5614622812f47-4a483a552efso1189628b6e.1 for ; Thu, 06 Aug 2026 16:56:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=minyard.net; s=google; t=1786060595; x=1786665395; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:reply-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to:content-type; bh=RHOkcY/1NIOPwc2bnnSox6ibeK1wTlgC8lyah5T7TRg=; b=hx37udJEoWH77isqVQYnf5N4gGAqagryCxadI9b2Gt1SmCa64FH6L1M+d7Hc+E5Kgk y19l6IX4kvjEXC78hXc7ECjKRwYZK0gVjM/0xIHNkW68TVjHyY6q6H+gKT3cECFNiNz1 QvuJKXYs35rv6oF7+SjhXghfSZZg8VdHHw/47O9PjVtzVCPxU6a16LtjN6V54ZuVglJr AkhXj3FL6SPRBQDSTfRlXlxV9BEjqRCVAqULZp7qFj84HEA05pVMlRnJFFQ5aLNv3ZD4 xcE8hlfU2jwCR7GghJHX6BZPEF/kGVV2ZK95Eg3V4YEwpAjdGeyi1f7/fB28yfY9woFn vhBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786060595; x=1786665395; h=in-reply-to:content-disposition:content-type:mime-version :references:reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=RHOkcY/1NIOPwc2bnnSox6ibeK1wTlgC8lyah5T7TRg=; b=QBbcuncoHQpZs/Y4EPisJg5NugsPofPagCcsoU2mWCp7ACzmLNkHmO9avtvAsbPKMm RvSMBuP4KRKldqfxjib2Nqt4PnxpvcmSp138ki6kQcNx5/BBBgCr+t+oe3lG5bacggFO EKJ7L64GVr+2NoKKHglB1GRiqpxs7h2Q5We2WqjE3sGdzetMtZNWOiqO/1mBf5jK0g5u bT7PmKBrhmR3kJLHiRJu4nCyxrBzKNhVd8jorScKCU6Fb/yhJr4XuZ/cQQJ1a3rLInZB AkgwStZavpXW24QU8H0L5frHwdrWGA6ETU7H7nVg1KfRkvYDlrCiq7gbQQJYnezCJOcx avZA== X-Forwarded-Encrypted: i=1; AHgh+Rr6BwBRIlF5xWD3SPVmz4LROy1wYPKYk6AMWv8xB9US6lTFEiPDEqExpYr+RB9XFvUcVWnC55zsU47uoFQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yxm7v4iuisgkfdD+ZfL15jlH1KNkXc14xkv/ylya9RF9M8802g2 5DgX41i161g8c07u51pIzFgu+QVu2HvpjrqEyT6QKlyY16IoWJOlNBwbe9RHQZ24sgw= X-Gm-Gg: AR+sD10hAjY1xGB/UevTFsfZ1oXnVMU5kcyU51E3EzwasnQ0WYpCMu1cQESSrrtRgZN IDXsPQgr+SWaWuKCbwD5HgqJGcS0w27U80J2mI7rg/weLTTORoq/pHEKAzNCYrgrY0A8Lig7Ktx h3hQyf7ZPTHn4QmC8bxcViFY8SCNIE6q22rUd9RBG7v8poO+7oV8Fi7aidL3O0+5g+z9VjdSOtC wC/v4Zjk0Q6r6XWf8633N0PDvSNMaS4G7bxY7c7Lyue/xR07bvlSHHklbbG0i1eOx1tdA9hRMup d3NrT/8gj/YCusqTklz4Aoqk5L9YzcKBmXUGmwQ+l/X/J8Cvod8M03FFyauIQw35D8/FeLOfqE0 8iXldg7QiWugLMfeJofxnO1kkgFV5pNCqy8G1bM4XRs/E3p7pGRpJi86QZqYsfB+gGbBRE/c6dv qQ3aSRh0jF6X2hMCvuOtuTC6txgDfdgtV0FH1hqrbdpoFLktFVCUNhaWFPvINChZu6bkXchahQQ P+5KB7ervtiW9Gl00wr7lv98s5Ynrc9Jkq2aBC1b0x3Oy1/rNbPqx7PDjB6PbQjHdpXMziEmJz3 8NmK7kAZ1Q== X-Received: by 2002:a05:6808:1926:b0:4a4:856a:c622 with SMTP id 5614622812f47-4afadefa676mr9601908b6e.20.1786060595301; Thu, 06 Aug 2026 16:56:35 -0700 (PDT) Received: from mail.minyard.net ([2001:470:b8f6:1b:f431:c4b8:c018:caf2]) by smtp.gmail.com with ESMTPSA id 5614622812f47-4afae706f3asm5825495b6e.10.2026.08.06.16.56.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Aug 2026 16:56:33 -0700 (PDT) Date: Thu, 6 Aug 2026 18:56:28 -0500 From: Corey Minyard To: Michail Tatas Cc: openipmi-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ipmi: Fix leak in __ipmi_bmc_register Message-ID: Reply-To: corey@minyard.net References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Aug 07, 2026 at 01:30:20AM +0300, Michail Tatas wrote: > In case that ida_alloc(&ipmi_bmc_ida,...) succeeds and then > platform_device_register() fails, ipmi_bmc_ida is leaked. > Fix by freeing the error path You are correct, added to my next tree. Thank you. -corey > > Signed-off-by: Michail Tatas > --- > drivers/char/ipmi/ipmi_msghandler.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/char/ipmi/ipmi_msghandler.c b/drivers/char/ipmi/ipmi_msghandler.c > index 6ff9a15cced8..7634dff99f41 100644 > --- a/drivers/char/ipmi/ipmi_msghandler.c > +++ b/drivers/char/ipmi/ipmi_msghandler.c > @@ -3301,6 +3301,7 @@ static int __ipmi_bmc_register(struct ipmi_smi *intf, > list_del(&intf->bmc_link); > mutex_unlock(&bmc->dyn_mutex); > intf->bmc = &intf->tmp_bmc; > + ida_free(&ipmi_bmc_ida, bmc->pdev.id); > put_device(&bmc->pdev.dev); > goto out; > } > -- > 2.43.0 >