From: Dan Carpenter <error27@gmail.com>
To: Nikolay Kulikov <nikolayof23@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: remove static HalDetectPwrDownMode() function
Date: Fri, 7 Aug 2026 10:53:17 +0300 [thread overview]
Message-ID: <anWO7VdAafRvku1S@stanley.mountain> (raw)
In-Reply-To: <20260806-rtl8723bs_efuse-v1-1-fedb8b91f346@gmail.com>
On Thu, Aug 06, 2026 at 10:34:48PM +0300, Nikolay Kulikov wrote:
> The return value of this function is ignored at the call site, and since
> the function has no side effects (except for the assignment to
> pHalData->pwrdown, which is not used anywhere else), it can be removed.
>
The patch needs to get rid of pwrdown from include/hal_data.h. There
are two reasons for this.
1) For correctness and cleanliness.
2) It makes the patch easier to review because as the patch is written
now we need to check the kernel source to see if what you're saying
is true. But if we delete it and it is actually used somewhere then
we can rely on the kbuild-bot to find the mistake.
regards,
dan carpenter
next prev parent reply other threads:[~2026-08-07 7:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-06 19:34 [PATCH] staging: rtl8723bs: remove static HalDetectPwrDownMode() function Nikolay Kulikov
2026-08-07 7:03 ` Greg Kroah-Hartman
2026-08-07 16:39 ` Nikolay Kulikov
2026-08-07 7:53 ` Dan Carpenter [this message]
2026-08-07 16:41 ` Nikolay Kulikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=anWO7VdAafRvku1S@stanley.mountain \
--to=error27@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=nikolayof23@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox