From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C4622229B38 for ; Fri, 7 Aug 2026 08:14:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786090486; cv=none; b=M0ALYtN08VE6ICRERXX08YtKEnW/bwEb+NqSFfF9/g3mUR95XKFUlxqfRCrJQHWkxGKsjgh758vGy1xLvzHAydOzvpAYMnvjqHcAGtkcHmo9R/AwYS+v0pYeTrDMA6VQOvLfaWysfEjH+EzvdaYvEqDbcgZ3fMn0UrirQ1DmIz0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786090486; c=relaxed/simple; bh=mFfy2EqUma9Eh4SsYEj1tqEQQsUWbdUUzTbx4+5m0ag=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Ns2w1Y0Bsb6M59/6BzClQpNP8tv4rtxLz73iLBp3PwDsjvWkNMe7nxvRFKEI1dOFCvqdOtnAQthBhdOb3rAiY5MTG9uF21au+mttM0WAZkFQOv3iRn26doFMB4okVZT/NjSqIk7kDjtg7pXXR2orZF4zLN5tvfwS8tP0RinsE4U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=RPtq5L2E; arc=none smtp.client-ip=209.85.221.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="RPtq5L2E" Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-47f703a9d05so1990263f8f.0 for ; Fri, 07 Aug 2026 01:14:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1786090471; x=1786695271; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=gp9hFyIf2ru25qKqyVvBftXQtYl0Dn+ub+8H391zBlQ=; b=RPtq5L2ETRBOdnCj6s9+5rCU9N+MLmrDoeVIsmF5wT3xOoMwlPlkPKVFrV0RjujA4V RLpSqRMOvE+5Bz+LxeI+eNUD5lGfd77/CK39qF++yvqFKosNm5x4+CvKvhOD/tHaZpa7 Ef/0GOKlfEfbc9tro7q+L2Q9ezOlAJ5oXK6FbQuc+aBDcP4b/KJ21NMcPcDD3dHZV3zS w5GIyTseZ6cc6A00M6Fd0Y0N/INO+xpIy4IV3exWlxrkvF1g3r3e0Vw2E1wnBnq6c7hP nLLSdcqqNJZsuqdzzmuwJ/+1UqRF3qLh5Ga0iiRxPZrhXrInO26GD/GKl9q9i0glp+Eq HqfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786090471; x=1786695271; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=gp9hFyIf2ru25qKqyVvBftXQtYl0Dn+ub+8H391zBlQ=; b=FfUjJ7/X4VOPpiCpTKRPVPSPlU4njHq2K/8s67/bFXoXpGZmnbqV8bPtCWO0G91KZU dFUzhWcN7qO6GLFnL8i2w9F/yCmAevETw/wcG1dXebQ/bC0+LDWD1Q9bAFpQcDo7kBmz S+5g0wjCeZeVEb1R0Kd9APcyrOSerGnvUfAl8ghy0DQgYPS2vAoOoFJIaX9VH/kLr7v/ YC5VAunAuief+GSgpAO7aH04UZdjfwoiI88X8ehbN7ptWWNvTrM8P1CjbKvr0pghWhoM KG9oCaln8y6Sio2TTqU73+RRrmDEenDOguQBZ5+0V9n3YkLihUKpuvvC2qSZnCbmjHu8 DjeA== X-Forwarded-Encrypted: i=1; AHgh+Ro2bOC+sC7z4ftTBML9kl0bQLfyEsJzHgoGGP84tswy0jDa3zhle86/AmpBvJarXg+CDwoPUfwtj1UX/j8=@vger.kernel.org X-Gm-Message-State: AOJu0YwGNlZOjHDUEsjKr7SoBRGRkQuXIRo2W+uRIAYUDK5xSFpdt4nF b04+bqnFTT9HBBHm84Gdr1cg7/NnKhHReLxcZHwoNSQE6AyuDQvEZMneK0d6Twy5Wg== X-Gm-Gg: AR+sD13CbrqzhJFQwKkUBkvfWJVlsVqhEg56ig2vpG8q9SfylrqlJvPY/xiuqdZzZzw btB3RbIm8suPCINJb2xmS/s2R9rjPrV/ICL7uzdaEMf9oguJKe2E3HMaAffdHM1k5cvK4IlD44/ 6TjtaV+H8lpXIj3E08iJBk32oRnJtRunUHYvIoe2paiB2fi3Hynbc0P7GJSAs8ET+qcWpaNa3WR FPF+IfT6Rn/V9EsKa+By3svHNC42F6BlywijnLST/E05VJzD0lm3/CRdvZTw5+LkgJa3W1MMmNK eV9Dlrtuz8dnQZmdNT4ihyYkqVl2/XZjBfcKVHXVAz9l8GkKJqb6q1ylFg+koRtd69zTOvcAEB8 zHGl5KCmuirGZVKAZJnyQy5+oMLvAOkjLZFamQJ2/vGGsOmhE1BuAZTj3DPDMjyEDxjM3jrlGFH 6Syr6mJBg+erUgROFedeEhyjrVGBoOHN7enKYtJj+Vxv4X4qasOt+RA+3QZ9b1Nux1MS5ECQH6A kcxff93Qv7VG0Og5Kr6ViFC+1kJ9gbe X-Received: by 2002:a05:6000:4813:b0:45e:73eb:5119 with SMTP id ffacd0b85a97d-480026d7fa6mr2900147f8f.22.1786090470439; Fri, 07 Aug 2026 01:14:30 -0700 (PDT) Received: from google.com (135.91.155.104.bc.googleusercontent.com. [104.155.91.135]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-480021f93acsm3773511f8f.29.2026.08.07.01.14.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Aug 2026 01:14:29 -0700 (PDT) Date: Fri, 7 Aug 2026 09:14:26 +0100 From: Vincent Donnefort To: Masami Hiramatsu Cc: rostedt@goodmis.org, linux-trace-kernel@vger.kernel.org, mathieu.desnoyers@efficios.com, kernel-team@android.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/6] ring-buffer: Prevent resizing of persistent ring buffer Message-ID: References: <20260806211306.3704194-1-vdonnefort@google.com> <20260806211306.3704194-2-vdonnefort@google.com> <20260807111808.d5dc1a48b080d241100f4a57@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260807111808.d5dc1a48b080d241100f4a57@kernel.org> On Fri, Aug 07, 2026 at 11:18:08AM +0900, Masami Hiramatsu wrote: > On Thu, 6 Aug 2026 22:13:01 +0100 > Vincent Donnefort wrote: > > > Dynamically resizing a persistent ring buffer is not possible. Disable > > the feature. > > Is it true? Of course there is meaningless to resize the persistent > ring buffer (because it makes the buffer none-persistent), we are currently > allows user to resize it (like for resizing unused persistent ring buffer) __rb_allocate_pages() in ring_buffer_resize() would call for a persistent buffer rb_range_buffer(), which IIUC, is just reusing the same ring buffer pages as the one already in the persistent buffer. So, reducing the size would surely work, however increasing it, would most likely mean having buffer_page pointing to the same buffer_data_page? Also, the comment /* * Range mapped buffers have the same restrictions as memory * mapped ones do. */ Made me think that resize_disabled was omitted. > > Thank you, > > > > > Fixes: be68d63a139b ("ring-buffer: Add ring_buffer_alloc_range()") > > Signed-off-by: Vincent Donnefort > > > > diff --git a/kernel/trace/ring_buffer.c b/kernel/trace/ring_buffer.c > > index 8e2485bb3aa8..afe75ad2bbf2 100644 > > --- a/kernel/trace/ring_buffer.c > > +++ b/kernel/trace/ring_buffer.c > > @@ -2528,6 +2528,8 @@ rb_allocate_cpu_buffer(struct trace_buffer *buffer, long nr_pages, int cpu) > > if (cpu_buffer->ring_meta->head_buffer) > > rb_meta_buffer_update(cpu_buffer, bpage); > > bpage->range = 1; > > + > > + atomic_inc(&cpu_buffer->resize_disabled); > > } else if (buffer->remote) { > > struct ring_buffer_desc *desc = ring_buffer_desc(buffer->remote->desc, cpu); > > > > -- > > 2.55.0.654.g21b8a5bc05-goog > > > > > -- > Masami Hiramatsu (Google) -- Vincent