From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sonata.ens-lyon.org (sonata.ens-lyon.org [140.77.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AAD1047127E for ; Fri, 7 Aug 2026 12:00:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=140.77.166.138 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786104041; cv=none; b=IJrsugcRyRl9A2ttcfu/azKnrq2PqQVAvPaOK2ZgqvveB3f+zO0vTYvA1HFxfY4wZ5Xj/FNy1hu+rTSBvATC+J6G5q9ZcodHN0xCAy4FIPtcsgTAiXqzMNa6e83jaofjK1jiWEwaFWcr/emTdKtt4tkpkukWjvUMZiVl63jfwy8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786104041; c=relaxed/simple; bh=ft/GlJSuOkInGIakH+d85L48HWpxETel4vAeXSAwrRE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=aigsfWRPGoyvBy9k+dbMY58etc3Mj/wK2ckbRahVr2Rk/HU1pYSTjCQ3p74opFA89HHeS1iuOia7UkSGhGoc4dRe1nPSRd1hv1zLOtHIEB4szCUb+Y1V8hX7hjHdt9NZpbsId9wvj58VTBbMHDZJ2WvGuhBDJnGDSKtyRdSAR2g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ens-lyon.org; spf=pass smtp.mailfrom=bounce.ens-lyon.org; dkim=pass (2048-bit key) header.d=ens-lyon.org header.i=@ens-lyon.org header.b=C1u3Bjc+; dkim=pass (2048-bit key) header.d=ens-lyon.org header.i=@ens-lyon.org header.b=C1u3Bjc+; arc=none smtp.client-ip=140.77.166.138 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ens-lyon.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bounce.ens-lyon.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ens-lyon.org header.i=@ens-lyon.org header.b="C1u3Bjc+"; dkim=pass (2048-bit key) header.d=ens-lyon.org header.i=@ens-lyon.org header.b="C1u3Bjc+" Received: from localhost (localhost [127.0.0.1]) by sonata.ens-lyon.org (Postfix) with ESMTP id E11EAA040C; Fri, 7 Aug 2026 13:52:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ens-lyon.org; s=dkim; t=1786103562; bh=ft/GlJSuOkInGIakH+d85L48HWpxETel4vAeXSAwrRE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=C1u3Bjc+yHWWbZy+B1vMkMYpr9bh2Q1KECmJJYuzzgjK4sAJgYtUevqcNeVVk5Fl5 psD9OtTd6y8BqbPyMPhvFKDoykAcGNKWiHhBJniLVn4OMKDJ5P7tfaAsabXaPQYdvv 8VfD4YU8+vFnMuC7uFGpynsYoZRV+aWX/wptBd1V72/iRssM7WnRR+/CWS/YDAalMi uauwVaqiwcU9Eu3Lv79SutMca2SpQxbw85t5nkkDMtoTUjOiBBovs5hQcTzBgSnS5H i6x0zxu0mIapL2JgQJXwdSotSFYsEMWOxMXwelbKBOBjy47B5AZGOZgV3/ySCezq9I xLKKTXH7E6jXg== Received: from sonata.ens-lyon.org ([127.0.0.1]) by localhost (sonata.ens-lyon.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bklR6iE_ZQhC; Fri, 7 Aug 2026 13:52:42 +0200 (CEST) Received: from end (nat-inria-interne-52-gw-01-bso.bordeaux.inria.fr [194.199.1.52]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by sonata.ens-lyon.org (Postfix) with ESMTPSA id 43119A02B4; Fri, 7 Aug 2026 13:52:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ens-lyon.org; s=dkim; t=1786103562; bh=ft/GlJSuOkInGIakH+d85L48HWpxETel4vAeXSAwrRE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=C1u3Bjc+yHWWbZy+B1vMkMYpr9bh2Q1KECmJJYuzzgjK4sAJgYtUevqcNeVVk5Fl5 psD9OtTd6y8BqbPyMPhvFKDoykAcGNKWiHhBJniLVn4OMKDJ5P7tfaAsabXaPQYdvv 8VfD4YU8+vFnMuC7uFGpynsYoZRV+aWX/wptBd1V72/iRssM7WnRR+/CWS/YDAalMi uauwVaqiwcU9Eu3Lv79SutMca2SpQxbw85t5nkkDMtoTUjOiBBovs5hQcTzBgSnS5H i6x0zxu0mIapL2JgQJXwdSotSFYsEMWOxMXwelbKBOBjy47B5AZGOZgV3/ySCezq9I xLKKTXH7E6jXg== Received: from samy by end with local (Exim 4.99.4) (envelope-from ) id 1wsJ7x-000000056AF-2wOf; Fri, 07 Aug 2026 13:52:41 +0200 Date: Fri, 7 Aug 2026 13:52:41 +0200 From: Samuel Thibault To: Ajith P V Cc: w.d.hubbs@gmail.com, chris@the-brannons.com, kirk@reisers.ca, speakup@linux-speakup.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] accessibility: speakup: refactor deprecated strcpy Message-ID: Mail-Followup-To: Samuel Thibault , Ajith P V , w.d.hubbs@gmail.com, chris@the-brannons.com, kirk@reisers.ca, speakup@linux-speakup.org, linux-kernel@vger.kernel.org References: <20260807111058.91464-1-ajithpv.linux@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260807111058.91464-1-ajithpv.linux@gmail.com> Organization: I am not organized Ajith P V, le ven. 07 août 2026 11:10:58 +0000, a ecrit: > strcpy() is deprecated, use strscpy() instead. > > As strcpy() performs no bounds checking on the destination buffer. This > could result in buffer overflow. The safe replacement is strscpy() [1][2]. > > Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strcpy [1] > Link: https://github.com/KSPP/linux/issues/88 [2] > > Signed-off-by: Ajith P V Reviewed-by: Samuel thibault > --- > drivers/accessibility/speakup/varhandlers.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/accessibility/speakup/varhandlers.c b/drivers/accessibility/speakup/varhandlers.c > index 462f8d879053..c6d3b4cc1af8 100644 > --- a/drivers/accessibility/speakup/varhandlers.c > +++ b/drivers/accessibility/speakup/varhandlers.c > @@ -1,5 +1,6 @@ > // SPDX-License-Identifier: GPL-2.0 > #include > +#include > #include "spk_types.h" > #include "spk_priv.h" > #include "speakup.h" > @@ -265,10 +266,10 @@ int spk_set_string_var(const char *page, struct st_var_header *var, int len) > if (!var->p_val) > var->p_val = var_data->u.s.default_val; > if (var->p_val != var_data->u.s.default_val) > - strcpy((char *)var->p_val, var_data->u.s.default_val); > + strscpy((char *)var->p_val, var_data->u.s.default_val, MAXVARLEN + 1); > return -ERESTART; > } else if (var->p_val) { > - strcpy((char *)var->p_val, page); > + strscpy((char *)var->p_val, page, MAXVARLEN + 1); > } else { > return -E2BIG; > } > -- > 2.43.0