From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 352B63AA4F1 for ; Fri, 7 Aug 2026 14:38:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.200 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786113515; cv=none; b=tTFZTZpHLk3zfQ7szqbp7f4dtHlKMm7Af9YVUC/CgZsBXhsp5+5+JREB50KDSJ/GJEceZe1cMvAbEOC/kDSiymF1AjYLeK27lzzi/PeoTEvNUe4fnMXccpObYbtAVQf4D+VMOuPnCQwhiiB1gPe8rf7NUsTdFXDMF7mD2nqVu5U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786113515; c=relaxed/simple; bh=/8eBC4cBcmk/OOwRZMskFCKDvUHCS1O1Ty0m2S3GOb0=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=ADhT+7kypT3kqwfEEtgft5MUqCawu62xWC/dirRW+PIR6VOAc95UDKWS7QE5FYdpBa9xHNoBB0OBttk4gldhS4nq31JIlQVM5o3N1ZKOWosi4YGAGwzw9/G2fWCXE66LUd180H+c+e3kkkl8kj9fKUbMmBzNAH2832L8fbJhw/0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=Z409DCqQ; arc=none smtp.client-ip=209.85.214.200 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Z409DCqQ" Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2cc640dfde3so40534815ad.1 for ; Fri, 07 Aug 2026 07:38:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1786113509; x=1786718309; darn=vger.kernel.org; h=content-transfer-encoding:content-type:cc:to:from:subject :message-id:references:mime-version:in-reply-to:date:from:to:cc :subject:date:message-id:reply-to:content-type; bh=wfh7ukRj1lyo1oKSry2hYUgnDccy+4/yKqQMGL09KaI=; b=Z409DCqQQIeuuMzg5WwomjZrsXJfC39thP4Z5k1P9ZNVZVk0fKhg6bFbSEvp8MyA6v 10YRMtDnHQOhU1+gVhQaM5UGl5IYhHuGvkKJxdnX4zFeBhkyxBfDl/Yzoj+fcmw68glr LD4axN2PVXKdZNo8xU7KEwTtlzuvEjsZsC5kWDtO4avTv13ag+Fm48x2EIMhPzHXxTMA YbMwn8+GEPGjWeyHmfWEdxObqZsCU7bbRGGIEhWGHzOBmosL2BQXYAdPYGfylQf3xSJ8 qRym7OsP5dhV5AsY0FZO5pUs9CyWRf3JTFezkyKJ2Tu4ARHWum14Zn2BUWPL0+xM0Q+F 5W+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786113509; x=1786718309; h=content-transfer-encoding:content-type:cc:to:from:subject :message-id:references:mime-version:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=wfh7ukRj1lyo1oKSry2hYUgnDccy+4/yKqQMGL09KaI=; b=kWA3UOT1LjmfT50+PnyvPV7s2ikdZ9TO6v8bpqu1b8y7Wz1U9RXvmjSg1kJHb93bay oera+xPU/vhQDQGVepsoLmAwIPYO25IH4uSGm4rvv/jXaP/9ULHFjl082KvAuIL7VRbx WBaS1qxDVJ3sPRCr8wYgMQZqVLAwRtqeQzQ2NJNt24rmotuqW4YOXxbUUnjaRMirw/3S utIxsN/ke7472KWHj/O/rr0ZTbgjI+u1Z4gCzW73OHj7oylcyPUcU13mnDANv4CMgFzY tjutRhKdeXChFPk3UITBWeErwf8Ic9BUOToVkjDzTHsiaIDps3Vzshixm2treh9oOrkV Fa+A== X-Forwarded-Encrypted: i=1; AHgh+RrgPaYaP2b78Oklnji2fz8MwMzUoO/3Hqm/gHbbqRSDfnWxxcxwHD73U4xrW+ktETXDrj09jKGrl5QOBnI=@vger.kernel.org X-Gm-Message-State: AOJu0YzxBF6Akiq44eQJvwUDq4rF92H3hMchOsDqZfbb2V7dzYxnV45L skcXK8k/EDhq7qcMuZ5nCVTp262rViVHSKzhO8ha1aKh4kaVBp3ajiB5qOrtQ1hYfQxaoFJ0A1h KQl0Lfg== X-Received: from plbjc21.prod.google.com ([2002:a17:903:25d5:b0:2ca:d66c:97b2]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:902:f68b:b0:2c9:e846:a57e with SMTP id d9443c01a7336-2d2a55ecec6mr12985345ad.0.1786113508614; Fri, 07 Aug 2026 07:38:28 -0700 (PDT) Date: Fri, 7 Aug 2026 07:38:28 -0700 In-Reply-To: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260805031257.1844914-1-xiaoyao.li@intel.com> <20260805031257.1844914-2-xiaoyao.li@intel.com> <82482276-0140-4d90-a983-fdfc5bc2e4a5@suse.com> Message-ID: Subject: Re: [PATCH 1/2] KVM: TDX: Enable Notify VM exit From: Sean Christopherson To: Xiaoyao Li Cc: Nikolay Borisov , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Kiryl Shutsemau , Rick Edgecombe , kvm@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Fri, Aug 07, 2026, Xiaoyao Li wrote: > On 8/6/2026 9:33 PM, Nikolay Borisov wrote: > > > diff --git a/arch/x86/kvm/vmx/tdx.c b/arch/x86/kvm/vmx/tdx.c > > > index 545b03d9d10b..cdc0d24657ac 100644 > > > --- a/arch/x86/kvm/vmx/tdx.c > > > +++ b/arch/x86/kvm/vmx/tdx.c > > > @@ -2129,6 +2129,9 @@ int tdx_handle_exit(struct kvm_vcpu *vcpu, > > > fastpath_t fastpath) > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * - If i= t's not an MSMI, no need to do anything here. > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 */ > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return 1; > > > +=C2=A0=C2=A0=C2=A0 case EXIT_REASON_NOTIFY: > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 /* NMI blocking state is = handled by TDX module */ > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return __handle_notify(vc= pu, false); > >=20 > > I'd rather there be a private handle_tdx_notify function in tdx.c than > > exposing __handle_notify and introducing the boolean. This is needed > > because the TDX module handles the NMI unblocking, so let's keep the > > implementation specific to tdx. >=20 > The initial version just implemented a separate handler for TDX. It had t= he > exact same code as VMX's handle_notify() except the "NMI blocking handlin= g". > So to eliminate the code duplication, I changed to current code. >=20 > Sean, please let me if you have a preference. Otherwise, I'll follow > Nikolay's preference in a v2. Handling this like __vmx_handle_ept_violation() and __vmx_deliver_posted_in= terrupt() seems like the obvious answer. diff --git a/arch/x86/kvm/vmx/common.h b/arch/x86/kvm/vmx/common.h index 08005676702c..c179fb34c336 100644 --- a/arch/x86/kvm/vmx/common.h +++ b/arch/x86/kvm/vmx/common.h @@ -4,6 +4,7 @@ =20 #include #include +#include =20 #include "mmu.h" =20 @@ -183,6 +184,25 @@ static inline void __vmx_deliver_posted_interrupt(stru= ct kvm_vcpu *vcpu, kvm_vcpu_trigger_posted_interrupt(vcpu, POSTED_INTR_VECTOR); } =20 +static inline int __vmx_handle_notify(struct kvm_vcpu *vcpu, + unsigned long exit_qual) +{ + + bool context_invalid =3D exit_qual & NOTIFY_VM_CONTEXT_INVALID; + + ++vcpu->stat.notify_window_exits; + + if (vcpu->kvm->arch.notify_vmexit_flags & KVM_X86_NOTIFY_VMEXIT_USE= R || + context_invalid) { + vcpu->run->exit_reason =3D KVM_EXIT_NOTIFY; + vcpu->run->notify.flags =3D context_invalid ? + KVM_NOTIFY_CONTEXT_INVALID : 0; + return 0; + } + + return 1; +} + noinstr void vmx_handle_nmi(struct kvm_vcpu *vcpu); =20 #endif /* __KVM_X86_VMX_COMMON_H */ diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c index 9abd2ed3aeae..e77c1037e95d 100644 --- a/arch/x86/kvm/vmx/vmx.c +++ b/arch/x86/kvm/vmx/vmx.c @@ -6289,9 +6289,6 @@ static int handle_bus_lock_vmexit(struct kvm_vcpu *vc= pu) static int handle_notify(struct kvm_vcpu *vcpu) { unsigned long exit_qual =3D vmx_get_exit_qual(vcpu); - bool context_invalid =3D exit_qual & NOTIFY_VM_CONTEXT_INVALID; - - ++vcpu->stat.notify_window_exits; =20 /* * Notify VM exit happened while executing iret from NMI, @@ -6301,15 +6298,7 @@ static int handle_notify(struct kvm_vcpu *vcpu) vmcs_set_bits(GUEST_INTERRUPTIBILITY_INFO, GUEST_INTR_STATE_NMI); =20 - if (vcpu->kvm->arch.notify_vmexit_flags & KVM_X86_NOTIFY_VMEXIT_USE= R || - context_invalid) { - vcpu->run->exit_reason =3D KVM_EXIT_NOTIFY; - vcpu->run->notify.flags =3D context_invalid ? - KVM_NOTIFY_CONTEXT_INVALID : 0; - return 0; - } - - return 1; + return __vmx_handle_notify(vcpu, exit_qual); } =20 static int vmx_get_msr_imm_reg(struct kvm_vcpu *vcpu)