From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-189.mta0.migadu.com (out-189.mta0.migadu.com [91.218.175.189]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 683AB3BED7D for ; Fri, 7 Aug 2026 19:54:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.189 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786132490; cv=none; b=qCzifJ4daA4dxoChRwxKGYt0SZTyY89s9L6uww7OfpqAv8ONbiSaHBvYhj3TlKSxCGZseFPEMQlH2MdFrzYnDhDZHRHPfYbd/Bt61NbfdCHUwDpUv4aWwB92uvMMD6ATGLFBeHtlkGg3lTmKb4lbSAGbUzVU7cP1EZZXruKnoas= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786132490; c=relaxed/simple; bh=hJgWnC01+p3URJWDPTKDweEuLhkBktHb/99ViCPY+Go=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=mV+BDDoc5d7DSMOFIMmGM5UTWXbilX/rhlGxxRJIspQIeNkILHIogdwitzlQSmeLOABkRG+QdJ/8xKUn3vHNXDL0tpg0dVGXNmelDhBnqrmBxoc8zRRmwvTugygvFQQZWuOfJSZ+dT9qegNQLb7xaPOzr8gFmNLB1MvPKcfRW28= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=s6y3zKpZ; arc=none smtp.client-ip=91.218.175.189 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="s6y3zKpZ" Date: Fri, 7 Aug 2026 21:54:39 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1786132483; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PrOR4/4/t9uG1CtfaEroNqxI4nkyR4L3Fs4X29ZI5Dg=; b=s6y3zKpZHU+aZcNxy6YGjgjgaPL3UYtCHdzXp8mLcd7fURv/u7PHyuhY+NB0toWasmS2SV LVf6stI3JTDqxtTe/XMMn2HVl7hZpYG7Jzyr1viXUKfJbVrcMeq7C6BqHEjFRTRyOGeoRe Hk7igqPYuBtcPhTHV1kErkE0YC3NmFI= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Thorsten Blum To: "Christophe Leroy (CS GROUP)" Cc: Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Geoff Levand , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] powerpc/boot: Mark exit() and ps3_exit() as __noreturn Message-ID: References: <20260807152353.306889-2-thorsten.blum@linux.dev> <41e20610-6bc5-400c-9e44-c214162605e0@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <41e20610-6bc5-400c-9e44-c214162605e0@kernel.org> X-Migadu-Flow: FLOW_OUT On Fri, Aug 07, 2026 at 05:32:44PM +0200, Christophe Leroy (CS GROUP) wrote: > Le 07/08/2026 à 17:23, Thorsten Blum a écrit : > > Since neither exit() nor ps3_exit() return, annotate both functions with > > the __noreturn attribute to improve compiler optimizations. > > Is it worth spending time optimising a boot sequence that will run only once > at startup ? > > Do you have any figure on the improvement ? No, and I haven't checked its impact. Maybe compilers can already infer that both functions never return and optimize them accordingly. Besides potential compiler optimizations, it also serves as documentation. I can reword the commit message to clarify that, or drop the patch. Thanks, Thorsten