From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 72D1141DDF3 for ; Fri, 7 Aug 2026 16:22:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786119726; cv=none; b=HN5FvP8y83bQ7sUcyAGyh8nakuM8T24832dqEMCIS+mRH0iqJ6uca8i8HEAZip2rC8AbfICI7LLSafQl5JnSY9qnhttQl8WeGOJVmw4c789h8dIsopY1ZoLx97bHMToridert0es3Qldx56Hk6sR0SEdvK7PD2NJUYY71j0lJTo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786119726; c=relaxed/simple; bh=teP7pgs23k88Y65Zu23zwXDC3A6Sy8Lk1+ga+1XpcD8=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=qn1zTvcuHUSS5+tWe14gfvxQR63bAisTqF/0uzPsIijiBarJX9TFMbAUCONBDG3JVSWcd2izLeE/wfn76LuDf23hp3UWXXpbzP8Zl14xlbf2n+C3wJKaj1NNlCzJrl7rR4Svt/+ORl2zlHGQGL+X17h7YPfXxgKcFrbvlzu8QII= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=googlemail.com; spf=pass smtp.mailfrom=googlemail.com; dkim=pass (2048-bit key) header.d=googlemail.com header.i=@googlemail.com header.b=COC138kt; arc=none smtp.client-ip=209.85.218.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=googlemail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=googlemail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=googlemail.com header.i=@googlemail.com header.b="COC138kt" Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-c15d3cd51b2so478152166b.3 for ; Fri, 07 Aug 2026 09:22:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20251104; t=1786119723; x=1786724523; darn=vger.kernel.org; h=content-disposition:content-type:mime-version:message-id:subject:cc :to:from:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=h9HqpnV7RraA5YCdmhwSzTXcN/Huyip9SBv7EhjfAnU=; b=COC138ktjupUXTLEOsT0fcB4UNdXkcJRAbOeGemwNNm4kWPIKHMXaVWs2zdeznTDZ0 Cv2WyPlbmtB8QV0+TAlCLFueR4oo/0AnaRhiYlkgPPgeRAurOjn8bdkji8B81jtusFbC 8R/yumYEXGjupDxg9IRkZ3I5dLqDQjghIOGjA0G9d6gbLD9QPx4mz+8SHpbTKOJLmq8a y/9TUHNZnEdEs4K9M/PYZcuAsdxVSj7h3IqUqCEkYEILmG0+/Pe6JDBc/j0o4Tno9lHb tBDH2b3FmqWvCf9BKyaGCP3Lng4rDTlgO0YdVv88YG1p9gpkilJDu0cV+qs2mc3LL4uM v0AQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786119723; x=1786724523; h=content-disposition:content-type:mime-version:message-id:subject:cc :to:from:date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=h9HqpnV7RraA5YCdmhwSzTXcN/Huyip9SBv7EhjfAnU=; b=NkdPQXP/HJpwIZ2PykQxKWGFWir3ar3nEDA3LYUY1eA2lKXTlPIgKickD12amPqddF LZjA0t5dt/8wr/NPFoKgDa2peLcb0otLVWHdH/vadofT3sUgMIKGlJRFE2g707NwifkE y0DgpdRXExtiRgtawS7R65YuxeN/rC7W+dpb0q7vsnOK8x1xDH7nTedadVK/yj8fNRaG GRtdTSou7sDQlotxMT70G1bzYuzHI5x8mAu2kvkgsBy4ZPlyZtnmdGXPViuPnWMH2VEj UTF7FF8BtXNSkkamjGo7hwPYqfRkxNT01F0nNW2D872LuSX300jgcUPwQl22YtRhdsRb ulHw== X-Forwarded-Encrypted: i=1; AHgh+RrMldFyPQ9RXlNr6P/Aeg1hLZuSsvpIb9R3vOsRm9DvbMle3b6hQrZzs71AmNodNoxLhVOGCX+zluvpdGs=@vger.kernel.org X-Gm-Message-State: AOJu0YwCrejlPFegWrAURw0AY2/1AZ4hg1jznHajwgc0XZzRR1sKGSoJ GqkwdBoo8x1g0NrsAFFy7cAotyYuzGOhh/VFkTnJUaaheDZ9RHdEjwQk X-Gm-Gg: AR+sD12OPvOGfbWn4flAuTrO3ryGttcuoSkRAT1h4MRPPIfSjzr0eskg5Fu+RJPvPsh jfwoXewLuxPgAfwZ3ivLiC33JxuOUNhp8LMXC61eFys2Fyk7h6y62aSoMW439ShV9RSYCtCmE3i UqBO2ejdme88lZbEbmcQWwJYtacf2czvpRJdxxnYIa0TlkFxDxNfxXR0i+Ze6CPU2aI7utOSn+z BJM6ODwu7E0F7u8C4z0X9n7agoD8O/0BaYeykoOCxk6/l6NDEXtr2WzvLWZts2bNAkMo6iMNO78 c9+DGHYAvmncMlkSCxtSFp8QTQCuXXNQ3a12kM73xgVFE7trBEwtzg+R1fGTDde4btN23H8RLTD 1frbmOUq8Qjhn9FtfIB8LeCr2IK12vm3M8ppzci6lmR8+5ZezB4Rh6kPLdjM33t5x7xGcCsBZN4 Qp8td9uU6XpF897LTaQaP65T3fyBdJ25d9ORSqd1kH3RKAhdA+LoWR2p9XWqT1M2IFsCkP6mCd6 j/C/rkCQIXpAzqMj04= X-Received: by 2002:a17:907:1b16:b0:c16:72ba:d352 with SMTP id a640c23a62f3a-c208761d3f6mr93206066b.31.1786119722466; Fri, 07 Aug 2026 09:22:02 -0700 (PDT) Received: from david.gall (k10193.upc-k.chello.nl. [62.108.10.193]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c2080cc3bdfsm69127066b.48.2026.08.07.09.22.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Aug 2026 09:22:02 -0700 (PDT) Date: Fri, 7 Aug 2026 18:22:00 +0200 From: "David C.C.M. Gall" To: Herbert Xu , "David S. Miller" , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Cc: gregkh@linuxfoundation.org Subject: [PATCH 2/2] crypto: keembay - use crypto_memneq() to compare CCM AEAD tags Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Use crypto_memneq() for constant-time comparison. The CCM path in ocs-aes.c verifes the received authentication tag with memcmp(), which returns early on the first mismatched byte. This leaks valid-prefix length and allows for valid tag forgery which violates the INT-CTXT guarantee of AEAD. Assisted-by: gregkh_clanker_t1000 Signed-off-by: David C.C.M. Gall --- drivers/crypto/intel/keembay/ocs-aes.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/intel/keembay/ocs-aes.c b/drivers/crypto/intel/keembay/ocs-aes.c index bb6f33f6b4d3..13ba7573617f 100644 --- a/drivers/crypto/intel/keembay/ocs-aes.c +++ b/drivers/crypto/intel/keembay/ocs-aes.c @@ -17,6 +17,7 @@ #include #include +#include #include "ocs-aes.h" @@ -1283,7 +1284,7 @@ static inline int ccm_compare_tag_to_yr(struct ocs_aes_dev *aes_dev, (i * sizeof(u32))); } - return memcmp(tag, yr, tag_size_bytes) ? -EBADMSG : 0; + return crypto_memneq(tag, yr, tag_size_bytes) ? -EBADMSG : 0; } /** -- 2.43.0