From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com [209.85.167.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD79842D753 for ; Fri, 7 Aug 2026 16:39:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786120795; cv=none; b=g9O8VWhOhvQRQP+7ZYBuoZwtn4XEq4pSbY1WSYj4WqIDDDXinOnlq97x+PHyeFfwzZxYYJDk03ZiEqldDJsSU0jJRbbm7lbjUuI3M6gyWl2H+0Jt6u2LvTeuB61RWb1j6XtMoCzI4Ysz840qw7sh4wlKR7zLFmj7TkNxPsmSy6I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786120795; c=relaxed/simple; bh=epq73lK3MZUwvnu8FNf08QieBBaJCWva3MyuIW62F6M=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=TnnGgO5J64ad6He/gN3I9mz+ZOUmHGGUgCZZs/xSxNAQ0GC4kKl/w3/fB2CedmRy6PZRC5n/Bw4zCYMFOGApwYQgSPkgvzF9j4PcutyzsRFsPQq3D+mAJRiDzqE61QzOKdS2Z3gG34kDgQQRWSEFRY9kE6xSPqCDqqmuV64Mz5Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=T4AmMYDq; arc=none smtp.client-ip=209.85.167.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="T4AmMYDq" Received: by mail-lf1-f43.google.com with SMTP id 2adb3069b0e04-5b2aab18795so3956062e87.2 for ; Fri, 07 Aug 2026 09:39:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786120792; x=1786725592; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=wBAxmQq2KNDHznSsDDpOCDN4UZ6dDNu0GMeDOEsdv68=; b=T4AmMYDqQeGiQGqo55DKUyGupbJzxmshFCyj9CKmGDN4J3hyyquWk1/MhWP1KY26px 29/gPnkTa+758TklLHmtW4lRKhSybi7qei9fHTRzjt0W2lITeJMD+tkP62Q6Kw5gpK+F zXkGSXnTIThCCZVuxqtRbLBLnUkGrRtefJ36/wwbguMVGVft2bJJyeR44bFu/XDc44i9 Fm6eHKBvzqLbWTbc6WQPoQTY6cqAyTDx1bARDHTHXUraHic1RwG3VM6zpH5vQnj54mmd 50GGIjIU5yMjw+sOwqhYsNOoTCaDFcDU8BYyV/OD1moQfbDnpyVab+bTASX783khTEIM L68w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786120792; x=1786725592; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=wBAxmQq2KNDHznSsDDpOCDN4UZ6dDNu0GMeDOEsdv68=; b=cs3T0zo4ic7XOstJu1uFvAXBHeQzLPUMXRhdeIDT7GZLLIQDCRKqaQtOgSCxD1F9Uq egsvkYa51LjyGhNvZijzx947D6HWqljBOC3s6qimYwhC/Ggn+DB+b2AsNcYvOZyZS/UM QtxXb7vf1RBzk09o8DVi4Yr9As5hMhgW63kioK6g9xs2b09iF3V3Tca3mZnMWDzarbqz +7z0dwxe2xyX2ofoUJm1B2vYkN7r/DGUwFqZ0OeAioZ6KTmOrkNKYQZ3IflCT3mDE7LE RuE75PE8AfVe7WQVq4puNP8GqL52h58zrFzF5SLKeFO3zgJcF/Tybh/CFDqx5eJxK5o7 o+1g== X-Forwarded-Encrypted: i=1; AHgh+Ro99y2C/iEZo9YwOyquzu3h9Po3L0zSw8pKu/UZHPHOx/ERhO15soApsCVotTNlptFdbS416JSzlLjNTOs=@vger.kernel.org X-Gm-Message-State: AOJu0YwtiRr2cQwMGHqPK9btCngZmW6ztMfjYIC3OFkXPIR0q4EOeLI5 ia7tG3avbJrv1atIhIMpJoNpE0LXQKuhjmobPtDB4wJHleCjJiumaEEF X-Gm-Gg: AR+sD10sbEKwkjjc7rqBz0UQeuweCeI8oAAHASG9pgz3JIlyxxslIKFApcAmoa00k+A pVmgTKZ36PHuC2lLLyBSAGZDCseZ+cKMpPSYLPXGl5unB1OOdCtRWgZCajnkIH10YNhCpNYMhyN h81GS6kWD7cq0Soh3DFRujeED2CSBpMvTtEj2LkIgojqC24WhgnhuJ+114tjvRQ4a9pI6v+hQUy hKCEZXOh3kGq0VP3ShR5PXYMHmUTUYRhAXr/zACVeqZHKuSltihPmkOk57o1CkU0Z+5oqnl37tZ wzwUcP7+bym6nM9L7nRTQLwIg0NDjCteFId8y2N4hbfXK12rEi5aB9V+QhikqxujMb9PpSD3Okj g71byJeoE8/JKOd4HWb109yS25SjhwicOp1oFTKJCsPgg6eJM0k3zRqELsVASLJQD+kOXb6324c 8njOIl4uX4b0wdgiGrQJlKwBQsa5wOdhkYRr3npjxA3GpkkrjRDjXZfBzE180= X-Received: by 2002:a05:6512:1055:b0:5b1:543f:f5ca with SMTP id 2adb3069b0e04-5b30b78abb6mr252549e87.46.1786120791547; Fri, 07 Aug 2026 09:39:51 -0700 (PDT) Received: from archlinux ([94.229.19.199]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5b304fd1e8csm564346e87.8.2026.08.07.09.39.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Aug 2026 09:39:51 -0700 (PDT) Date: Fri, 7 Aug 2026 19:39:47 +0300 From: Nikolay Kulikov To: Greg Kroah-Hartman Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rtl8723bs: remove static HalDetectPwrDownMode() function Message-ID: References: <20260806-rtl8723bs_efuse-v1-1-fedb8b91f346@gmail.com> <2026080749-dolly-never-0406@gregkh> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2026080749-dolly-never-0406@gregkh> On Fri, Aug 07, 2026 at 09:03:21AM +0200, Greg Kroah-Hartman wrote: > On Thu, Aug 06, 2026 at 10:34:48PM +0300, Nikolay Kulikov wrote: > > The return value of this function is ignored at the call site, and since > > the function has no side effects (except for the assignment to > > pHalData->pwrdown, which is not used anywhere else), it can be removed. > > > > At the same time, remove the efuse shadow functions, as they are > > becoming unused. > > Why not remove pwrdown first, which shows that it is never actually > used, and then remove the functions in a separate patch? that would > "prove" that this is a safe change, as-is we need to manually verify > this patch is correct. Yes, that really would be better. I will do that in v2.