From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 940543750A9 for ; Fri, 7 Aug 2026 17:08:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786122504; cv=none; b=rjo+sqLXmOS0DPz7vw2L9TSu68mOZgP+FdsJcgvh96qKGK4a6gjQepki0ADKQcHXP6JV4VKu6lPmZkZwam4RTuynPcw7SWBkFemhaG+73KPY1Occe5WC8H6L7TBQ93OI7kwMmU9wLbpNndCOyEMvNFVy/bgihFphLzsyWLAvSVA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786122504; c=relaxed/simple; bh=PEyv/ZNi02HaucwD0lzLJLCQOah9Kpc2cmwW88odXGA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=oQD1Y5jChvP4HkdjJsNIG+ltd8ea+L3cncQyHL8J6zCgsVYHLR2FfbMMaG1HhNpEQelrJVVj3HvY+kxDolN4NzLOylFOHtVmmL8r+p22oTKpZDO2INv+sEKo+N3FF08kkfb3Sk152l9/Q55l7K9j7tVgCYr6iV0o4VEIhwt911k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JtNOOLD+; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JtNOOLD+" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-4957eefd361so27447925e9.1 for ; Fri, 07 Aug 2026 10:08:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786122501; x=1786727301; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=iaOeMTZOYIaS16knxOG50vS1TNGyqbn7Zjc+qZ37u3k=; b=JtNOOLD+BKHzhekHXUFK7fqLux5xka+dQPHThqPO7XT6oqsXWCT4m6xhGTlI8f74a0 wX5D/AydYqllox4SGbbLDoTFfohtmOhisesQqCKbVr3UtklUb66Sfsbw4fsOdzaM9RWV oW6nk90WC5JXhTxWcwlBrKDnSzI/8vtrEjRuaUiHiJkcHJqW/1dck8GIIzKjMSvbMxoR 5g8e6Nus2QRm2nHrqPOlGevHhepxAP6LuBB6y1POSc4J/7HerzDyqoLXetPFML0Lg6Rk cJRmBA+3tPb0TYXilKRvB5AlJgfxsZtf7Q0Di5VrOsLEEjg2FQM9H7kMJ7DXckshd9Ew UiGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786122501; x=1786727301; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=iaOeMTZOYIaS16knxOG50vS1TNGyqbn7Zjc+qZ37u3k=; b=mcw1iNeaidmRtcpsYA0bXScA8LN1Xt6D2UCEdqEdad5InDUquQiajfRfD9EK9v/Oh0 REQRVdjcrAgmlFMn5V2uebi18xkZmvtqH6tlfzNZ3bwLAGJn4rH5BJoa1exl/wQB9EKW EX7rXtZWIDuUBfBq7guHlYI7rf15FS1TeHgJruTxNlXai+mUZBesoR8ayHxw/j5sbx5j ncJdZy9xnMAUIyw5TqzmFtKTpfo/c/U5HfBOjKA5Fid0hMyH2cW9VDmy97Hs7HsmvRSR Alr4TtzyZnOsEKvzkpmZa06Af78T0mtazeYfS3kp2NVmFws8ILK/+E88WUN2XA4cAvti Kslw== X-Forwarded-Encrypted: i=1; AHgh+RrI6DKCgH0PGYpB13uHQenaRKeesggIZsWEGQsHax1krMvrXLtTxJGtU8n8EEpZzzyl/kqpOBB2EtdO8pQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yx257EK4PVxTTZniyaOwmtlZG6LruhLeH9zvSPQllavKOQcnJYg 6VoGB5bKfRRHYM6EAbq28HvAb3qn8jY6//9Db0n2BBoZVV+cr6tR7KGZ X-Gm-Gg: AR+sD11FGdB8NA+GouxSHt5Q/3bBOP048NWy/1tuRqHE3Gr5ZYPtiNRvy+eHrythIAl UeqPVAND6dygKivdpzQgzxseMZ4RKNpVdab7h+tBHncp9VGPwxAxL0+lgVu9uOT8MiFG6HMdrk5 JcpSSkUhGAzYUBC7zFhNNEcfJeKOQhuiJDMMqywNAwwtEYCW24p0r80BBfX10IxWMZI4ZIxgXf3 n8v0KJqxb0Uhv1ARbcVfBRmH6rU2It6XZPXdM9mV7LHXifzo5L28phrAxuZDBa7WykBd5HP9QKY 0zGgcCT1BQsQC8EfPiFDDCWkAWaBFG7KamXGw5p/9lMlS3zZsoAUaCpjjscPiqfuj1m9Pg91lIo WfVHzI9sW7tnkiS+JueVqV9EWcpyuD/NVTY743bm+aAQH962qO+o40TQed7HyHfVWoHqhYOVpbH xieCwjBK+ydOWUiZsgaw0VApMc7b/Nr+uPfH0GqcAGmnlmDlE6EElAW+h/U/Lz4wB2xW+Dfd67o GFnRsDQWsuPu9qr5fsNkO+SE7nw7uVZCIBWALUP3+7B9ojOiio5BN6qGVuXOwtHYb1Y6xKFeQMU Jxx0O/4DZt1LaDndxqjBuyaIS42AaFyqPTCTjLT/vHN0R9hv23ytKEMq86nUIQXQkx2+rgMdSKO H2fRIdrX3Rz8TQqPyFWQ= X-Received: by 2002:a05:600c:b85:b0:496:c93d:e2f with SMTP id 5b1f17b1804b1-4995e0dff0amr73285775e9.15.1786122500534; Fri, 07 Aug 2026 10:08:20 -0700 (PDT) Received: from MacBook-Pro-von-Karl.localdomain (dynamic-2a02-3100-b105-e101-a437-493a-4de9-ee3e.310.pool.telefonica.de. [2a02:3100:b105:e101:a437:493a:4de9:ee3e]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4995ea27ef0sm60747585e9.9.2026.08.07.10.08.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Aug 2026 10:08:19 -0700 (PDT) Date: Fri, 7 Aug 2026 19:08:17 +0200 From: Karl Mehltretter To: Marc Zyngier Cc: Oliver Upton , Fuad Tabba , Joey Gouly , Steffen Eiden , Suzuki K Poulose , Zenghui Yu , Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH 1/2] KVM: arm64: nv: Allocate the shadow S2 MMUs individually Message-ID: References: <20260803224405.41468-1-kmehltretter@gmail.com> <86mrv2arf2.wl-maz@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <86mrv2arf2.wl-maz@kernel.org> On Tue, Aug 04, 2026 at 03:31:13PM +0100, Marc Zyngier wrote: > See the hack below that seems to work OK. > Hi Marc, Since error handling has come up again, I should clarify why v2 did not use this sketch verbatim. > - kvm_init_nested(kvm); > + ret = kvm_init_nested(kvm); > + if (ret) > + return ret; > > ret = kvm_share_hyp(kvm, kvm + 1); > if (ret) Once kvm_init_nested() has allocated the pointer table, failure in kvm_share_hyp() or any subsequent VM initialisation step leaks that table. v2 therefore calls kvm_init_nested() after the earlier initialisation steps have succeeded and frees the table if a later step in kvm_arch_init_vm() fails. > + for (int i = 0; !ret && i < S2_MMU_PER_VCPU; i++) > + ret = init_nested_s2_mmu(kvm, &tmp[i]); > + if (ret) { > + for (int i = 0; i < S2_MMU_PER_VCPU; i++) > + kvm_free_stage2_pgd(&tmp[i]); This cleanup includes the entry whose initialisation failed and any entries whose initialisation was never attempted. An uninitialised entry has no valid mmu->arch, but kvm_free_stage2_pgd() immediately derives kvm from mmu->arch before checking mmu->pgt. It can therefore dereference an invalid pointer. This is why v2 tracks successfully initialised MMUs and frees only those entries. Thanks, Karl