From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F2D9C35AC03 for ; Fri, 7 Aug 2026 20:58:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786136309; cv=none; b=I8QrZkyRsg84cEYOMqzdf40MHqe9dwSiVQFyWZXQtxnNt+tWo3blfJfkcPCIfQetrPerpA2i8+KiNtaCCVuHsEGvqWm8A0cyJZtVIzo7bNW01zRzrhzknTPvBef+vxajOIYOGoYyC1jXAuVTaVSx6mHOIx9LYdM2ppS/7NNa+tg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786136309; c=relaxed/simple; bh=2J/UP/+6DMH2CHEER9PVAEvN6Vtdaca1g6fEmR+C3dU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=e2upLyUeFC61ScVOa4gLq75qt1w082/PG7xEmYO4Gx6TYmHhsFLfR79COhkiabGzlRXgI/Fup+w/0CyhtOMQU7F9iGCblqPyivdbRW0axOYCocjOujrZN2FazlBc51mzR6YtqeLRALUlhiU3HvAcax+3gjI0UHYSDMjAg1mLJac= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=lz1Rd8VC; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="lz1Rd8VC" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-4955de8797cso27090305e9.3 for ; Fri, 07 Aug 2026 13:58:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1786136305; x=1786741105; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=Ub+G0Ff6hsiwxt6UoJCvVXER5yXovtTMeMwmgc6K8J8=; b=lz1Rd8VCvRx7qtS80RxVEavo94LfoBnLpZwb21SCH4j4bTt9UZb0KA+ydFxRIVt7FL nxdSsWa74XLiyTQWKTUyAF2pAweLrVmrv+K/+4ntTWWRH7GF9eyT/65qdgEdmJUYMErW KwADCpdTBl8zmlaAtd/gN9DP0VLYLq0XIdf00XZzaq32No1ICxgvWuKjx/Iu4Qb+ImGC /47SKKrJC+AZf94OJnmycGyyEDOaOq12/Qhi4+GEmYC3Tt0Md/GATxtFUhb6BI+yU7o/ vN2JER+ycA7xIOPH+nP9nyza8XvzeaQboVHw8kER6MhsVksVDEskb+OoqLyD1Cpg9+Ot cpoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786136305; x=1786741105; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Ub+G0Ff6hsiwxt6UoJCvVXER5yXovtTMeMwmgc6K8J8=; b=lPw8hJNecIs1Iq0kLoTm2JhWXcWxWwo/gkQ8W3iGTNd5dWVjBvgoPpWdyiETxNFped weyUFSjEzsbnb3XJzD5Hba99zCCDNyBdLJey7EJO0mzyycqSbMjrXvPD0L/YyZcHYxMC Mp0D/XFEVqSV6NmsjGmIdfHGmLvMpCPk62iEuCUxWmE3mPeMXmD0s/mhrlPfiF7CqQKy 79WgZf3w4YyB+PQmkRR71ximKoMTPqvlnhDX7JOcWzAuCfNc0hGHl0gQcLm5BHR7oaQp DepOXPvA0+ni6Ob/rKdc5+KyKbwC1I5DarHObKo49WQ6hr7L4UWBpuqSuZGK3i/70EU3 wesw== X-Forwarded-Encrypted: i=1; AHgh+RoG/wSUDllQMGXO2nZlocokxhcfTCR1xOlO9zfjGS9Ew9D7vNmGUZHkJqVPqYKKtD4t5+h1tFTX4Vz9sT8=@vger.kernel.org X-Gm-Message-State: AOJu0YwT/URu7DBApu7mWxVKYc7uSb1p3ao+8oLle5o1zPrp/JcqTT2k ZUBUtDoOJj4yVo7FtXl4x8BWRlZVGlAPrty2aROJd5Oms05m529k32PD1AOD0c4NCGg= X-Gm-Gg: AR+sD112hekZwdSOaAYidqu2YqVuFV01nPaV2QNA9IZYq7nbhy1WJawnfVesBLEhI20 /ColuSD0s8mlI8J7NRNTl6LDasSvkyV2f0rm3sAG6YQUxC+oEPhAwU2KylE4/XQZgTg4HrCaImU 6C9PnmbEWILC0B4hKrzg1Lwq0XO6znAW1c2lKbPnfEL3MY3bwYAoC2zCddnM+j9mhFo2HlcM+Rw FYNGkGV20ScUMq266SQAyUivNv6B2FynRmg3CyCLjsqTkKdSFhCBhJ0zaNrKvGZwG7/rs1u47SX XTjb95v4OUwUh9s4PACORphE8Y1ZOyldH2D8C4YyaWtV1J187BZXt4LpaDwvPyZQne6kBUoFsi9 0BSPAakMtJyKael6hjoY+MJ5Esl3uojZZQ9pgX8dKGzirG6yKoclzQdUikTwNLPT+84EGlwrzEE pcgndgQJx6LhuSaDkmugroi1BIeC8o9TYlcVobnoFSKUc5rts9pqSeNGHOn46I/lfobw== X-Received: by 2002:a05:600c:6612:b0:495:4811:7998 with SMTP id 5b1f17b1804b1-4995e0ebf84mr102518595e9.17.1786136305361; Fri, 07 Aug 2026 13:58:25 -0700 (PDT) Received: from localhost ([2a02:8071:56d1:2de0:1d24:d58d:2b65:c291]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-4800215078asm8418961f8f.12.2026.08.07.13.58.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Aug 2026 13:58:24 -0700 (PDT) Date: Fri, 7 Aug 2026 22:58:23 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Nagadheeraj Rottela Cc: Srinivas Neeli , Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Richard Cochran , Michal Simek , Andrew Lunn , Vladimir Oltean , Simon Horman , Russell King , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, git-dev@amd.com Subject: Re: [PATCH 02/20] net: xilinx: tsn: add TSN endpoint wrapper driver Message-ID: References: <20260807104431.157230-1-nagadheeraj.rottela@amd.com> <20260807104431.157230-3-nagadheeraj.rottela@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="yneap3wk5hqcchh7" Content-Disposition: inline In-Reply-To: <20260807104431.157230-3-nagadheeraj.rottela@amd.com> --yneap3wk5hqcchh7 Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Subject: Re: [PATCH 02/20] net: xilinx: tsn: add TSN endpoint wrapper driver MIME-Version: 1.0 Hello, On Fri, Aug 07, 2026 at 04:14:13PM +0530, Nagadheeraj Rottela wrote: > diff --git a/drivers/net/ethernet/xilinx/tsn/xilinx_tsn_main.c b/drivers/net/ethernet/xilinx/tsn/xilinx_tsn_main.c > new file mode 100644 > index 000000000000..1ef1b0c2ee6e > --- /dev/null > +++ b/drivers/net/ethernet/xilinx/tsn/xilinx_tsn_main.c > @@ -0,0 +1,105 @@ > +// SPDX-License-Identifier: GPL-2.0 > + > +/* > + * Time Sensitive Networking (TSN) Ethernet MAC wrapper driver. > + * > + * Copyright (C) 2026 Advanced Micro Devices, Inc. > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include Please drop . This header is planned to go away soon and you can rely on to provide of_device_id. > [...] > +static struct platform_driver * const tsn_drivers[] = { > + &tsn_driver, > +}; > + > +static int __init xlnx_tsn_init(void) > +{ > + return platform_register_drivers(tsn_drivers, ARRAY_SIZE(tsn_drivers)); > +} > +module_init(xlnx_tsn_init); > + > +static void __exit xlnx_tsn_exit(void) > +{ > + platform_unregister_drivers(tsn_drivers, ARRAY_SIZE(tsn_drivers)); > +} > +module_exit(xlnx_tsn_exit); I assume you expect tsn_drivers[] to grow? If not, use module_platform_driver() to reduce boilerplate. --yneap3wk5hqcchh7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmp2RusACgkQj4D7WH0S /k5magf9GDZifuMmMgVgWbOijgerh1NAUQiervav2kcbQ650bgaya6orUyAqUnnd eGe7DyhyOOdkl3qnsTwH9/e4Xn739LEnnjAwWIBrFn56ErYRhl/Dd+vuD/9U0LPd bGwI5ss9L6itgtlzGpZRsi4KhSiWG0asI7Ll3WFkUrhOdMd5a2+L22Vd47E3gXAo lVQ7ntvXRliL54xVe1tVbSbz/JrN89nHRR7sI/FWjUEknfpTbVVldBt95gevSOc9 pVoI5wtCOSAMPQTzSAHFoj1qZcrOofeK49hvnUiasTy8OWa5oJiuCzHknYyPXcOS JWFSEfqueZ+Xqyq+Y71krOsj8b+cYw== =pHZr -----END PGP SIGNATURE----- --yneap3wk5hqcchh7--