From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f48.google.com (mail-qv1-f48.google.com [209.85.219.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 17DE53803CC for ; Fri, 7 Aug 2026 21:06:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786136811; cv=none; b=GHiER5OqmH/Uq9d9lvspsD6OsEpM7rf4cNN3LA5zxvMp8eZH3Rz22hYHdShwBoXJqvHhOeYBGjx3ulKAfhyPL+xrWRJdkpYiYyjgtRlo1l+Nhc2GfpHFcHUkzuDNndiR9yvQKd/VRFQE6PCtkDjrwGQlA7BlPHAQnVQXgjdfncQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786136811; c=relaxed/simple; bh=4HDxV8AOnVYHdrgs0ibOVVOJXW1dukzUfV+AYeW4k1U=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=SbfIvrjRbknptrVlw0LgULFgejyVfXALtzTZWKV8CRM1SRaRgqIwlQFn3uJ2FIv+VF/FE7bsCBvEcOCeY03L/PeVLHN2uTXhEqbD0orZ4/Zw0/Nwb8z6i7LSJEySfsaQpg9IOGPhD4sfswfmqVJVncb9q8DOhUsM3W28t+J5M2E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cmpxchg.org; spf=pass smtp.mailfrom=cmpxchg.org; dkim=pass (2048-bit key) header.d=cmpxchg.org header.i=@cmpxchg.org header.b=gcaMQRk+; arc=none smtp.client-ip=209.85.219.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cmpxchg.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cmpxchg.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cmpxchg.org header.i=@cmpxchg.org header.b="gcaMQRk+" Received: by mail-qv1-f48.google.com with SMTP id 6a1803df08f44-8f18d92172aso38778196d6.2 for ; Fri, 07 Aug 2026 14:06:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg.org; s=google; t=1786136808; x=1786741608; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=4HDxV8AOnVYHdrgs0ibOVVOJXW1dukzUfV+AYeW4k1U=; b=gcaMQRk+/mKYs2TS/2kOOMwl9eaubMLIg8e54DEz+SU3tWtdJ9Kb2Z4gKrZXQRCUP2 wsJo3WABgMXO8eZ6MxUf/mZHBPFsPpTvLf0P/SyPAIelL5Wj8sQ+SQ9yUaRGvn6C2MeO yMftjsgYDp0oDbDfxvcmlq6dTVxDl2ygVI0eZ1B+oFS0Fz8RE2LATY8NY/pQgqXDUOt6 8qdIH4qbxmzv93rxf0cdhJFP9H8RRupBNh0hUFqRQsp0STNtWbeN3ohBK17rfWrwPAg3 ymwhE4c8s7XhjXUfxlXidOg3jEOUNQqe4fPURQtzEYJ027AuCrFT8eftLlVRjqHtBw86 p1DQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786136808; x=1786741608; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=4HDxV8AOnVYHdrgs0ibOVVOJXW1dukzUfV+AYeW4k1U=; b=Qjs0QM2KkM/or3tR9eL/jOdAWGY5vQyMR+QLwYcXq5H1b2gE0aEjRiqZ5LkyyC+vJC DV8wjT8u5d12Lama67u27Zotpc9wQmV0e/5rjD7l7f5vKGKjeuSAZLHeIIZrC9fUVx24 Wc4fXLoaNty6VCBCjzglQ2pcCABIGGYLSsoDMLWI2UKZeMtijMB0okecNLNvXjzhkCfp 6oQ1RhZPLQvHBd79q0zB8LJ82LxGKTJ26ffAE1p7FR2LggV5s2lFPR1V+Xl4y+YG+dC+ Q4IKRP7IdxtDVbpYsH9duWDAckuwNTiUK07UVzSiRzwpPUBTRWDevhqHrnnBN86lTYqu SB3Q== X-Forwarded-Encrypted: i=1; AHgh+Ro1UUcNvj7nY1z5Y9xJikZtD2dvYtS2T+uwDqPjGdYPkj0OKVrRYVf9pyFNlV7NVA5L2lX4lUU28iYv0+o=@vger.kernel.org X-Gm-Message-State: AOJu0YxA8Plk8ttEiVWokey7lDR5N4/R3X9e3/mmUHJ7JpPOcNrnXh6O GvmaRdzo3wwRetcXlHB1vlH/rrBgr/9MOLhLMl4wHu0AbGd3ZdsjG/fbhgWFQnvxZYB2F5cR5O+ MM7I4 X-Gm-Gg: AR+sD12PZtSO9gtGH67Q5qOiPR4DzOBrNAYlH8gZ0mExIkxcuAP+m2n2RMqV1eJaUfw dGQ/VbUpLIcxF5AtekGX22NJXHG1xWOj0ALpnsbip3kyuRc5GjfimJ9dKdxM+7m6AiRsJ8qWZhX CKHqmGsw0UTgSCC20gRP4GCWcdjoCdRNt6KG5Qa3DomT4ef9V06JgYhyhgPafY0lVgFvo8JPHMx SjfcU9cSTRIEjQ1j184ZyJkCAvg4uaPeE0geWmT1Vj06aAnTG6yFHAUq1FcEKcBv9QDkB4XAmUl I6DbLFKS5ZKFuS+URiqOEd+NoxWSshAZXsYnAy+LFoo1PGlyAvVy9gtcFfiuz7XIQYgyIRIWlKb FyOJNttKPsPKbWau9gkLpNA9elRKcTa8c5PtxokcZYb0adBfSsQb2q1Jx8PE+GftZuq58u62qal Ju2SAq7U6ShWo3/7kxhVHR9whKd8iZfe9/O0x/KLsN7JZUCC+TkC+gl0LRjVo= X-Received: by 2002:a05:622a:2448:b0:51c:1117:c79 with SMTP id d75a77b69052e-52d0b193284mr158320901cf.24.1786136807783; Fri, 07 Aug 2026 14:06:47 -0700 (PDT) Received: from localhost ([2603:7001:f100:500:365a:60ff:fe62:ff29]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-52d165fc55fsm19974341cf.25.2026.08.07.14.06.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Aug 2026 14:06:46 -0700 (PDT) Date: Fri, 7 Aug 2026 17:06:45 -0400 From: Johannes Weiner To: Kairui Song Cc: Xueyuan Chen , akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, zhaonanzhe@xiaomi.com, baohua@kernel.org, youngjun.park@lge.com, baolin.wang@linux.alibaba.com, hughd@google.com, chrisl@kernel.org, kasong@tencent.com, shikemeng@huaweicloud.com, nphamcs@gmail.com, baoquan.he@linux.dev, mhocko@kernel.org, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, david@kernel.org, ljs@kernel.org, liam@infradead.org, vbabka@kernel.org, rppt@kernel.org, surenb@google.com, qi.zheng@linux.dev, axelrasmussen@google.com, yuanchu@google.com, weixugc@google.com Subject: Re: [RFC PATCH v5 2/4] mm: distinguish large folio swap allocation failures Message-ID: References: <20260730122304.2496440-1-xueyuan.chen21@gmail.com> <20260730122304.2496440-3-xueyuan.chen21@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Aug 07, 2026 at 04:29:17PM +0800, Kairui Song wrote: > Am I the only one that feel this returning argument is a bit ugly? See below.. > Will is be good if we just always check the margin use this helper > on alloc failure? Alloc failure should be a rather cold path I think? Works for me! Sorry, I may have been the main instigator of that complication.