From: Jose Fernandez <jose.fernandez@linux.dev>
To: John Stultz <jstultz@google.com>, stable@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
Peter Zijlstra <peterz@infradead.org>,
Sasha Levin <sashal@kernel.org>,
Janne Huttunen <janne.huttunen@nokia.com>,
Zicheng Qu <quzicheng@huawei.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
K Prateek Nayak <kprateek.nayak@amd.com>,
Shubhang Kaushik <shubhang@os.amperecomputing.com>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Xuewen Yan <xuewen.yan@unisoc.com>,
William Montaz <willymontaz@gmail.com>
Subject: Re: [PATCH 6.18] sched/fair: Revert 6d71a9c61604 ("sched/fair: Fix EEVDF entity placement bug causing scheduling lag")
Date: Mon, 10 Aug 2026 01:44:25 +0000 [thread overview]
Message-ID: <anksxhdkYBfcpJmN@linux.dev> (raw)
In-Reply-To: <20260415211149.2658910-1-jstultz@google.com>
On Wed, Apr 15, 2026 at 09:10:53PM +0000, John Stultz wrote:
> From: Peter Zijlstra <peterz@infradead.org>
>
> [ Upstream commit 101f3498b4bdfef97152a444847948de1543f692 ]
>
[...]
> (cherry picked from commit 101f3498b4bdfef97152a444847948de1543f692)
> [jstultz: Resolved minor collision in the revert against 6.18-stable]
> Signed-off-by: John Stultz <jstultz@google.com>
We have been hitting this on 6.18.y in production. The setup is a
thread spinning on one CPU inside a cgroup that holds nearly all the
weight on that CPU. That cgroup's weight gets recalculated on almost
every tick, and the per-cpu kworker on the same CPU ends up runnable
but never picked for minutes to hours. We see it as workqueue lockup
reports and hung tasks stuck behind lru_add_drain_all().
I tested this patch on 6.18.44 in a 4 vCPU KVM guest with a reproducer
along the lines of William's script. Three spinners are pinned to three
CPUs inside a nested cgroup with a high cpu.weight, and some extra load
in the group keeps its weight changing. On plain 6.18.44 the kworkers
on those CPUs get stuck runnable but never picked, and their vruntime
stops moving. With this patch they run normally. Running the same load
with no cgroup does not starve anything on either kernel.
Peter said in April that this could go to 6.18 [1]. Janne Huttunen
posted the same backport last month [2] and Sasha is holding it for
Peter's ack on taking the revert without 4823725d9d1d [3]. This patch
and [2] differ only in div64_long() against div_s64().
Tested-by: Jose Fernandez (Anthropic) <jose.fernandez@linux.dev>
[1] https://lore.kernel.org/all/20260407134519.GH3738010@noisy.programming.kicks-ass.net/
[2] https://lore.kernel.org/stable/PAWPR07MB100712177EB29A65F4385E4C29ACF2@PAWPR07MB10071.eurprd07.prod.outlook.com/
[3] https://lore.kernel.org/stable/20260725192000.stable-0001@kernel.org/
next prev parent reply other threads:[~2026-08-10 1:44 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-19 7:58 [PATCH v2 0/7] sched: Various reweight_entity() fixes Peter Zijlstra
2026-02-19 7:58 ` [PATCH v2 1/7] sched/fair: Fix zero_vruntime tracking Peter Zijlstra
2026-02-23 10:56 ` Vincent Guittot
2026-02-23 13:09 ` Dietmar Eggemann
2026-02-23 14:15 ` Peter Zijlstra
2026-02-24 8:53 ` Dietmar Eggemann
2026-02-24 9:02 ` Peter Zijlstra
2026-03-28 5:44 ` John Stultz
2026-03-28 17:04 ` Steven Rostedt
2026-03-30 17:58 ` John Stultz
2026-03-30 18:27 ` Steven Rostedt
2026-03-30 9:43 ` Peter Zijlstra
2026-03-30 17:49 ` John Stultz
2026-03-30 10:10 ` Peter Zijlstra
2026-03-30 14:37 ` K Prateek Nayak
2026-03-30 14:40 ` Peter Zijlstra
2026-03-30 15:50 ` K Prateek Nayak
2026-03-30 19:11 ` Peter Zijlstra
2026-03-31 0:38 ` K Prateek Nayak
2026-03-31 4:58 ` K Prateek Nayak
2026-03-31 7:08 ` Peter Zijlstra
2026-03-31 7:14 ` Peter Zijlstra
2026-03-31 8:49 ` K Prateek Nayak
2026-03-31 9:29 ` Peter Zijlstra
2026-03-31 12:20 ` Peter Zijlstra
2026-03-31 16:14 ` Peter Zijlstra
2026-03-31 17:02 ` K Prateek Nayak
2026-03-31 22:40 ` John Stultz
2026-03-30 19:40 ` John Stultz
2026-03-30 19:43 ` Peter Zijlstra
2026-03-30 21:45 ` John Stultz
2026-02-19 7:58 ` [PATCH v2 2/7] sched/fair: Only set slice protection at pick time Peter Zijlstra
2026-02-19 7:58 ` [PATCH v2 3/7] sched/eevdf: Update se->vprot in reweight_entity() Peter Zijlstra
2026-02-19 7:58 ` [PATCH v2 4/7] sched/fair: Fix lag clamp Peter Zijlstra
2026-02-23 10:23 ` Dietmar Eggemann
2026-02-23 10:57 ` Vincent Guittot
2026-02-19 7:58 ` [PATCH v2 5/7] sched/fair: Increase weight bits for avg_vruntime Peter Zijlstra
2026-02-23 10:56 ` Vincent Guittot
2026-02-23 11:51 ` Peter Zijlstra
2026-02-23 12:36 ` Peter Zijlstra
2026-02-23 13:06 ` Vincent Guittot
2026-03-30 7:55 ` K Prateek Nayak
2026-03-30 9:27 ` Peter Zijlstra
2026-04-02 5:28 ` K Prateek Nayak
2026-04-02 10:22 ` Peter Zijlstra
2026-04-02 10:56 ` K Prateek Nayak
2026-04-03 4:02 ` K Prateek Nayak
2026-04-07 12:00 ` Peter Zijlstra
2026-04-07 13:42 ` [tip: sched/core] sched/fair: Avoid overflow in enqueue_entity() tip-bot2 for K Prateek Nayak
2026-02-19 7:58 ` [PATCH v2 6/7] sched/fair: Revert 6d71a9c61604 ("sched/fair: Fix EEVDF entity placement bug causing scheduling lag") Peter Zijlstra
2026-02-23 10:57 ` Vincent Guittot
2026-03-24 10:01 ` William Montaz
2026-04-07 13:45 ` Peter Zijlstra
2026-04-15 21:10 ` [PATCH 6.18] " John Stultz
2026-08-10 1:44 ` Jose Fernandez [this message]
2026-08-10 7:38 ` Peter Zijlstra
2026-08-10 23:31 ` Jose Fernandez (Anthropic)
2026-08-10 23:38 ` John Stultz
2026-08-10 23:57 ` Sasha Levin
2026-08-11 0:11 ` John Stultz
2026-02-19 7:58 ` [PATCH v2 7/7] sched/fair: Use full weight to __calc_delta() Peter Zijlstra
2026-02-23 10:57 ` Vincent Guittot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=anksxhdkYBfcpJmN@linux.dev \
--to=jose.fernandez@linux.dev \
--cc=dietmar.eggemann@arm.com \
--cc=janne.huttunen@nokia.com \
--cc=jstultz@google.com \
--cc=kprateek.nayak@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=quzicheng@huawei.com \
--cc=sashal@kernel.org \
--cc=shubhang@os.amperecomputing.com \
--cc=stable@vger.kernel.org \
--cc=vincent.guittot@linaro.org \
--cc=willymontaz@gmail.com \
--cc=xuewen.yan@unisoc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox