From: Matthew Wilcox <willy@infradead.org>
To: Ayhan Aydin <nsd.project.dev@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Jan Kara <jack@suse.cz>,
linux-fsdevel@vger.kernel.org
Subject: Re: [RFC PATCH 0/3] Neural Storage Driver - learning page cache prefetcher
Date: Mon, 10 Aug 2026 04:13:12 +0100 [thread overview]
Message-ID: <anlByPDZmvEhWeXI@casper.infradead.org> (raw)
In-Reply-To: <CAFLp9PEQQVuDpJPwrNvLN1-u3w3TMwZPUUrf0+rOBrvDjBBf1A@mail.gmail.com>
On Sat, Aug 08, 2026 at 05:10:42PM -0400, Ayhan Aydin wrote:
> Following up on this RFC submitted on 20260725. I understand
> maintainer bandwidth is limited, so no urgency implied - just
> making sure this didn't fall through the cracks.
It absolutely did. It would probably help to cc the page cache
maintainers (Jan added) and the fsdevel people. You can find
this information in the MAINTAINERS file.
> For reference, the series adds an optional observation hook
> (CONFIG_NSD, default off, see PATCH 1/3) that does not bypass
> the existing ra_state / file_ra_struct machinery. All actual
> page insertion is still delegated to page_cache_sync_readahead().
> Benchmarks (interleaved ON/OFF methodology, i.e. same-machine A/B
> with repeated runs, SQLite full-table scans and buffered
> sequential I/O) showed an 18-19% wall-time reduction and
> +22.6% throughput improvement respectively.
>
> Happy to rework the approach, shrink the footprint, or
> re-parameterize the predictor if that would make review easier -
> just let me know what would help.
>
> Full series and docs:
> https://github.com/nsdprojectdev/NSD/tree/upstream-prep-v1
Let's call this a good proof of concept rather than a merge request ;-)
Architecturally, we're only hooking into the read path and ignoring the
page fault path. Was that a deliberate choice?
I haven't spent the time to do any detailed analysis of your code,
but it feels to me like we should be doing something more invasive
and integrated. It would be nice to replace the existing mechanism of
marking folios with PG_readahead, if that's possible. It'd be nice to be
able to detect backward access patterns as well as forward access patterns.
Let's have a conversation about what you're trying to do, and see where
we go next.
prev parent reply other threads:[~2026-08-10 3:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-25 18:26 [RFC PATCH 0/3] Neural Storage Driver - learning page cache prefetcher Ayhan Aydin
2026-07-25 18:26 ` [RFC PATCH 1/3] mm/filemap: Add NSD prefetch hook point Ayhan Aydin
2026-07-25 18:26 ` [RFC PATCH 2/3] nsd: Core prediction engine Ayhan Aydin
2026-07-25 18:26 ` [RFC PATCH 3/3] Documentation: Add NSD filesystem documentation Ayhan Aydin
2026-08-08 21:10 ` [RFC PATCH 0/3] Neural Storage Driver - learning page cache prefetcher Ayhan Aydin
2026-08-10 3:13 ` Matthew Wilcox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=anlByPDZmvEhWeXI@casper.infradead.org \
--to=willy@infradead.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nsd.project.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox