public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: torvalds@transmeta.com (Linus Torvalds)
To: linux-kernel@vger.kernel.org
Subject: Re: [patch] futex-2.5.40-B5
Date: Sat, 5 Oct 2002 00:42:28 +0000 (UTC)	[thread overview]
Message-ID: <anlchk$1d0$1@penguin.transmeta.com> (raw)
In-Reply-To: 3D9E2B8A.653BEF9D@tv-sign.ru

In article <3D9E2B8A.653BEF9D@tv-sign.ru>,
Oleg Nesterov  <oleg@tv-sign.ru> wrote:
>Hello.
>
>Ingo Molnar wrote:
>>   the new lookup code first does a lightweight follow_page(), then if no
>>   page is present we do the get_user_pages() thing.
>
>What if futex placed in VM_HUGETLB area?
>Then follow_page() return garbage.
>
>I beleive in i386 case it can be fixed something like this:

This will fix it for i386, but will break it for all other
architectures, as you're now depending on a x86-specific implementation
detail in an arch-independent file using a generic CONFIG test..

>Then follow_hugetlb_page() hook can be killed.

I'd much rather have a hook that works, than having #ifdef's in code
that don't..

		Linus

  reply	other threads:[~2002-10-05  0:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-10-05  0:00 [patch] futex-2.5.40-B5 Oleg Nesterov
2002-10-05  0:42 ` Linus Torvalds [this message]
  -- strict thread matches above, loose matches on Subject: below --
2002-10-05  0:53 Seth, Rohit
2002-10-02 18:14 Martin Wirth
2002-10-02 12:14 Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='anlchk$1d0$1@penguin.transmeta.com' \
    --to=torvalds@transmeta.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox