From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4CFAC3CE489 for ; Mon, 10 Aug 2026 12:07:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786363672; cv=none; b=nLUrYyms9ZpYbJp04R+2V/5YibQRs91GnUO01FmePhSiMXbrNB7wC1GpmuYczZSeCx/wtiD/43z/H4+uVnWtZ9pzI3Maqe8Tu+wREuK8UNFBFiIBA+pwUhUVeP8OQBqhxP4rMCDjKy4yaekd+IZWQ3PXh73ETCSDgwC/juoC09s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786363672; c=relaxed/simple; bh=scjJMhiwpdmG8YaFjygclHyYL/AYuaQnlgQbAdbfkN8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=aXBqHJzv5H/6ZYD50Du6VyaHnHABWzKNlefLxqITZpwhukHcrHkz794gg2ljU61CZfpPS/YZFHINmmAnK5EKyHAepSK9ROEmy84AMqNcVRsxbO/3gTvKF58Z5K5B2F/lcbQSyuvDjbGPoh8570HgtK8QdVsvyPegZNq9d9oY4w0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=YX6NkzhX; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="YX6NkzhX" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1786363670; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1O9Jc09STHTLztYZMK7mFGLDXk2yE45cxlFnbs5R4MY=; b=YX6NkzhXZMu9gtAjBXzqV6J70OKIxD9cvC/dPC5YH/3mK2Af1LlA89FpLT7Fws/k3tpEfa NcUCk4PBV+AyAZhAIEwiwpqlAQKL4Jl1FRrxvnNpxVUsadTn83YowxaxSXtM9lR8Z9YuBh oEbv1j/Nwq2WgoAJvxPC74yPB35gTwQ= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-456-xhg4jRSmOtWoNm7i3Zp9qg-1; Mon, 10 Aug 2026 08:07:44 -0400 X-MC-Unique: xhg4jRSmOtWoNm7i3Zp9qg-1 X-Mimecast-MFC-AGG-ID: xhg4jRSmOtWoNm7i3Zp9qg_1786363663 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 5B576195608F; Mon, 10 Aug 2026 12:07:42 +0000 (UTC) Received: from fedora (unknown [10.44.33.192]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with SMTP id 669DC180049F; Mon, 10 Aug 2026 12:07:35 +0000 (UTC) Received: by fedora (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Mon, 10 Aug 2026 14:07:41 +0200 (CEST) Date: Mon, 10 Aug 2026 14:07:33 +0200 From: Oleg Nesterov To: Joel Granados Cc: Mark Brown , Luis Chamberlain , Sudip Mukherjee , Alexander Viro , Christian Brauner , Jan Kara , Kees Cook , linux-kernel@vger.kernel.org Subject: Re: [PATCH sysctl-next 2/2] sysctl: remove redundant CONFIG_PROC_FS checks Message-ID: References: <3dr7rtndzf2zhdtyfea6x5k76ccczup5icxm6odrkcnicdz7hh@ftlaoeoq6sqk> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3dr7rtndzf2zhdtyfea6x5k76ccczup5icxm6odrkcnicdz7hh@ftlaoeoq6sqk> X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Hi Joel, On 08/10, Joel Granados wrote: > > On Fri, Aug 07, 2026 at 05:48:11PM +0200, Oleg Nesterov wrote: > > --- a/drivers/parport/procfs.c > > +++ b/drivers/parport/procfs.c > > @@ -26,9 +26,9 @@ > > > > #include > > > > -#if defined(CONFIG_SYSCTL) && defined(CONFIG_PROC_FS) > > +#ifdef CONFIG_SYSCTL > > > > -#define PARPORT_MIN_TIMESLICE_VALUE 1ul > > +#define PARPORT_MIN_TIMESLICE_VALUE 1ul > > Nit: Please remove the formatting changes from the series. Hmm. I replaced "#if defined(CONFIG_SYSCTL)" with "#ifdef CONFIG_SYSCTL" because the latter matches the rest of this file which uses "#ifdef", not "#if defined(...)" elsewhere... Plus I removed the extra whitespace after eol in the next line. What exactly you want me to revert in this cleanup? In any case, I'd be happy to send V2. But I am travelling without my work laptop, I can only do this when I return on Aug 19. Thanks! Oleg.