From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 52B283AE6EE for ; Mon, 10 Aug 2026 12:25:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786364709; cv=none; b=SLgn4VsMhul1z93C8/o0XOljmSjC/QLHcwbJZOJRTEillrljZFohubkduFumBwPiRboonp9CVfwAUc+RLk0g8AazwzCwYZcW50iCUhc2RbztnaL66Z9Qm29BMUxTfh6pFPBbfDHIP2IL4Onj6zYPtnK/7wtv8XvryryiKfPBi3I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786364709; c=relaxed/simple; bh=E5m0QDDeaPCceUdtMVoXh5/cBiPMcpwVgOkVvbEzlkQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hnbAe35tPLPGNe1cB8Wi9rjR46ImbTmrq1aCVLC0nT6Yl+UDwPCTT33y9nUFd1eTqFdpTxOyBsUy0/cRv8sldfAmTIP/06+61NNR9V6dHYIg1W90i4OkFlsyH7Shp+snF5RL5LKhUf7cO7TQ9l3yjOCBzkC6zoifwCfaxOgWkDA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=hU0dQHdr; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="hU0dQHdr" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1786364707; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3lz6lQvu7dTzAXhnoqSkw2HCkVQ9rUm+dvUEjC+6fAQ=; b=hU0dQHdrMrhoHqOZBk+1vBiHNy3nldKUK0t4+zcYqpnvyHK1F0sPRw6bTnmjbJb4BbKjd6 wMP54l7UMDSxCfwhqU0RTQisCP45f41Akmhc7RwKqOP51FcXgYzD5cF2+EkmU/AmWOuRzl rahaXpPZIgBMlgwDmZvx/fZHm7XBdas= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-502-Leqy-9t3OGmBI8IOWy85Kg-1; Mon, 10 Aug 2026 08:25:02 -0400 X-MC-Unique: Leqy-9t3OGmBI8IOWy85Kg-1 X-Mimecast-MFC-AGG-ID: Leqy-9t3OGmBI8IOWy85Kg_1786364701 Received: from mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.95]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 954C3180034C; Mon, 10 Aug 2026 12:25:00 +0000 (UTC) Received: from fedora (unknown [10.44.33.192]) by mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with SMTP id 8741B423; Mon, 10 Aug 2026 12:24:54 +0000 (UTC) Received: by fedora (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Mon, 10 Aug 2026 14:24:59 +0200 (CEST) Date: Mon, 10 Aug 2026 14:24:53 +0200 From: Oleg Nesterov To: Joel Granados Cc: Mark Brown , Luis Chamberlain , Sudip Mukherjee , Alexander Viro , Christian Brauner , Jan Kara , Kees Cook , linux-kernel@vger.kernel.org Subject: Re: [PATCH sysctl-next 1/2] sysctl: collapse redundant CONFIG_SYSCTL nesting in kernel/sysctl.c Message-ID: References: <6vgzwppmbvwbkiwzty3ki6ayqt6li7gr7nlurlp5ip6jyt7osu@wedlfafsqr6i> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6vgzwppmbvwbkiwzty3ki6ayqt6li7gr7nlurlp5ip6jyt7osu@wedlfafsqr6i> X-Scanned-By: MIMEDefang 3.6 on 10.30.177.95 On 08/10, Joel Granados wrote: > > This looks very nice, but now that you are there, I would propose an > additional change: > > 1. I would move the proc_do_static_key function and the definition of > the sysctl_subsys_table into the first CONFIG_SYSCTL definition > section; right after proc_do_large_bitmap > > 2. Doing one means that there is only one #ifdef CONFIG_SYSCTL > > 3. Add a proc_do_static_key stub to the #else section; something like > this: > > int proc_do_static_key(const struct ctl_table *table, int dir, > void *buffer, size_t *lenp, loff_t *ppos) > { > return -ENOSYS; > } Yeees, and I thought about this too ;) Just I decided to send the minimal and trivial cleanup. Except right now I am not 100% sure about 3. because I can't read the source code now... Again, I'd be happy to send V2, but only after I return from PTO on Aug 19. But let me ask... Do you want me to incorporate this additional change into 1/2 or send it as a separate change? I'd prefer the latter, but I am fine either way. Oleg.