From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F32803DA7F1 for ; Mon, 10 Aug 2026 12:52:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786366340; cv=none; b=aDwbDKuVIzBWdkvHqBQxyGU+faLliYV+j4L99bDXGbRQ5QL1i7O1DyKuRsbhwu0aqyJsvvKxzlKiuFxjV7CxeVKeGW5v6AcA/W/1YJWKNRY1pWK1KQrLgC6yQNJpKCjyBewwysJcX0pbtmYEk6NwDeZR3QyfHRJMY/YJHLZUNbY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786366340; c=relaxed/simple; bh=nEJymaMsrAAyBpyX6lA7DTayQj6oLeCahMRPSliXZJo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=MKbbp7KO3RZBcvfuYYwqWlkRWA9FX/ORXHnzmKhIQdx8ClgEuqGKNZESWlBuIrNATqMAKWjXWreXnnGwehRkT/2fEO2JICInTjdMcSbxtSTpuVtZYf8MMuA4sJrT0YzOusULGK9M3oaHyHPjN8uuAR9xqTigvzD2a2L0QVr3Z4U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=nZG9u+U7; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="nZG9u+U7" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E9A771F000E9; Mon, 10 Aug 2026 12:52:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1786366338; bh=jbD/rTHo7/v1amDtY7hLsVEcn/yHEghOpUSa0XJOkxw=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=nZG9u+U7KkQ4c8ScD9xDDMw8j/kCNz46rhPFgbXjFYThsL/p51E19Amxl72vNHrrt rhStaQJ4k1eolxGnmNAnsYhJ4nM9pF1BINoowmoyS46b1rNZcz79x3U1Q+5Y9nRs3h 5JzE8BtBcDOKXzMpBru7H/iicDGOFCeaYoYeKgLCgCtOU3ge84pS8yw1oGD5iT9p3k wORwD/+q0NMY1LzWV9K3CwlMdI5zC7Ms16trHFmIfRW6YtNSz+zmQ2PHaRXvwRzT/X NWVnhwzTFGfUrAuMDaO4o0abYOhx58XAS4ZGmfhTi5vpBSDZOlaGblU4/sAWg5gE8h ngTpBX+0WyMIw== Date: Mon, 10 Aug 2026 13:51:58 +0100 From: "Lorenzo Stoakes (ARM)" To: "David Hildenbrand (Arm)" Cc: Tal Zussman , Matthew Wilcox , Andrew Morton , Chris Li , Kairui Song , Kemeng Shi , Nhat Pham , Baoquan He , Barry Song , Youngjun Park , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Christoph Hellwig , Johannes Weiner , Yosry Ahmed , Chengming Zhou , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/6] mm: remove PageReclaim Message-ID: References: <20260806-b4-page_io-folios-v1-0-0899bac3b826@columbia.edu> <20260806-b4-page_io-folios-v1-2-0899bac3b826@columbia.edu> <1b688500-230a-4733-99da-bdd8adc9f67b@columbia.edu> <1439da90-292c-4075-82ce-32cb89505db3@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1439da90-292c-4075-82ce-32cb89505db3@kernel.org> On Mon, Aug 10, 2026 at 01:38:21PM +0200, David Hildenbrand (Arm) wrote: > On 8/7/26 21:27, Tal Zussman wrote: > > On 8/7/26 2:48 PM, Matthew Wilcox wrote: > >> On Thu, Aug 06, 2026 at 06:55:34PM -0400, Tal Zussman wrote: > >>> This flag is now only used on folios, so we can remove all the page > >>> accessors. > >> > >> And we don't use folio_test_clear_reclaim() at all (it's mentioned in > >> a comment, but that's it), so we can drop that line entirely. > >> > > > > Aha, I missed that - even better. > > > >>> -PAGEFLAG(Reclaim, reclaim, PF_NO_TAIL) > >>> - TESTCLEARFLAG(Reclaim, reclaim, PF_NO_TAIL) > >>> +FOLIO_FLAG(reclaim, FOLIO_HEAD_PAGE) > >>> + FOLIO_TEST_CLEAR_FLAG(reclaim, FOLIO_HEAD_PAGE) > >> > >> With that last line removed, > >> > >> Reviewed-by: Matthew Wilcox (Oracle) > > Thanks > > Acked-by: David Hildenbrand (Arm) Nice! With Matthew's suggestion applied LGTM so: Reviewed-by: Lorenzo Stoakes (ARM) > > -- > Cheers, > > David -- Cheers, Lorenzo