From: Boqun Feng <boqun@kernel.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: "Ingo Molnar" <mingo@kernel.org>, "Will Deacon" <will@kernel.org>,
"Waiman Long" <longman@redhat.com>, "Gary Guo" <gary@garyguo.net>,
"Alice Ryhl" <aliceryhl@google.com>,
"Lyude Paul" <lyude@redhat.com>,
"Daniel Almeida" <daniel.almeida@collabora.com>,
"Onur Özkan" <work@onurozkan.dev>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Danilo Krummrich" <dakr@kernel.org>,
linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org,
"Shrikanth Hegde" <sshegde@linux.ibm.com>,
"Madhavan Srinivasan" <maddy@linux.ibm.com>,
"Christophe Leroy (CS GROUP)" <chleroy@kernel.org>
Subject: Re: [PATCH v5 17/18] rust: sync: Add SpinLockIrq
Date: Mon, 10 Aug 2026 06:21:00 -0700 [thread overview]
Message-ID: <annQPL7XfXzLLpnQ@tardis.local> (raw)
In-Reply-To: <20260810090213.GG1642880@noisy.programming.kicks-ass.net>
On Mon, Aug 10, 2026 at 11:02:13AM +0200, Peter Zijlstra wrote:
> On Fri, Aug 07, 2026 at 12:02:14AM -0700, Boqun Feng wrote:
>
> > -pub use lock::spinlock::{new_spinlock, SpinLock, SpinLockGuard};
> > +pub use lock::spinlock::{
> > + new_spinlock,
> > + new_spinlock_irq,
> > + SpinLock,
> > + SpinLockGuard,
> > + SpinLockIrq,
> > + SpinLockIrqGuard, //
> > +};
>
> What's this new_spinlock* stuff about? It has sensible naming; unlike
> that CameCase nonsense the rest has.
They're the counter part of *spin_lock_init() in C side, similar as C,
they need to macros to expand at callsite for lock class key generation.
Types and Traits use CameCase, and macros and functions use snake_case.
Regards,
Boqun
next prev parent reply other threads:[~2026-08-10 13:21 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-07 7:01 [PATCH v5 00/18] Refcounted interrupt disable and SpinLockIrq for Rust Boqun Feng
2026-08-07 7:01 ` [PATCH v5 01/18] preempt: Track NMI nesting to separate per-CPU counter Boqun Feng
2026-08-07 7:01 ` [PATCH v5 02/18] preempt: Introduce HARDIRQ_DISABLE_BITS Boqun Feng
2026-08-07 7:02 ` [PATCH v5 03/18] preempt: Introduce __preempt_count_{sub,add}_return() Boqun Feng
2026-08-07 7:02 ` [PATCH v5 04/18] openrisc: Include <linux/cpumask.h> in smp.h Boqun Feng
2026-08-07 7:02 ` [PATCH v5 05/18] irq & spin_lock: Add counted interrupt disabling/enabling Boqun Feng
2026-08-07 7:02 ` [PATCH v5 06/18] irq: Add KUnit test for refcounted interrupt enable/disable Boqun Feng
2026-08-07 7:02 ` [PATCH v5 07/18] irq: Add max local_interrupt_disable() nesting level kunit test case Boqun Feng
2026-08-07 7:02 ` [PATCH v5 08/18] locking: Switch to _irq_{disable,enable}() variants in cleanup guards Boqun Feng
2026-08-07 7:02 ` [PATCH v5 09/18] sched: Remove the unused preempt_offset parameter of __cant_sleep() Boqun Feng
2026-08-07 7:02 ` [PATCH v5 10/18] sched: Avoid signed comparison of preempt_count() in __cant_migrate() Boqun Feng
2026-08-07 7:02 ` [PATCH v5 11/18] preempt: Introduce HAS_SEPARATE_PREEMPT_RESCHED_BITS Boqun Feng
2026-08-07 7:02 ` [PATCH v5 12/18] arm64: sched/preempt: Enable HAS_SEPARATE_PREEMPT_RESCHED_BITS Boqun Feng
2026-08-07 7:02 ` [PATCH v5 13/18] s390/preempt: " Boqun Feng
2026-08-07 7:02 ` [PATCH v5 14/18] rust: Introduce interrupt module Boqun Feng
2026-08-10 8:57 ` Peter Zijlstra
2026-08-10 13:28 ` Boqun Feng
2026-08-07 7:02 ` [PATCH v5 15/18] rust: helper: Add spin_{un,}lock_irq_{enable,disable}() helpers Boqun Feng
2026-08-07 7:02 ` [PATCH v5 16/18] rust: sync: Use super::* in spinlock.rs Boqun Feng
2026-08-07 7:02 ` [PATCH v5 17/18] rust: sync: Add SpinLockIrq Boqun Feng
2026-08-10 9:02 ` Peter Zijlstra
2026-08-10 13:21 ` Boqun Feng [this message]
2026-08-07 7:02 ` [PATCH v5 18/18] rust: sync: Introduce SpinLockIrq::lock_with() and friends Boqun Feng
2026-08-10 8:52 ` [PATCH v5 00/18] Refcounted interrupt disable and SpinLockIrq for Rust Peter Zijlstra
2026-08-10 8:53 ` Peter Zijlstra
2026-08-10 9:30 ` Peter Zijlstra
2026-08-10 10:38 ` Gary Guo
2026-08-10 10:49 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=annQPL7XfXzLLpnQ@tardis.local \
--to=boqun@kernel.org \
--cc=aliceryhl@google.com \
--cc=chleroy@kernel.org \
--cc=dakr@kernel.org \
--cc=daniel.almeida@collabora.com \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=lyude@redhat.com \
--cc=maddy@linux.ibm.com \
--cc=mingo@kernel.org \
--cc=ojeda@kernel.org \
--cc=peterz@infradead.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=sshegde@linux.ibm.com \
--cc=will@kernel.org \
--cc=work@onurozkan.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox