From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-171.mta0.migadu.com (out-171.mta0.migadu.com [91.218.175.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 481853E49E2 for ; Mon, 10 Aug 2026 13:58:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786370289; cv=none; b=Vdyl2ZNkBf1IIiwK2PbX+Suy14eCEcoVQxxCgeb8aB42F8FjYO90dodzittfASawhEhC/m8Zvhwu6RQ5HDjCOzT/e8XG5NfS0vd/x/X/CCN6UafxdcUgSsCk/RWj0Q9jexFM6RIF6+fKHr/lqGXLuV9gD4mYOQROEzgzXXwGwQQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786370289; c=relaxed/simple; bh=P3ElBCkzWuc99gloyCOJnm+vQAeN76uqoLjv9hsu4WI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=qBCoG58YokneB2xds/XjxJjA690MTMNBzBgiTFAzb3QRs3A63NFyLATysDaxrmg8+1TNIJfERjxQDApmXehF3HN+KQxo9rHCnJhRBfJtxLjlOa2q/TrV+NhDb3as2oMYp5QrNJQFPYW9a4pyinZxr9Rg3DrCEkTpJsUwhnX7E2Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=d6z8bN83; arc=none smtp.client-ip=91.218.175.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="d6z8bN83" Date: Mon, 10 Aug 2026 21:57:17 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1786370283; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=t3Riv+5rPDV6KFEq+Vw56GeReZzkvlR+Ay7FSGDr5ic=; b=d6z8bN8337pzDzF/FPmdkUnsvVcxmZhZ8ME1meFPQsMgUw+fxf/ncSsNXN2MwYYspXCWNL vBGBqHuA8kr3YjQKNbxMLI2mFXEBJPCq1EsJpS7IZzxEmwET5hPlyRpp3VGGk4Sr2INOIR +yKFwg9fZnr/gfWhyQIBv5mVIvaeUHk= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Chen Yu To: Zhan Xusheng Cc: Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Mel Gorman , Dietmar Eggemann , Steven Rostedt , Ben Segall , Valentin Schneider , K Prateek Nayak , zhanxusheng@xiaomi.com, linux-kernel@vger.kernel.org, yu.c.chen@intel.com Subject: Re: [PATCH] sched/debug: Validate writes to the scan_size_mb debugfs knob Message-ID: References: <20260810081829.3149958-1-zhanxusheng@xiaomi.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260810081829.3149958-1-zhanxusheng@xiaomi.com> X-Migadu-Flow: FLOW_OUT On Mon, Aug 10, 2026 at 04:18:29PM +0800, Zhan Xusheng wrote: > +static ssize_t sched_numa_scan_size_write(struct file *filp, > + const char __user *ubuf, > + size_t cnt, loff_t *ppos) > +{ > + unsigned int mb; > + int ret; > + > + ret = kstrtouint_from_user(ubuf, cnt, 10, &mb); > minor ret = kstrtouint_from_user(ubuf, cnt, 0, &mb)? The debugfs_create_u32() path being replaced parses with base 0 via kstrtoull(attr->set_buf, 0, &val) in simple_attr_write_xsigned(), so base 10 makes writes like "echo 0x100 > scan_size_mb" return -EINVAL. Others look ok to me, with above fix, per my knowledge, Reviewed-by: Chen Yu thanks, Chenyu