From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E1C942847B for ; Mon, 10 Aug 2026 23:05:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.200 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786403124; cv=none; b=tbVSiOScYeA+g3C1l8lN3Y4DuLQ4qz1kUfckSxi23jtn6B4sXit0ArH0Uv9sVrPqe5K9FCTr1tbW08LiPnxFcXdnBI3j8fmtAb4FyOvRrT/4GstCFAFlTb/XkHpRGNL+lvE3lp0vUM009i+GpXFiWhBeEICSp6Oinv1zvves6sk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786403124; c=relaxed/simple; bh=1UixVDhcKktfLAVV3KH2xdxG9X17YLjD04ZwlUbLKmA=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=f18d/RYHoLWM0NAxoXpIY4eMEw4yV55HjEgmL/2FrG4XIvU4SYW3OdVvUknqU/kZLPhBjRk7fGcKkJKKhopeEXgk2/TDvPOCcaBzAqFT+6nll221QsVPU8ZT0Av0LDV2jddjvK5JKUIx7Xo+7ozdqZOYuM6L96ExK6D4zsc9kzs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=in7jiRgQ; arc=none smtp.client-ip=209.85.210.200 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="in7jiRgQ" Received: by mail-pf1-f200.google.com with SMTP id d2e1a72fcca58-84857446424so4157835b3a.1 for ; Mon, 10 Aug 2026 16:05:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1786403122; x=1787007922; darn=vger.kernel.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=/9OrpqxZWhRM/HFUiR8JGN523y//wB+NGc5onZ0jOJQ=; b=in7jiRgQ4y4nSlP2ti2hlC4pWj0ssxrD7VlSOSQ23O2AZZQPOoPApx0AdVZ/KZiZaS vCKgfCLVcQx/CuPJcA4oe/2eL1Zq1v5jKF+38D+z616QAHspIus7C112/8NhLZw5+YWV 8CShGUyObkww6pRdQA4+yRq9hgAGA58FWXz5A78WNhXfjQ/n6tNYqGRk9z8qVsJWXFnK wrqf/eC7+2BXcxX51uqLYJU2BFug4zyTSJG6EupkLav4U1ouCL2xQlDVnNrQTTqKhqH/ Zzb0f5a97+Ng0zfpv8udzvIKiU8KI+CfOd5qSYz3eKw9umlbP8N7i7dPpW3u8Lky0etc qGOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786403122; x=1787007922; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=/9OrpqxZWhRM/HFUiR8JGN523y//wB+NGc5onZ0jOJQ=; b=d+68QUZRmkx7cLwLnEPmHTwInR82aLRBKfeXo0a4oPn4lNOFNH7EVE3JBMtDq+NK3F N2QvexxQblpNjUMY3uD7sa2MpRA6B1PfpTRGFs3SVubVuwB9mwOvj0ymUxUi6KXKL4VS d0rO1IEKbg9dDOqOiPKkXsBotd7RmYTcqEkfWlIXUXkXqES6W8+1mxYUN+GfM6V2KZ8J RoGJe+28N61RelEjXqBhFyykBMoEgDKnenZOQ1NPgoeeED+A6tY0hQ1QwmuuLuKN8Be6 52+dcaUsCmLY586p5QNbWrU3X27xOl8TjD9R0JDQApZx9CufNrNHB/0ID0OFzMsBAowo SrWg== X-Forwarded-Encrypted: i=1; AHgh+RrTgWb2vtqrWNQtKNrkWrO97lzSN5tVy/hMgg/wr8cp+1yqgFQ7UlHIlIx1ZHePZCjVzF7qgudoEU+jKqk=@vger.kernel.org X-Gm-Message-State: AOJu0YzCYvCOR//c1QdOgLZyjzkqrS/pm/EdWvyO57NUYDlMxOijzXwb cn0L5I3OPXzifL8p2H7RMp+wmJI6MwK85R5Low2RtmoYr0EjZqdFBYEn8XJMJqIpa84SQZg7uyp Crb27ig== X-Received: from pfnv2.prod.google.com ([2002:aa7:8502:0:b0:847:7765:a4c3]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:420c:b0:848:2f2c:b2c8 with SMTP id d2e1a72fcca58-84f9c95f809mr5850968b3a.24.1786403121703; Mon, 10 Aug 2026 16:05:21 -0700 (PDT) Date: Mon, 10 Aug 2026 16:05:21 -0700 In-Reply-To: <20260728121138.1103610-3-tarunsahu@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260728121138.1103610-1-tarunsahu@google.com> <20260728121138.1103610-3-tarunsahu@google.com> Message-ID: Subject: Re: [PATCH v4 02/11] KVM: Introduce kvm_create_vm_file() helper From: Sean Christopherson To: Tarun Sahu Cc: ackerleytng@google.com, fuad.tabba@linux.dev, Andrew Morton , dmatlack@google.com, Shuah Khan , Jonathan Corbet , david@redhat.com, Pasha Tatashin , Pratyush Yadav , sagis@google.com, Paolo Bonzini , Mike Rapoport , Alexander Graf , linux-kselftest@vger.kernel.org, andre.przywara@arm.com, michael.roth@amd.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, will@kernel.org, vannapurve@google.com, maz@kernel.org, fvdl@google.com, kvm@vger.kernel.org, oliver.upton@linux.dev, kvmarm@lists.linux.dev, alexandru.elisei@arm.com, skhawaja@google.com, aneesh.kumar@kernel.org, linux-doc@vger.kernel.org, David Hildenbrand , yan.y.zhao@intel.com, kexec@lists.infradead.org, suzuki.poulose@arm.com Content-Type: text/plain; charset="us-ascii" On Tue, Jul 28, 2026, Tarun Sahu wrote: > - Move ITOA_MAX_LEN to kvm_mm.h for reuse by upcoming kvm_luo code. > - Introduce kvm_create_vm_file() to wrap kvm_create_vm() and > anon_inode_getfile(), providing a unified VM file creation API. As Ackerley pointed out, changelogs that are literally a list pretty much always needs to be split. These also need to explain *why*. "providing a unified VM file creation API" isn't sufficient justification. In general, all of these changelogs need to provide more of the "why"; I can figure out what the patches are doing easily enough, but in my speed read of the series, it's hard to figure out the "why".