From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-171.mta1.migadu.com (mta1.migadu.com [37.59.57.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB73137B016 for ; Mon, 10 Aug 2026 23:32:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=37.59.57.117 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786404723; cv=none; b=lIiyLpYpCO5bpSaVtfPwrDhzEJJ3QA3fM/UHt4JyqlgzCUszm1L6/QoASWtSnFTP/W+0+l0arRcxvMLLzNyh6Y2mzfp2h3s8AOp2cDTZ4EYrV2jzNc7jaxHIapqVzYldHb/SaGl9rGf1cp4UQqz6/jZE/lnL4Q7vvDe3yUGn3pU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786404723; c=relaxed/simple; bh=mtdk4PdCGzfXjtebI3yvexVP78xJ1WnS7QktGMK5WDI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=rPK2/K5pf4eSFUs8MpkqNPe8dzSHnRBzJYhki0i5tlM2YuDD9TEWN7254sFnMzHWiP9cDSWDmw+fPWFAXoOGUyutcMQ54Vg1rJjbE2JZSGzj24xfAavho+KVrfZL9wyu1iyyqYtnd9tbsJbxomIudusPglp2hmU6+h2YOCEW49A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=bAoGdgLq; arc=none smtp.client-ip=37.59.57.117 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="bAoGdgLq" Date: Mon, 10 Aug 2026 23:31:34 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1786404719; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mtdk4PdCGzfXjtebI3yvexVP78xJ1WnS7QktGMK5WDI=; b=bAoGdgLqKPs4RmrfYj7UjV5IDIbN0Mi7q9W/lgRTAfbDZRZV7GDKpk9L4iStBySlia+NRw JRbs5tXMZoMbAgxsb6XaCa8XB4OGqagcuBixKAkJdobAGP4EJThni5Mogr3eHwGKo+D4uM gCdGtNxZEfJcjjyNEgNaIzY5KKC4+Do= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: "Jose Fernandez (Anthropic)" To: Peter Zijlstra Cc: John Stultz , stable@vger.kernel.org, linux-kernel@vger.kernel.org, Sasha Levin , Ingo Molnar , Janne Huttunen , Zicheng Qu , Vincent Guittot , K Prateek Nayak , Shubhang Kaushik , Dietmar Eggemann , Xuewen Yan , William Montaz Subject: Re: [PATCH 6.18] sched/fair: Revert 6d71a9c61604 ("sched/fair: Fix EEVDF entity placement bug causing scheduling lag") Message-ID: References: <20260324100126.3502-1-willymontaz@gmail.com> <20260415211149.2658910-1-jstultz@google.com> <20260810073830.GC1642880@noisy.programming.kicks-ass.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260810073830.GC1642880@noisy.programming.kicks-ass.net> X-Migadu-Flow: FLOW_OUT On Mon, Aug 10, 2026 at 09:38:30AM +0200, Peter Zijlstra wrote: > Yeah, this should be fine without 4823725d9d1d. One heads up, our review tooling caught this after I sent the Tested-by. The revert was written after commit 80390ead2080 ("sched/fair: Separate se->vlag from se->vprot") took vlag and vprot out of their union, and 6.18 still has the union. Without that split first, the rel_vprot path in the new reweight_entity() scales vlag twice and curr's vruntime comes out wrong.