From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9A1EC3AF641 for ; Tue, 11 Aug 2026 02:52:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786416751; cv=none; b=rYxKc3e7jTjyDIZYmjID73YzbWgM4xti2/WCwnyf5bvraN09BE8p2sfoqIje9X5N/bL9xpFEG4VP+wIsXHmXYTimLGn2a9uLJ0IMSmyp9Qoq22PytwCg37ahFCi+j9TpAotyy9SGmq2MPPHnjGbFEaXKscmQjBA9gjwkEfFxbZs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786416751; c=relaxed/simple; bh=0IscgedchI9BJy7QbrwxadAAWxb8n2vhH5gbcC78QRM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=SSGXNFn3rBf787Fgz9eqZ4SGpENx/yeXIeKqIdRY3p5mSalvdKXHDkqPx+00fxcMpVlnYHPiJ2wC4FHIWE8esjLxP+Y0J+9w9vNW/cxobSYiHjsQO1JHxjAgjQ1V+jaNZDf/BE03s9gMBb0JJPXQtLlRrsxuXFsNRUj2iUL4jfg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=VMhsq5Zo; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="VMhsq5Zo" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-2cacef7d299so34815ad.1 for ; Mon, 10 Aug 2026 19:52:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1786416750; x=1787021550; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=KlMDdm+B2EaxfaUcyx6RsnklG/EbEhLErUiBZudsKCo=; b=VMhsq5Zo1lig8clVdCJ04/ZI/VHbIDFRxYzBvDdsl8urFicAdRycuCNl0iViyL/NA7 IstvWpbmWEpaqoyRy9AoXMqRecSMzCHEWf1JybB6sK4Xg2/a6lHNr7u2eGyU5yW7F1/H YEAn+kM25BkxrPkj7S2RE4V8yKoRElEjFS8PVhONpTk+QU5QVeIbdQqvMAGgXUTz/gzl DqSvjq5aM/hKf2J4UEi1eRsFltGovZkPTqIcM+3NMlnhZw3FfYQGWSqm0jD+wpuiULWQ 5w7VeK+94q/yz1BlgZe9tEc4ByBFm943okFlHmO+pQxTCgIUAgh609GGXWGiP9clUHXM voVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786416750; x=1787021550; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=KlMDdm+B2EaxfaUcyx6RsnklG/EbEhLErUiBZudsKCo=; b=W9OaK0j1gjl/bALXlwSvsIcTy2KvbqyoQLxez1VRA12N5BvKSzT5DVmjGQvo/guGlV iYdDCkGXyEq2GETeh2CLSun41vzvR3GZT+Xe1jGWYFJxz5fzfTU154gfwwD5wi9D/UH+ wcjfqWbJbzSSfkYdHlajD5cSt4rmg5C1shdFXdi6sKizZF+S6k/oQFcsM/l91Vj8FBhC XAiE29lOLanRrj05Go+CITr39iht7EAkhFTbEHltmBFjzcf8pngYf1dDGQ1iJymJV5nc CYyQnxkioZge0izruCoai6T6z7C4Jzqvc+aA8xvl+2DTbESJtZDn4u0X77PTrqxVOl2/ uaqA== X-Forwarded-Encrypted: i=1; AHgh+RqvEHOcCc8oYKlV1SafjDn0gRfUXOo3sSEequV07kPTF8WhinDTwE984NSgpmXkDtA+BosUVIbgD744qnM=@vger.kernel.org X-Gm-Message-State: AOJu0Yz5BqdU1TmEw6NjkVXbKoPRjF2eHQaiDWmk8KlpWYGMv2NGPtUp Im1PgbOoUB4KyEIlLf0SmF4pgd3WBBdBTq6mlX78X4KqpwTkOYLF5LGexbgFlCTATpL1EumHZUa mszGhpg== X-Gm-Gg: AR+sD12RXV/9LaCafFUTWGX9KmbTOdVArKoH+sz7I3ohxg4zdtPs19jhemg8+r4Y8DY TMD1hEV1B//mV5brT7DC3/I90mJ7dN7GeHmqA/FvPDbYoJ9n8uiasp+Wlpe1EGHZ5/QiEie76Po 15VVmI4SxC3kX/6ofZix9FPkGXtcYN4PXZ+VxamkoSeFqRJmNLqsSbWhBgaJh3qqOdNRPLRfvJg rSgIz7sBS7y9dKdvbuFPVc+sbycanDOOCFcKexay41b6JYgsiQLIPTJQQQw/FKiOYFPHMD6MN8h 12Ds7ohwIQ5rMuq4qeU/17VyP6AEfEwDQBfN8DrG2zpdsih80zVrc0FXW+VGHPm5Q1ZCkvK3W32 V5IoWy3Xzgd8TGOc9hSjwX+P+kyLbO+lPzliDcCuk7xTNJzAQb13Y+WjDqLlJomyaQenwMW27jf iNhTLxf2lkxU7gnms4cy+inx3WJtFdY/0CAY4C611glfojvcE0PVaYEMUt9JWTPu6oXQRQAVVC0 pQtnkDSf51vw5CsQU6k+aFpHCUtE9+GvZSuTJaec9VfoDhzo3E/LtaP4m5/tj9IWJrcGrOuLFYJ IvKPBxpPeJDJ X-Received: by 2002:a17:902:ef51:b0:2ca:e0ff:eaa0 with SMTP id d9443c01a7336-2d3171e0292mr453925ad.2.1786416749481; Mon, 10 Aug 2026 19:52:29 -0700 (PDT) Received: from google.com (193.67.125.34.bc.googleusercontent.com. [34.125.67.193]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-392d51c333bsm1670113a91.8.2026.08.10.19.52.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Aug 2026 19:52:28 -0700 (PDT) Date: Tue, 11 Aug 2026 02:52:24 +0000 From: Carlos Llamas To: Chao Huang <958028483@qq.com> Cc: Alice Ryhl , Greg Kroah-Hartman , Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Todd Kjos , Christian Brauner , linux-kernel@vger.kernel.org, Chao Huang Subject: Re: [PATCH v3] binderfs: free minor on binder-control creation failure Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Aug 11, 2026 at 09:05:34AM +0800, Chao Huang wrote: > From: Chao Huang > > Both binderfs_binder_ctl_create() implementations allocate a minor before > creating the binder-control dentry. If d_alloc_name() fails, the error path > frees the device and drops the inode, but leaves the minor allocated in > binderfs_minors. Repeated failures can therefore exhaust the global minor > IDA. > > Release the minor from a dedicated error path after a successful allocation > in both implementations. > > Signed-off-by: Chao Huang > --- > Changes in v3: > - Use a dedicated out_with_minor error path instead of an -ENOSPC sentinel. > > drivers/android/binder/rust_binderfs.c | 7 ++++++- > drivers/android/binderfs.c | 7 ++++++- > 2 files changed, 12 insertions(+), 2 deletions(-) > > diff --git a/drivers/android/binder/rust_binderfs.c b/drivers/android/binder/rust_binderfs.c > index ade1c4d92499..0763e3db54bd 100644 > --- a/drivers/android/binder/rust_binderfs.c > +++ b/drivers/android/binder/rust_binderfs.c > @@ -421,7 +421,7 @@ static int binderfs_binder_ctl_create(struct super_block *sb) > > dentry = d_alloc_name(root, "binder-control"); > if (!dentry) > - goto out; > + goto out_with_minor; > > inode->i_private = device; > info->control_dentry = dentry; > @@ -430,6 +430,11 @@ static int binderfs_binder_ctl_create(struct super_block *sb) > > return 0; > > +out_with_minor: > + mutex_lock(&binderfs_minors_mutex); > + ida_free(&binderfs_minors, minor); > + mutex_unlock(&binderfs_minors_mutex); > + > out: > kfree(device); > iput(inode); > diff --git a/drivers/android/binderfs.c b/drivers/android/binderfs.c > index 361d69f756f5..0e96146ecf69 100644 > --- a/drivers/android/binderfs.c > +++ b/drivers/android/binderfs.c > @@ -431,7 +431,7 @@ static int binderfs_binder_ctl_create(struct super_block *sb) > > dentry = d_alloc_name(root, "binder-control"); > if (!dentry) > - goto out; > + goto out_with_minor; > > inode->i_private = device; > info->control_dentry = dentry; > @@ -440,6 +440,11 @@ static int binderfs_binder_ctl_create(struct super_block *sb) > > return 0; > > +out_with_minor: > + mutex_lock(&binderfs_minors_mutex); > + ida_free(&binderfs_minors, minor); > + mutex_unlock(&binderfs_minors_mutex); > + > out: > kfree(device); > iput(inode); > > base-commit: c21bb4193868a8de71fc4693fa741e195fdf5d86 > -- > 2.25.1 > LGTM, Acked-by: Carlos Llamas