From: "Uwe Kleine-König" <ukleinek@kernel.org>
To: Francis Laniel <laniel_francis@privacyrequired.com>
Cc: "Michal Wilczynski" <m.wilczynski@samsung.com>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Benno Lossin" <lossin@kernel.org>, "Gary Guo" <gary@garyguo.net>,
"Alexandre Courbot" <acourbot@nvidia.com>,
"Boqun Feng" <boqun@kernel.org>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Danilo Krummrich" <dakr@kernel.org>,
linux-pwm@vger.kernel.org, rust-for-linux@vger.kernel.org,
linux-kernel@vger.kernel.org, tools@kernel.org
Subject: Re: [PATCH v3] rust: pwm: replace `core::mem::zeroed` with `pin_init::zeroed`
Date: Tue, 11 Aug 2026 07:04:49 +0200 [thread overview]
Message-ID: <anqsTVj5QGYGiEQ9@monoceros> (raw)
In-Reply-To: <20260603160910.159307-1-laniel_francis@privacyrequired.com>
[-- Attachment #1: Type: text/plain, Size: 2963 bytes --]
Hello,
On Wed, Jun 03, 2026 at 07:09:09PM +0300, Francis Laniel wrote:
> All types in `bindings` implement `Zeroable` if they can, so use
> `pin_init::zeroed` instead of relying on `unsafe` code.
>
> If this ends up not compiling in the future, something in bindgen or on
> the C side changed and is most likely incorrect.
>
> Suggested-by: Benno Lossin <lossin@kernel.org>
> Link: https://github.com/Rust-for-Linux/linux/issues/1189
> Reviewed-by: Alexandre Courbot <acourbot@nvidia.com>
> Acked-by: Michal Wilczynski <m.wilczynski@samsung.com>
> Signed-off-by: Francis Laniel <laniel_francis@privacyrequired.com>
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/ukleinek/linux.git pwm/for-next
for the 7.3 merge window.
b4 behaved strange on that patch:
$ b4 am -s -l -t -3 20260603160910.159307-1-laniel_francis@privacyrequired.com
Grabbing thread from lore.kernel.org/all/20260603160910.159307-1-laniel_francis@privacyrequired.com/t.mbox.gz
Analyzing 2 messages in the thread
Looking for additional code-review trailers on lore.kernel.org
Analyzing 23 code-review messages
Checking attestation on all messages, may take a moment...
---
✓ [PATCH v3] rust: pwm: replace `core::mem::zeroed` with `pin_init::zeroed`
+ Link: https://patch.msgid.link/20260603160910.159307-1-laniel_francis@privacyrequired.com
+ Signed-off-by: Uwe Kleine-König <ukleinek@kernel.org>
---
✓ Signed: DKIM/privacyrequired.com
---
Total patches: 1
---
NOTE: some trailers ignored due to from/email mismatches:
! Trailer: Suggested-by: Benno Lossin <lossin@kernel.org>
Msg From: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
! Trailer: Acked-by: Michal Wilczynski <m.wilczynski@samsung.com>
Msg From: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
! Trailer: Signed-off-by: Francis Laniel <laniel_francis@privacyrequired.com>
Msg From: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
! Trailer: Reviewed-by: Alexandre Courbot <acourbot@nvidia.com>
Msg From: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
NOTE: Rerun with -S to apply them anyway
Preparing fake-am for v3: rust: pwm: replace `core::mem::zeroed` with `pin_init::zeroed`
range: 2707b9df955d..81c3f2b030a1
Preared a fake commit range for 3-way merge (2707b9df955d..81c3f2b030a1)
---
Link: https://patch.msgid.link/20260603160910.159307-1-laniel_francis@privacyrequired.com
Base: applies clean to current tree
git checkout -b v3_20260603_laniel_francis_privacyrequired_com HEAD
git am -3 ./v3_20260603_laniel_francis_rust_pwm_replace_core_mem_zeroed_with_pin_init_zeroed.mbx
I didn't research what went wrong there and the trailer made it into the
patch anyhow and adding -S doesn't change the patch. I added the
tools@k.o mailing list to Cc:, maybe someone there wants to debug that.
Best regards and thanks for your contribution,
Uwe
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-08-11 5:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20260603160927eucas1p1ae24e871a8ef0771d72fae6462d96318@eucas1p1.samsung.com>
2026-06-03 16:09 ` [PATCH v3] rust: pwm: replace `core::mem::zeroed` with `pin_init::zeroed` Francis Laniel
2026-07-27 11:15 ` Michal Wilczynski
2026-08-11 5:04 ` Uwe Kleine-König [this message]
2026-08-11 20:54 ` Konstantin Ryabitsev
2026-08-11 21:00 ` Miguel Ojeda
2026-08-11 21:17 ` Konstantin Ryabitsev
2026-08-11 22:13 ` Miguel Ojeda
2026-08-11 22:56 ` Uwe Kleine-König
2026-08-11 23:01 ` Konstantin Ryabitsev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=anqsTVj5QGYGiEQ9@monoceros \
--to=ukleinek@kernel.org \
--cc=a.hindborg@kernel.org \
--cc=acourbot@nvidia.com \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun@kernel.org \
--cc=dakr@kernel.org \
--cc=gary@garyguo.net \
--cc=laniel_francis@privacyrequired.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=m.wilczynski@samsung.com \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
--cc=tools@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox