From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from stravinsky.debian.org (stravinsky.debian.org [82.195.75.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A18743711B for ; Tue, 11 Aug 2026 10:15:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=82.195.75.108 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786443312; cv=none; b=ltgAUHstyXLlPyZQpxmcCwdUHzPcHlcN4zXMoac/vXhG8rSFkwqU50SeZnntOyeRazoK3kgKhRyVp1DM+NkSLOhF4mxRFHOZfLbL2pCd9hG+hM9/OO4rof8WDHtUa6S34KwRn7U3lYssDTFGXus8KTzEtxq0yR92FzVfdWH18ZY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786443312; c=relaxed/simple; bh=KxFBryN8BV5BX5FUz3Lqlb4rFyY+8rgzYaC7B2i1hP0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hLuCt/n5KODIiHWZTuAL5C4IL58TGk3fNtA0aRFQEiHSQch4Gi7fptpV9EKq+7K5fbnVCIDwJW0iAknusGJNIviRzL8Xftj26Dl77NfwGCb70eHjpNFuwEr0mywF9nDXYYEKFkGgmMUSU1T+idGsqSV/1H/AC7BSYHYkQ/tMGkU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=debian.org; spf=pass smtp.mailfrom=debian.org; dkim=pass (2048-bit key) header.d=debian.org header.i=@debian.org header.b=aJiUGGC7; arc=none smtp.client-ip=82.195.75.108 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=debian.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=debian.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=debian.org header.i=@debian.org header.b="aJiUGGC7" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debian.org; s=smtpauto.stravinsky; h=X-Debian-User:In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=wy2d/xzBDCwjAJyboMDHJTvsT9F//UoLG8ieGk+fOWc=; b=aJiUGGC7lpf3Mi+bDDDfP0Jq+N P/NPQAJw5KI1bs1+JnP217it7kgTbsGCwwQNxdLgG4Owb4ZmJEmd0loqRTeyUh+rzG5HKXo6vKzyp uOH8k66KjCRnbX8VsRHHhoTiNGGwyyQv35bBMBbHX/nRffSkC/SHjx3MWnrsNdZAbq0xz10hFmmJJ uJkFl0RvSvwtff+ywJPIMqupy4BrDhW5lvEHqQM2Yn+F06XbF82dLvwMDO/JJaG9ZKUxFy7YbvdBS RUwaCa1rL1dpboo3zYPF87rGhoG4HfB4UWHsQqxTqfyMju+CfrJG4/5PS6f+FogmOOoNyUL7bt9uy HsDOe3lw==; Received: from authenticated-user by stravinsky.debian.org with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.96) (envelope-from ) id 1wtjVh-003Ude-1W; Tue, 11 Aug 2026 10:15:05 +0000 Date: Tue, 11 Aug 2026 03:15:01 -0700 From: Breno Leitao To: Tejun Heo Cc: Lai Jiangshan , linux-kernel@vger.kernel.org, marco.crivellari@suse.com, kernel-team@meta.com Subject: Re: [PATCH v2 4/9] workqueue: account nr_active by the backing pool Message-ID: References: <20260805-wq-pool-refactor-v2-0-fd498d01d695@debian.org> <20260805-wq-pool-refactor-v2-4-fd498d01d695@debian.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Debian-User: leitao On Mon, Aug 10, 2026 at 11:41:23AM -1000, Tejun Heo wrote: > On Wed, Aug 05, 2026 at 07:52:31AM -0700, Breno Leitao wrote: > > static struct wq_node_nr_active *wq_node_nr_active(struct workqueue_struct *wq, > > int node) > > { > > - if (!(wq->flags & WQ_UNBOUND)) > > + if (WARN_ON_ONCE(!(wq->flags & WQ_UNBOUND))) > > return NULL; > > This just pushes the crash to the caller, right? Maybe do BUG_ON() instead? Right. I will do a patch that transform this in BUG_ON() in the next patchset. Thanks for the review, --breno