From: Breno Leitao <leitao@debian.org>
To: Gustavo Luiz Duarte <gustavold@gmail.com>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2 2/6] netconsole: use the address family instead of the ipv6 flag
Date: Tue, 11 Aug 2026 06:14:48 -0700 [thread overview]
Message-ID: <ansfpqRSBvmMJEJi@gmail.com> (raw)
In-Reply-To: <20260810-netcons_ipv6-v2-2-3d4fc987a90f@gmail.com>
On Mon, Aug 10, 2026 at 05:47:26PM +0100, Gustavo Luiz Duarte wrote:
> Now that we have the address family in inet_addr, use that and remove
> nt->ipv6.
>
> We no longer need netcons_local_ip_unset() to check that all bytes are
> zeroes, as that is now denoted by (family == AF_UNSPEC).
>
> Signed-off-by: Gustavo Luiz Duarte <gustavold@gmail.com>
Reviewed-by: Breno Leitao <leitao@debian.org>
> - * Test whether the caller left nt->local_ip unset, so that
> - * netcons_netpoll_setup() should auto-populate it from the egress device.
This will change the behaviour when a user setting an explict 0.0.0.0 IP
would not have auto-populate (which only happens with family ==
AF_UNSPEC).
At the same time, I don't think this is a big deal, but, I think it is
worth getting this documented.
Please add an additional patch that would make it clear that, if the
user passes an IP (even 0.0.0.0, it will be used, and auto-populate is
only used when no IP is passed)
next prev parent reply other threads:[~2026-08-11 13:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-10 16:47 [PATCH net-next v2 0/6] netconsole: validate a target's IP address configuration Gustavo Luiz Duarte
2026-08-10 16:47 ` [PATCH net-next v2 1/6] netconsole: add an address family to struct inet_addr Gustavo Luiz Duarte
2026-08-11 13:11 ` Breno Leitao
2026-08-10 16:47 ` [PATCH net-next v2 2/6] netconsole: use the address family instead of the ipv6 flag Gustavo Luiz Duarte
2026-08-11 13:14 ` Breno Leitao [this message]
2026-08-10 16:47 ` [PATCH net-next v2 3/6] netconsole: reject enabling a target with no remote IP address Gustavo Luiz Duarte
2026-08-11 13:16 ` Breno Leitao
2026-08-10 16:47 ` [PATCH net-next v2 4/6] netconsole: reject a target mixing IPv4 and IPv6 addresses Gustavo Luiz Duarte
2026-08-11 13:20 ` Breno Leitao
2026-08-10 16:47 ` [PATCH net-next v2 5/6] netconsole: show empty string for an unset IP address Gustavo Luiz Duarte
2026-08-11 13:21 ` Breno Leitao
2026-08-10 16:47 ` [PATCH net-next v2 6/6] netconsole: move struct inet_addr into netconsole.c Gustavo Luiz Duarte
2026-08-11 13:21 ` Breno Leitao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ansfpqRSBvmMJEJi@gmail.com \
--to=leitao@debian.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gustavold@gmail.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox