From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 11DE440F740 for ; Tue, 11 Aug 2026 14:43:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786459427; cv=none; b=gpe0DW1PrmYVBujctWt3ktuQg+9ZPuI0/spTVlW05ATLM3YMgDmMHtgCsom+69xBe7keoYZDEwBhEYdmwTKsNF8XFABe+bjdmQ/Rf2ZY4fDofcdChBt1WKsVfsOlAwPcXyt9WcCAeNhwEU2Vbhdh+T8DRIaL66b6WGJotQARN6I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786459427; c=relaxed/simple; bh=SCErz/lEB+RJNPUQgs9cila0J4Sl6vkI2ElAH/kk6kQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=qudQezNmTPHfGCka01yb7G2UHDl4kZVY7OG66WYPCHM4DGmV2oIzpq8iDbA+vBrvQIkx6bcioQm4J3qGtoiIEdO7wR5R8xxIE2/gmrvklkT5ZWdzIM1R5WjAwhNwGMy8JlO6pWWcERjka+cDrGHj7+BmCgjxi1jpxWJvio8Lq6U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=Cjsf8LKP; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="Cjsf8LKP" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-4953de5be0aso23917685e9.0 for ; Tue, 11 Aug 2026 07:43:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1786459423; x=1787064223; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=b8sneHjVqgUcdPxNAhatfJbmM4A537AhZlt95Q+odiA=; b=Cjsf8LKPSGazSilTHJGFIUGzJfz6Bc/wRoFG2dHT2EZ9k7zL7WVUQ7jL5F2qNFp3cH CdMTCRbib6KXfZpqmWPlwbmaZ1velvLSlSTGchQx3OlX0HC8HJe3Fei4Q/UzhNuvdSYP Yau9+Y1lo8kDgOBA+xK3EQXdcYwdWjTF2WUq2B+bmrgzHAlfckc/2farlFn2AmlUIDt0 rpuflVcKZdIfpczARtc4ZpgAD7IoWvdVGkP7Gbswp3Elor5Ce+Mi6msHdj7SbGXlvdI2 hBC8cRASrIflIXxeNs+bapl9aqyajRQeNMVZfwF4vilnoy4+HMRQ6Jay1cjRCZLv0073 hbjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786459423; x=1787064223; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=b8sneHjVqgUcdPxNAhatfJbmM4A537AhZlt95Q+odiA=; b=W9msNjPGupUjq/gfW10hnDPP/nnJrn0pQmm+cuzBQoECvR3Ob96wByxpZA2SjeRwDg DJpVU/LwCR+sJape1KClde8oiuVl3AL1UANJ7GlEvpLYXTBMVv+06wZ56Q3GLODGhAfJ nqF9ypXgKyYTm0Uuy+5O5zl2HyIfSemY7VoBh8KTtrdEx+I8DBsjxvLbg8BFwWGI/xKB K5jM3JDDbwsS1IllY2wnDrAFcupt71KYFoGWPF56JhYGsxb5+p63ZWdjZQGeY84dRTYA FpQjUAvm+1qCZFIL/aAnrKbEhhmhAQig4lRT+BFsHCwzoqZgZSmjupZfsdzgZ5daLFvP OgIA== X-Forwarded-Encrypted: i=1; AHgh+RpD9dPxySyo3FHEk9fZ1VTuvFpQdhGzwboue8sGIoBNT5WpBHPbPrVJeVQ/ycvhbqVoJgrMoRqk6GRhS6A=@vger.kernel.org X-Gm-Message-State: AOJu0Yz0Yxws00QR/QHemvyBPgCmkeAEmft0TrtG42Ay6ZoLs3KAq3jC SGlIJQgFKcFlqgwI52uOmjHktA8CA6jXemVhU2/b234MiaHWMGiRa4AV8kyROL/cSu4= X-Gm-Gg: AR+sD12F8Tgm6Kaxy3kgSRTYR/rCNWB4a06d3CAyU2X7kdPxG3yuE4/lQT86fEvklEZ TqgAKnGcXaMJcr4dhAdUsWECobFw53315iqUmEl+5C3pjnGNKtxM/MUDUU6xJabgYIvzl40YbTU 43+eLiGeKyOnzFWWBjGGdyYVjFRpsaMJERvWE+zlIDZJhm/6riYmffQNC810MJxReu9nUPLUgn0 lXrqrWQl674WfsyWBErXUlw5APEu45OHTpnfEgu3xHXBYD9xBgy2F45dueqMG19b45TeuDyRafi qHY0C3MfaiNZIDwGpas7FwkN374Bkng+eWeBTl4ZlMh9Fh1yRMZo+PgIcbiqGJO05n5xWtbDzoP HgITWwlzFtM0utHap+wzVlQJW/yGFMeVRQXzWVK3NjqmS86wW9tFNNH6QBGY2zBzn6qjqJKesZt tE4GhPc3Os9irlDvg33KGArQkpveW+PrEWP0zqd+Bnt2XJ0SzFUfQvwt64cZEv7WYgDMojJF8Hu MA68LpeOwAoi5i21RVbKTM+x1hl7ldUplrAsQrklsfd/MyUY9Rs X-Received: by 2002:a05:600c:4f49:b0:499:4892:e84e with SMTP id 5b1f17b1804b1-49978468bcdmr64393085e9.11.1786459423275; Tue, 11 Aug 2026 07:43:43 -0700 (PDT) Received: from localhost (p200300f65f017104853c3975fdcddd6f.dip0.t-ipconnect.de. [2003:f6:5f01:7104:853c:3975:fdcd:dd6f]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-499740dbb03sm74307965e9.8.2026.08.11.07.43.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Aug 2026 07:43:42 -0700 (PDT) Date: Tue, 11 Aug 2026 16:43:41 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig_=28The_Capable_Hub=29?= To: Andy Shevchenko Cc: Vinod Koul , Andy Shevchenko , Frank Li , linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, Basavaraj Natikar , Manivannan Sadhasivam , Viresh Kumar Subject: Re: [PATCH v3 0/2] dmaengine: Use named initializers for arrays of pci_device_id Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="y4h3jquwjyfrrxda" Content-Disposition: inline In-Reply-To: --y4h3jquwjyfrrxda Content-Type: text/plain; protected-headers=v1; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH v3 0/2] dmaengine: Use named initializers for arrays of pci_device_id MIME-Version: 1.0 Hello Andy, On Tue, Aug 11, 2026 at 04:45:01PM +0300, Andy Shevchenko wrote: > On Mon, Jul 20, 2026 at 02:03:47PM +0200, Uwe Kleine-K=F6nig (The Capable= Hub) wrote: > > the objective of this patch series is to prepare drivers/dma for a > > change of pci_device_id that requires all users to initialize > > .driver_data by name. See > > https://lore.kernel.org/all/cover.1780048925.git.u.kleine-koenig@baylib= re.com/ > > for more details. (This is about platform_device_id, but I intend to do > > that for pci_device_id in the same manner.) > >=20 > > v2 is available at > > https://lore.kernel.org/dmaengine/cover.1781161455.git.ukleinek@kernel.= org > > . > >=20 > > Changes since then: > >=20 > > - Rebase to current next > > - Add review tags by Frank Li and Andy Shevchenko > > - Fix commit log to talk about the right device_id type (i.e. > > pci_device_id and neither pnp nor platform) (partly found by Sashiko) > >=20 > > Note that Andy prefers the use of PCI_DEVICE_DATA() over PCI_VDEVICE() + > > explicit .driver_data because the former is more compact and the > > follow-up change to struct pci_device_id could be handled in the > > definition of that macro. I disagree here, as the compactness is bought > > with quite some magic in the #define once it handles the union, and > > being explicit (and thus less compact) has its merits, too. Additionally > > the affected drivers need an adaption anyhow in their probe function, > > and switching both .probe() and the .id_table in a single patch seems > > right to me. Because from my POV my subjective opinion is obviously the > > right one, I didn't follow Andy's request. >=20 > I think we have not enough understanding regarding implementation. I'm no= t sure > how the union will affect the change in the drivers. When each driver is = going > to be changed to support whatever pointers you want (CFI) this won't affe= ct the > ID table. and hence makes _less_ churn. >=20 > Do you have a Git repository to show an example of the road map of the ch= anges > for, say, one single driver on your choice to see the difference between = your > approach and my suggestion? No, but I think I explained it in enough detail at https://lore.kernel.org/all/af7yKdRdDSJjkoIk@monoceros/ . If the description there still provokes open questions, please ask (maybe in that thread). Best regards Uwe --y4h3jquwjyfrrxda Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmp7NRsACgkQj4D7WH0S /k5clwf8C5KTtpQjy1fDG4oJwarhuL7OMM+CX8LmrkagAs0soCXmQqPN8ZKOf+4T fSuxmzl5tM1fnzRRfC/wMRq1m9WM3te/ghXp4w+dJDPhHCwzRmGNuPF832zcY7HR RB1tBGd527GXdtvoJF/KkWDdMQ1b6iEJLeEGoMf65fWqmZTRMdUmPsNaOjBD6wkb ZgsQ7JYRSIXYlRnIoKMINTVEYNwuURZJlO6KvRLrULEzLc6zfQDtvhhvuFmQtaxQ gWA3B/tf9n/6w3RyYZ4/seKX7iA/x+R/H5Z6CDyElybYfVAgz0NsZ4ltCqUHdtNv iO/NSX9BshsSxURdwanV4Him0Ew5vw== =nw5d -----END PGP SIGNATURE----- --y4h3jquwjyfrrxda--