From: Osama Abdelkader <osama.abdelkader@gmail.com>
To: Javier Martinez Canillas <javierm@redhat.com>
Cc: Neil Armstrong <neil.armstrong@linaro.org>,
Jessica Zhang <jesszhan0024@gmail.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Ondrej Jirman <megi@xff.cz>,
Michael Trimarchi <michael@amarulasolutions.com>,
Michael Walle <mwalle@kernel.org>,
Dario Binacchi <dario.binacchi@amarulasolutions.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/6] drm/panel: Use devm_mipi_dsi_attach in Himax and Ilitek panels
Date: Tue, 11 Aug 2026 18:52:35 +0200 [thread overview]
Message-ID: <antTUw4-Jae3P06S@osama> (raw)
In-Reply-To: <8733wkpthm.fsf@ocarina.mail-host-address-is-not-set>
On Tue, Aug 11, 2026 at 05:27:49PM +0200, Javier Martinez Canillas wrote:
> Osama Abdelkader <osama.abdelkader@gmail.com> writes:
>
> Hello Osama,
>
> > Use the managed MIPI DSI attach helper in Himax and Ilitek panel drivers and drop the corresponding manual detach calls from remove paths.
>
> Please break these at 74 characters max.
>
> > ---
> > drivers/gpu/drm/panel/panel-himax-hx83102.c | 7 +------
> > drivers/gpu/drm/panel/panel-himax-hx83112a.c | 8 +-------
>
> You are missing a Signed-off-by tag.
>
> --
> Best regards,
>
> Javier Martinez Canillas
> Core Platforms
> Red Hat
>
Hello Javier,
Ops, thanks, I don't know how did I forget that.
Thanks for the quick review.
BR,
Osama
next prev parent reply other threads:[~2026-08-11 16:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260811151000.75038-1-osama.abdelkader@gmail.com>
2026-08-11 15:09 ` [PATCH 1/6] drm/panel: Use devm_mipi_dsi_attach in BOE panels Osama Abdelkader
2026-08-11 15:09 ` [PATCH 2/6] drm/panel: Use devm_mipi_dsi_attach in Samsung panels Osama Abdelkader
2026-08-11 15:09 ` [PATCH 3/6] drm/panel: Use devm_mipi_dsi_attach in Novatek and Raydium panels Osama Abdelkader
2026-08-11 15:09 ` [PATCH 4/6] drm/panel: Use devm_mipi_dsi_attach in Himax and Ilitek panels Osama Abdelkader
2026-08-11 15:27 ` Javier Martinez Canillas
2026-08-11 16:52 ` Osama Abdelkader [this message]
2026-08-11 15:09 ` [PATCH 5/6] drm/panel: Use devm_mipi_dsi_attach in display vendor panels Osama Abdelkader
2026-08-11 15:09 ` [PATCH 6/6] drm/panel: Use devm_mipi_dsi_attach in assorted panels Osama Abdelkader
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=antTUw4-Jae3P06S@osama \
--to=osama.abdelkader@gmail.com \
--cc=airlied@gmail.com \
--cc=dario.binacchi@amarulasolutions.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=javierm@redhat.com \
--cc=jesszhan0024@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=megi@xff.cz \
--cc=michael@amarulasolutions.com \
--cc=mripard@kernel.org \
--cc=mwalle@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox