From: Keith Busch <kbusch@kernel.org>
To: changfengnan <changfengnan@bytedance.com>
Cc: axboe@kernel.dk, hch@lst.de, sagi@grimberg.me,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
Guzebing <guzebing@bytedance.com>
Subject: Re: [RESEND RFC PATCH v2] nvme-pci: add adaptive interrupt polling
Date: Tue, 11 Aug 2026 14:29:56 -0600 [thread overview]
Message-ID: <anuGRKqdCFG9381L@kbusch-mbp> (raw)
In-Reply-To: <d9210bcdf73fbe1ac8b6ec132865609a3ed68688.9f189e7a.e65a.4eb9.b86b.c83b70bebfb9@bytedance.com>
On Tue, Aug 11, 2026 at 10:32:35AM +0800, changfengnan wrote:
> The code looks much cleaner when using dim, I'll see if I can replace the
> sample-and-poll logic I wrote myself with the dim library.
> I ran a quick test on the POC patch and didn't see any performance
> improvements; in fact, there were quite a few regressions. Maybe some
> parameters need to be adjusted.
Yeah, I'm just now testing mid-tier devices and it's also performing a
bit worse for high throughput workloads. But I hadn't really tried to
tune the settings here, and maybe my criteria is all wrong. I was mainly
trying to see if we can utilize the dim library before honing in on the
right implementation details.
prev parent reply other threads:[~2026-08-11 20:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-06 3:10 [RESEND RFC PATCH v2] nvme-pci: add adaptive interrupt polling Fengnan Chang
2026-08-10 20:55 ` Keith Busch
2026-08-11 2:32 ` changfengnan
2026-08-11 20:29 ` Keith Busch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=anuGRKqdCFG9381L@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=axboe@kernel.dk \
--cc=changfengnan@bytedance.com \
--cc=guzebing@bytedance.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox