The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Ben Zong-You Xie <ben717@andestech.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: Andi Shyti <andi.shyti@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Paul Walmsley <pjw@kernel.org>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	"Albert Ou" <aou@eecs.berkeley.edu>,
	Alexandre Ghiti <alex@ghiti.fr>, <linux-i2c@vger.kernel.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-riscv@lists.infradead.org>
Subject: Re: [PATCH v5 2/4] i2c: add Andes I2C driver support
Date: Wed, 12 Aug 2026 11:31:37 +0800	[thread overview]
Message-ID: <anvpGTqOnwlbERgR@swlinux02> (raw)
In-Reply-To: <361b7fa5-0e4c-429a-ad66-c81fbee86c45@wanadoo.fr>

On Tue, Aug 11, 2026 at 09:37:12AM +0200, Christophe JAILLET wrote:
>
> Le 11/08/2026 à 08:29, Ben Zong-You Xie via B4 Relay a écrit :
> > From: Ben Zong-You Xie <ben717@andestech.com>
> >
> > Add support for Andes I2C driver. Andes I2C can act as either a
> > controller or a target, depending on the control register settings. Now,
> > we only support controller mode.
> >
> > Signed-off-by: Ben Zong-You Xie <ben717@andestech.com>
>

Hi CJ,

> ...
>
> > +static struct i2c_algorithm andes_i2c_algo = {
>
> Could this be const?

Yes, I will add const in v6.

> > +     .xfer = andes_i2c_xfer,
> > +     .functionality = andes_i2c_func,
> > +};
> CJ

Thanks,
Ben

  reply	other threads:[~2026-08-12  3:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-11  6:29 [PATCH v5 0/4] i2c: add support for Andes platform Ben Zong-You Xie via B4 Relay
2026-08-11  6:29 ` [PATCH v5 1/4] dt-bindings: i2c: add support for AE350 I2C controller Ben Zong-You Xie via B4 Relay
2026-08-11  6:29 ` [PATCH v5 2/4] i2c: add Andes I2C driver support Ben Zong-You Xie via B4 Relay
2026-08-11  7:37   ` Christophe JAILLET
2026-08-12  3:31     ` Ben Zong-You Xie [this message]
2026-08-11  6:29 ` [PATCH v5 3/4] MAINTAINERS: add an entry for Andes I2C driver Ben Zong-You Xie via B4 Relay
2026-08-11  6:29 ` [PATCH v5 4/4] riscv: dts: andes: qilai: add I2C controller Ben Zong-You Xie via B4 Relay

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=anvpGTqOnwlbERgR@swlinux02 \
    --to=ben717@andestech.com \
    --cc=alex@ghiti.fr \
    --cc=andi.shyti@kernel.org \
    --cc=aou@eecs.berkeley.edu \
    --cc=christophe.jaillet@wanadoo.fr \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --cc=pjw@kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox