From: Alice Ryhl <aliceryhl@google.com>
To: Suren Baghdasaryan <surenb@google.com>
Cc: akpm@linux-foundation.org, dave.hansen@linux.intel.com,
Liam.Howlett@oracle.com, ljs@kernel.org, david@redhat.com,
willy@infradead.org, shakeel.butt@linux.dev, vbabka@kernel.org,
jannh@google.com, arve@android.com, cmllamas@google.com,
christian@brauner.io, tkjos@android.com, dsahern@kernel.org,
davem@davemloft.net, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
netdev@vger.kernel.org
Subject: Re: [PATCH v5 2/5] binder: Make shrinker rely solely on per-VMA lock
Date: Wed, 12 Aug 2026 10:46:10 +0000 [thread overview]
Message-ID: <anxO3VT1JPAuSNf-@google.com> (raw)
In-Reply-To: <20260812011056.902771-3-surenb@google.com>
On Tue, Aug 11, 2026 at 06:10:52PM -0700, Suren Baghdasaryan wrote:
> return LRU_REMOVED_RETRY;
>
> -err_invalid_vma:
> mutex_unlock(&alloc->mutex);
With the err_invalid_vma label removed, this call to mutex_unlock() is
no longer reachable as it comes right after a 'return' statement.
Alice
next prev parent reply other threads:[~2026-08-12 10:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-12 1:10 [PATCH v5 0/5] mm: Unconditional per-VMA locks and cleanups Suren Baghdasaryan
2026-08-12 1:10 ` [PATCH v5 1/5] mm: Make per-VMA locks available universally Suren Baghdasaryan
2026-08-12 1:10 ` [PATCH v5 2/5] binder: Make shrinker rely solely on per-VMA lock Suren Baghdasaryan
2026-08-12 10:46 ` Alice Ryhl [this message]
2026-08-12 13:37 ` Suren Baghdasaryan
2026-08-12 1:10 ` [PATCH v5 3/5] mm: Add RCU-based VMA lookup helper that waits for writers Suren Baghdasaryan
2026-08-12 1:10 ` [PATCH v5 4/5] binder: Remove mmap_lock fallback Suren Baghdasaryan
2026-08-12 1:10 ` [PATCH v5 5/5] tcp: Remove mmap_lock fallback path Suren Baghdasaryan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=anxO3VT1JPAuSNf-@google.com \
--to=aliceryhl@google.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=arve@android.com \
--cc=christian@brauner.io \
--cc=cmllamas@google.com \
--cc=dave.hansen@linux.intel.com \
--cc=davem@davemloft.net \
--cc=david@redhat.com \
--cc=dsahern@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jannh@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shakeel.butt@linux.dev \
--cc=surenb@google.com \
--cc=tkjos@android.com \
--cc=vbabka@kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox