From: Sean Christopherson <seanjc@google.com>
To: Rick P Edgecombe <rick.p.edgecombe@intel.com>
Cc: "sathyanarayanan.kuppuswamy@linux.intel.com"
<sathyanarayanan.kuppuswamy@linux.intel.com>,
"kas@kernel.org" <kas@kernel.org>,
Peter Fang <peter.fang@intel.com>,
"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
Artem Bityutskiy <artem.bityutskiy@intel.com>,
"bp@alien8.de" <bp@alien8.de>, "x86@kernel.org" <x86@kernel.org>,
"binbin.wu@linux.intel.com" <binbin.wu@linux.intel.com>,
"hpa@zytor.com" <hpa@zytor.com>,
"mingo@redhat.com" <mingo@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Xiaoyao Li <xiaoyao.li@intel.com>,
"tglx@kernel.org" <tglx@kernel.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"linux-coco@lists.linux.dev" <linux-coco@lists.linux.dev>
Subject: Re: [PATCH v3 0/4] tdx-guest: Make Quote buffer size dynamic
Date: Wed, 12 Aug 2026 07:08:22 -0700 [thread overview]
Message-ID: <anxvwV_Pz4UYaxxt@google.com> (raw)
In-Reply-To: <80b4ea89ebf17398c3bee21d157c7f97ea32aadf.camel@intel.com>
On Tue, Aug 11, 2026, Rick P Edgecombe wrote:
> Sean, Dave, Kiryl,
>
> In PUCK we talked about how the TD scoped quote operation avoids changes
> in the guest. But this series is actually changing the guest, so is
> somewhat at odds to that assertion. It turns out there are some tradeoffs
> here that also connect to TDX migration uAPI. Please see below for an
> explanation and recommended course of action.
>
> As a gentle recall helper... The general attestation flow converts a
> report to a quote, which then gets checked by a verifier. The report is
> like a snapshot of the guest and its environment. The quote is a signed
> version of the report plus hardware certs. It's signed with a hardware key
> and can use different kinds of crypto.
>
> These pieces are evolving to handle a few problems at once:
> - The stuff that needs to be attested is growing. Basically more platform
> details and devices are getting added to the blobs.
> - The crypto stuff is growing. The post quantum crypto stuff is large,
> etc. That stuff lives in the quote.
> - Migration wants a quote that is platform specific and not TD specific.
>
> Because the platform details are growing, they need to either go into a
> larger report or added later via a TD scoped quote. But the post quantum
> crypto stuff is going to bloat the quote either way.
>
> If the report grows to include all the TD specific details, then the QUOTE
> seamcall can be platform scoped because all the details that it needs are
> passed in as args.
>
> But if it is TD scoped, the report can stay the same size and the extra
> details can just be added during the quote operation. For migration, it
> only needs a platform scoped quote. If there are extra details about a
> specific TD, the migration stuff can be fine to just ignore them. (i.e. it
> can get what it needs from TD scoped quotes or platform scoped quotes).
>
> The current QUOTE seamcall supports both: platform scoped and TD scoped
> operations. But since we could get by with either only a platform or TD
> scoped seamcall for both operations, we could reduce the kernel's uAPIs,
> or change the API's location. Per recent discussion, Sean sees TD scoped
> APIs living in KVM and platform scoped things living in the host
> driver/tip. So all that leaves us with something like this:
>
> |Normal quote |Migration quote |Report size|Quote size|uAPI location |
> -|----------------|----------------|-----------|----------|---------------|
> 1|Platform scoped |Platform scoped |Grows |Grows |TDX host driver|
With my KVM hat on, this option looks very attractive.
And with the caveat that I'm most definitely not an attestation expert, from a
separate of concerns perspective, IMO it seems like the report should contain the
TD-specific information while the quote just wraps that information in platform-
specific goo.
In other words, to me, TD-scoped quotes feel like a hack that was thrown in to
avoid having to modify the guest because y'all didn't plan ahead.
> 2|TD scoped |TD scoped |Fixed |Grows |KVM |
> 3|TD scoped |Platform scoped |Fixed |Grows |Both |
>
>
> I'm thinking we should proceed with 2 because only the quote size changes.
> So less guest changes over time. 3 is not really a disaster either, but we
> shouldn't need 2 uABIs. For 1, from early discussion it seems it can be
> made to work but sounds like it will require some more extensive changes
> to the TDX attestation stuff. So probably needs a bit more investigation
> before we can say it won't disturb some other VMM vendor, etc.
next prev parent reply other threads:[~2026-08-12 14:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-29 12:29 [PATCH v3 0/4] tdx-guest: Make Quote buffer size dynamic Peter Fang
2026-07-29 12:29 ` [PATCH v3 1/4] x86/tdx: Add helper to query maximum TD Quote size Peter Fang
2026-07-29 12:29 ` [PATCH v3 2/4] virt: tdx-guest: Calculate the Quote buffer size safely Peter Fang
2026-07-29 18:29 ` Kuppuswamy Sathyanarayanan
2026-07-29 12:29 ` [PATCH v3 3/4] virt: tdx-guest: Use a variable to store the Quote buffer size Peter Fang
2026-07-29 18:47 ` Kuppuswamy Sathyanarayanan
2026-07-29 12:29 ` [PATCH v3 4/4] virt: tdx-guest: Allocate Quote buffer dynamically Peter Fang
2026-07-29 21:21 ` [PATCH v3 0/4] tdx-guest: Make Quote buffer size dynamic Edgecombe, Rick P
2026-08-11 22:40 ` Edgecombe, Rick P
2026-08-12 14:08 ` Sean Christopherson [this message]
2026-08-12 16:02 ` Edgecombe, Rick P
2026-08-12 16:43 ` Sean Christopherson
2026-08-12 17:22 ` Edgecombe, Rick P
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=anxvwV_Pz4UYaxxt@google.com \
--to=seanjc@google.com \
--cc=artem.bityutskiy@intel.com \
--cc=binbin.wu@linux.intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=kas@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-coco@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peter.fang@intel.com \
--cc=rick.p.edgecombe@intel.com \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=tglx@kernel.org \
--cc=x86@kernel.org \
--cc=xiaoyao.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox