From: Christoph Hellwig <hch@infradead.org>
To: Moritz Tanner <moritz.tanner@linbit.com>
Cc: Christian Brauner <brauner@kernel.org>,
Alexander Viro <viro@zeniv.linux.org.uk>, Jan Kara <jack@suse.cz>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] fs: don't return -EINVAL for successful nested thaw
Date: Mon, 24 Aug 2026 22:52:02 -0700 [thread overview]
Message-ID: <ao0tghVJQVIjfuDq@infradead.org> (raw)
In-Reply-To: <20260821085451.65206-1-moritz.tanner@linbit.com>
On Fri, Aug 21, 2026 at 10:54:51AM +0200, Moritz Tanner wrote:
> Reproducer (any kernel since v6.8):
>
> dmsetup create dut --table "0 $(blockdev --getsz "$DEV") linear $DEV 0"
> mkfs.ext4 /dev/mapper/dut
> mount /dev/mapper/dut /mnt
> fsfreeze --freeze /mnt # freeze_ucount == 1
> dmsetup suspend dut # bd_fsfreeze_count == 1, ucount == 2
> dmsetup resume dut # ucount 2 -> 1, but thaw_super()
> # returns -EINVAL, so bdev_thaw()
> # keeps bd_fsfreeze_count at 1
> fsfreeze --unfreeze /mnt # filesystem thaws fine
> umount /mnt
> mount /dev/mapper/dut /mnt # EBUSY, forever
Can you wire this up in xfstests or blktests?
next prev parent reply other threads:[~2026-08-25 5:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-21 8:54 [PATCH] fs: don't return -EINVAL for successful nested thaw Moritz Tanner
2026-08-21 9:47 ` Lars Ellenberg
2026-08-25 5:52 ` Christoph Hellwig [this message]
2026-08-25 14:28 ` Christian Brauner
2026-08-25 14:29 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ao0tghVJQVIjfuDq@infradead.org \
--to=hch@infradead.org \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=moritz.tanner@linbit.com \
--cc=stable@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox