From: Christoph Hellwig <hch@infradead.org>
To: Dongbum Kim <dongbumkim75@gmail.com>
Cc: rafael@kernel.org, lenb@kernel.org, pavel@kernel.org,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
Dongbum Kim <dongbum.kim@lge.com>
Subject: Re: [PATCH] power: use EXPORT_SYMBOL() to export symbol
Date: Mon, 24 Aug 2026 23:02:16 -0700 [thread overview]
Message-ID: <ao0v6G68S_W5CBz5@infradead.org> (raw)
In-Reply-To: <20260820034445.2562231-1-dongbum.kim@lge.com>
On Thu, Aug 20, 2026 at 12:44:45PM +0900, Dongbum Kim wrote:
> Add EXPORT_SYMBOL() to mark freeze_timeout_msecs symbol as visible.
>
> freeze_timeout_msecs defines the timeout for try_to_freeze_tasks. If
> tasks cannot be frozen within this timeout, try_to_freeze_tasks fails,
> and causes suspend or hibernation to fail.
>
> For example, a device driver may need to perform certain operations
I think you really should know that:
a) exports without users are a complete no-go, and sending them is
considered a major offence
b) even with users, exporting data (variables) is generally a bad idea
c) non-GPL exports for new functionality are almost always a bad idea
if not please take this up with your corporate and technical leadership
to ensure the Linux training standards at LG are up to date.
prev parent reply other threads:[~2026-08-25 6:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-20 3:44 [PATCH] power: use EXPORT_SYMBOL() to export symbol Dongbum Kim
2026-08-25 6:02 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ao0v6G68S_W5CBz5@infradead.org \
--to=hch@infradead.org \
--cc=dongbum.kim@lge.com \
--cc=dongbumkim75@gmail.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pavel@kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox