From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E29CA3D810D for ; Tue, 25 Aug 2026 09:01:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787648467; cv=none; b=JEx3/qiuVrEVpx/on4PPyKxwaN7t5A3dKPkqDsGFSUTCvoUGSe+DLWaUHV/qPjBnFKBle/YYOxtqc3IFOtRKVCS0tLWon4dtLGN/GhlmJbXUUgI+dc28ziTvaY0Rq8kpIBVd1HbI1sx/wFDcn+1Hm1rbzbOLl9E2BC2F7ootDik= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787648467; c=relaxed/simple; bh=9xDn1ajVKRzKRfLuy/bg7I+rTvn4E57pv+fN44j0jRc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fWaznhEqfCi6s/HP+ItYIKOwOq8RL+2zNm8Mitav94kiv/DW4OKLuqQXKcD6DGhhCc5seNrtC7JksuTUA9xI49tVHwVy9Dzdy6Vv1Dp4i3ze8Vd2W7cMsNJxep26vuvFDRasaCmgw//m74ee7HnF3+Y3I285ZGhvIrwP4t1qVR8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=resnulli.us; spf=none smtp.mailfrom=resnulli.us; dkim=pass (2048-bit key) header.d=resnulli-us.20251104.gappssmtp.com header.i=@resnulli-us.20251104.gappssmtp.com header.b=MEYq5CQ/; arc=none smtp.client-ip=209.85.218.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=resnulli.us Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=resnulli.us Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20251104.gappssmtp.com header.i=@resnulli-us.20251104.gappssmtp.com header.b="MEYq5CQ/" Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-c197e7e4e94so789543866b.2 for ; Tue, 25 Aug 2026 02:01:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20251104.gappssmtp.com; s=20251104; t=1787648460; x=1788253260; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=wjyio8DgLKHGd4Hy3nKZBHOklYUNmSY9PP0wGlRlgZE=; b=MEYq5CQ/HVX7dajIOA7ZKckDZlrKERevk+9wwR4UYtAvDqj7Uq7+MevA73IlGCd3Aw vC90E0+cTEULRJWzYVEcp2vZG5Os3NfbYCU03nTdGL2vtDJCnlXij/7L7ZJ5ChZlBdE4 rl3csxvKQuckPQ10zPj6lrihx8s8wqDJZAYS801J/h+9ZV9JqIL0HFjUCRYBhy0EvlqX Nm5KWD5pY2ZnCALi0DWt3cAIIzYAU5Bv7Vr1KWlY+FC1jaMcuHNJHbRCJ8vejyfD0BU7 ryUK5WH8IzQ53II+N2s788CNriE+COBqgGuB2nyqNvWndK/8pJBgfkQkjTacDIqcyc73 f7MQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787648460; x=1788253260; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=wjyio8DgLKHGd4Hy3nKZBHOklYUNmSY9PP0wGlRlgZE=; b=EXNQA1oYQ3SP0TuJ0dTRGhzPoMwzBfYQsqqMZWBSJ1j55GFPb9I1ObhX/03Weotr31 uxR8O7ouXsQ0NkGvw7dpOq3td7cFGJriSjLylLGxf4wNzm5Cqj0Xk/4KVjURQn+yCNgI t08WajvhytRFhXJQQ2s9QtF2e38Z0c+yWVZqOKkmMTfQ3YSdUkdQUVELJWZcn1uE3Hv4 mRukSAnyd99qSICcltpse+tiEkZz0h/lZbKO0f8Rz1CzY+a+A+yptY/DSkvhOZ8yaV3H JVVhwIVdeL0A4I8KAQy6dbIC7nfkGK6+VdhoKOTO6RWU6Njaqi5SQDVHcjOJfn/ikztk T4cQ== X-Forwarded-Encrypted: i=1; AHgh+RobnZWJl+Xy5wwXWFWIDg1S1lffQC7qPwUVgb5OPXxiHsbQJR/xs0aZ1m6ryuSCQRsyGJkPjEZPNFVca2w=@vger.kernel.org X-Gm-Message-State: AFuF++n7wA6VLIcq3RDbvIy5crRYAsydEZwsIhxwyWRKu0hpNUqGvxCh Y5s+tt87UMwJsCcc9rpcy5nKzkhPbuLXUd5lzUMipqfgvGNzoadmhw0pxorXQjy2r4U= X-Gm-Gg: AR+sD13tWntSQFu+e/RJGMTU9gEMndWrKQ0EzhhGvzCkGT4utiF+5oE2GWhNWjjJELc 7lFYvQl7FeSSG1hND/8vH853L/pKYihu9xzwruoRkkCW5eKjrR4RfalPvhPPT1eZ1MOIFt1O3+U tkSCXHa77ulqjJWpJceROw5m5opeXGH3+mR63kH0QM9lFShWv0CfJ2FLSbilzElJJwcvndDNYk+ 5vSRXumdsZtyTLlg2OwvqNV2nBb1HYdXrUJp79d1QuTL7FVB4CStdjrMnDLXZImM7OJtdk1Lacy ZR6KW4ThZwuU5KPlZmw3v3lx5SWTnAWYkwtqHsscbXaComrb2vkpGPeT+jYMhw7Z12bC0ydFNwM nuGERMlzNqo/xUbXccW/BOykdJqU3n4eOlbRrvBWtirb3HRl3N8Ylnzo62QWiW1++zs3FLJ1spC 5Zku03J4mnVz+nvXM9nnRJB4kuccP+83eL5xId0xSMu+AvrsivFh/NDh+zGg4bTZB+Bpjqkzkc2 kPf X-Received: by 2002:a17:907:1ca0:b0:c16:14d1:b529 with SMTP id a640c23a62f3a-c249262043bmr2784972566b.18.1787648458278; Tue, 25 Aug 2026 02:00:58 -0700 (PDT) Received: from localhost ([85.163.81.98]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c24966f99basm1591648166b.37.2026.08.25.02.00.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Aug 2026 02:00:57 -0700 (PDT) Date: Tue, 25 Aug 2026 11:00:52 +0200 From: Jiri Pirko To: Vadim Fedorenko Cc: Ali Rouhi , "arkadiusz.kubalewski@intel.com" , "robh@kernel.org" , "krzk+dt@kernel.org" , "conor+dt@kernel.org" , "cjubran@nvidia.com" , "Oleg.Zadorozhnyi@devoxsoftware.com" , "devicetree@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH net-next v7 3/3] dpll: add SiTime SiT9531x DPLL clock driver Message-ID: References: <20260815221919.64226-1-arouhi@sitime.com> <20260815221919.64226-4-arouhi@sitime.com> <6a529684-bd6a-4187-9ed9-bb40f4b98065@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6a529684-bd6a-4187-9ed9-bb40f4b98065@linux.dev> Wed, Aug 19, 2026 at 11:16:18PM +0200, vadim.fedorenko@linux.dev wrote: >On 15/08/2026 23:19, Ali Rouhi wrote: >> Add a DPLL subsystem driver for the SiTime SiT95316 and SiT95317 >> clock generators. These devices provide low-jitter clock outputs >> commonly used in telecom, networking, and data center timing >> applications. >> >> The driver exposes all inputs and outputs through the Linux DPLL >> subsystem, supporting: >> - Lock status monitoring via register polling or optional INTRB IRQ >> - Input priority management for automatic reference switchover >> - Per-output frequency readback from hardware state >> - Phase offset measurement via TDC (time-to-digital converter) >> - Phase adjustment for fine output alignment >> - Embedded sync (esync) pulse control on outputs >> - Fractional frequency offset of the selected reference >> - Optional reset-gpios for hardware reset >> >> The driver reads all configuration from the device's on-chip NVM >> at probe time -- no firmware loading is required. >> >> Co-developed-by: Oleg Zadorozhnyi >> Signed-off-by: Oleg Zadorozhnyi >> Assisted-by: Claude:claude-4-opus [chat] >> Signed-off-by: Ali Rouhi >> --- >> MAINTAINERS | 7 + >> drivers/dpll/Kconfig | 1 + >> drivers/dpll/Makefile | 1 + >> drivers/dpll/sit9531x/Kconfig | 17 + >> drivers/dpll/sit9531x/Makefile | 4 + >> drivers/dpll/sit9531x/core.c | 3111 ++++++++++++++++++++++++++++++++ >> drivers/dpll/sit9531x/core.h | 372 ++++ >> drivers/dpll/sit9531x/dpll.c | 1232 +++++++++++++ >> drivers/dpll/sit9531x/dpll.h | 69 + >> drivers/dpll/sit9531x/prop.c | 397 ++++ >> drivers/dpll/sit9531x/prop.h | 39 + >> drivers/dpll/sit9531x/regs.h | 371 ++++ >> 12 files changed, 5621 insertions(+) > >as the new version is need, could you please think of how it can be >split. reviewing if 5.6k lines of code in one go is quite tough It's a new driver. Linear review in one hunk. I think it is better that way as you see the whole thing right away.