The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Petr Mladek <pmladek@suse.com>
To: Bradley Morgan <include@grrlz.net>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Jinchao Wang <wangjinchao600@gmail.com>,
	Feng Tang <feng.tang@linux.alibaba.com>,
	Rio <rioo.tsukatsukii@gmail.com>,
	Pnina Feder <pnina.feder@mobileye.com>,
	Petr Pavlu <petr.pavlu@suse.com>,
	Sergey Senozhatsky <senozhatsky@chromium.org>,
	linux-kernel@vger.kernel.org, Sashiko <sashiko-bot@kernel.org>,
	stable@vger.kernel.org
Subject: Re: [PATCH v6 0/6] panic: fix panic_force_cpu= redirect races and NMI bypass
Date: Tue, 25 Aug 2026 11:55:29 +0200	[thread overview]
Message-ID: <ao1mkbDPbChOKjt9@pathway.suse.cz> (raw)
In-Reply-To: <0EBA4DAD-7B63-4AD6-B1E7-523D09E1305D@grrlz.net>

On Tue 2026-08-18 19:45:47, Bradley Morgan wrote:
> On 18 August 2026 19:41:58 BST, Andrew Morton <akpm@linux-foundation.org>
> wrote:
> >On Tue, 18 Aug 2026 16:38:00 +0000 Bradley Morgan <include@grrlz.net>
> >wrote:
> >
> >> The panic_force_cpu= parameter redirects a panic to a specific CPU so
> >> the crash kernel runs there. The redirect code in panic_try_force_cpu()
> >> had two races and an NMI bypass, all found by Sashiko. This series
> >> closes them and kills one more hack that the rework turned up.
> >
> >Thanks.  Sashiko had more to say:
> >	https://sashiko.dev/#/patchset/20260818163806.17460-1-include@grrlz.net
> >
> >In the first one it suggests va_copy(), but perhaps this would be
> >better addressed with va_end/va_start.
> >
> 
> Sashiko said there was ANOTHER bug, I might just screammm, at this point,
> some sort of superhero needs to come by and suggest the fix that sashiko
> likes :sob:

We are all still learning how to deal with Sashiko. It is quite good
at finding problems. We always have to decide/agree on what is worth
fixing and what is not worth it.

I described my opinion in replies to the particular patches.

Anyway, we are getting close. I believe that v7 will be final ;-)

Best Regards,
Petr

      reply	other threads:[~2026-08-25  9:55 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-18 16:38 [PATCH v6 0/6] panic: fix panic_force_cpu= redirect races and NMI bypass Bradley Morgan
2026-08-18 16:38 ` [PATCH v6 1/6] panic: fix redirect CPU race in panic_try_force_cpu() Bradley Morgan
2026-08-25  8:27   ` Petr Mladek
2026-08-18 16:38 ` [PATCH v6 2/6] panic: flatten nmi_panic control flow Bradley Morgan
2026-08-18 16:38 ` [PATCH v6 3/6] panic: fix va_list reuse in panic_try_force_cpu() Bradley Morgan
2026-08-18 16:38 ` [PATCH v6 4/6] panic: restore variable arguments to nmi_panic() Bradley Morgan
2026-08-25  9:11   ` Petr Mladek
2026-08-18 16:38 ` [PATCH v6 5/6] panic: allow force_cpu redirect from an NMI Bradley Morgan
2026-08-25  9:28   ` Petr Mladek
2026-08-18 16:38 ` [PATCH v6 6/6] panic: kill the "buffer unavailable" redirect fallback Bradley Morgan
2026-08-25  9:49   ` Petr Mladek
2026-08-18 18:41 ` [PATCH v6 0/6] panic: fix panic_force_cpu= redirect races and NMI bypass Andrew Morton
2026-08-18 18:45   ` Bradley Morgan
2026-08-25  9:55     ` Petr Mladek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ao1mkbDPbChOKjt9@pathway.suse.cz \
    --to=pmladek@suse.com \
    --cc=akpm@linux-foundation.org \
    --cc=feng.tang@linux.alibaba.com \
    --cc=include@grrlz.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=petr.pavlu@suse.com \
    --cc=pnina.feder@mobileye.com \
    --cc=rioo.tsukatsukii@gmail.com \
    --cc=sashiko-bot@kernel.org \
    --cc=senozhatsky@chromium.org \
    --cc=stable@vger.kernel.org \
    --cc=wangjinchao600@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox