From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EE1283F65EB for ; Tue, 25 Aug 2026 10:25:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787653558; cv=none; b=DK/GVzNb+CV5smUobrEbkTYzfCPxjzza+4digEe0W+7ImI2OQqOYO0CeE3LDnFwV39x6sl3fmPl2MaNwjWuNbYxfnjKTeoLhJobWm9ePu9UnzEMaHBwlxgdgiIraP85sLRn5xs6URIBYpPc80bPAOGRC5lLkgkppuXg6f+rb80s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787653558; c=relaxed/simple; bh=us+W/l34bjTqb6E5LUJYAddeXA9sIpUgX+mtnAqikO0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=CaXJ5RyPsDgd8r9f0TuG8queocA8Ip3XSCNrMXKQ/6gkMMGGs9mS+EmuLW8MsBtpSm69gHttxFo7Y5n13cXww6VvcHmX/lTyNs0OFm38FOxke1ZAM8QnTLtbmfw2bPyRggcJhePWnktmQqO2vpVDDN2adX6dTSGxB46Vy/+b3CM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=ZeLN1ZXq; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="ZeLN1ZXq" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2ccdf36f63dso101045ad.0 for ; Tue, 25 Aug 2026 03:25:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1787653556; x=1788258356; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=E0guju7I7mkEmUSt1DIdoTBJV8Ed/bpyGw6FfhSmD8Y=; b=ZeLN1ZXqZ+Stei7HHH8dI1Lo5/wACGdXeI7y0Nnn+Qe4vs0K7n+397s7Z7CPNWFJaY ztZvpz2vDS0/i1enuPU9e+l1yQspy1xiwg4nIlG5n7+w6Rl2j9LupOckslRzXe/IzwRt zHg4/feRy1QryypUiiFo+8II6ae9oe+fWD3ed9ZvGtU2M7N/lK3iMP8hA94741bZgiY6 R9RDW4xzgWDmbi2BMb3H7pJ041TAmDUUdYEOUZnMVgwFcsR2AMjJnVMsVfqYgfkB/ukO eXv7nf+E9G/oOnQBUselY2aFpIVHw5Ky0D4I00Kc6AUHk3HDWyZPP2yeRR6xCz4Rsbqb 3uSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787653556; x=1788258356; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=E0guju7I7mkEmUSt1DIdoTBJV8Ed/bpyGw6FfhSmD8Y=; b=EFEwIygLZYTayC875CaDDZvoOusa93unF56nEhoFzVwHJgcOVf2Jqyg3gp6+BahAz5 vQ2USDOd+hFa1whuALOQS6ldeji3bbfLWOBGfBQ+s4bQ2Z+0VOOH+LFJ60/Cu7ZYlHrz PEkus1if/gyec53bM5/YwA3glBJHhsA3kyCB8URHaacyp4sOvVprUrLlkhRfa8cauhhb nvKwuc0Ro2+v28uNOb/dLDdBzG1r/ELxxanxfEll/Kd58yGgbJpgnPx+96DraGt0ktTZ /p/Mh2KL0UqNHj566uUYnc5qTpgNL/Rs69UqeAfAMrvdxHfgZV/3DDubSKNJa7D6ThZK zWSg== X-Forwarded-Encrypted: i=1; AHgh+RrYO/eXiVuUayOABz84WOVlHbNtr8lmEj1ZMX+ThjlSKOjB7+9HAveOy7nwSn6m4bS91NokUe21Drxz4+o=@vger.kernel.org X-Gm-Message-State: AFuF++lHia0ocgiAKES+yNn6xCr4aL2J3hg/xxccanSRk1OP9eyxRgsI k2pdSf67DrEN90B4ae75TGk7M3fQSv5+PMKbg12n5mtoWOZpRUEXjcjfpD/QJgT4QQ== X-Gm-Gg: AR+sD10JoWfsIlNjRhqW65K3Z8KesBkeiiFngLAt1MUn6+EEMHZNSNd0FkPC4VH56zq qRvEyjd4wVHtXvlXed88B3nd3Pm12NB6OET03oqzKG/I/z73E46W3vZ+HaKya7o52TUb3GqEYWK 7q1NlGcFXwcWqO2AKc+0p/J5oJnOZnwj4nSkKwCew25C07hTZ8r3xREFt5Lxio+/38pIE/YlMiE 3y1XHWrvYD97dq2SQ2BH4/oUJkmg5c+BW0p3QvmQLXW375qJjPTMD0EUycCEBmVTSDLtBlpGb0V 0uQxtzJCQM3Gt8x6c8EXvaOnS25CpnoQQW33MkSqMGaT0QgNwRRsVz5M7g97Xi4M2DGTaBjTYxo Am7Xd1Tp3z8eng1LJZwidiFhkjFqjYnZXAQZODb0+emPZAvouKs4KjoCXVOFRlcM/ZNnj5EDg7K +cXYQUq2xM+MndYueUIbgaD/Z9RepR4OghSttyNEYX/L0ShUmoDJs/aXjX12haDKSRI8RKNJ3i4 4U7iGhydJMi4lB67w9l0IH3SQ== X-Received: by 2002:a17:902:f705:b0:2c9:b404:b55 with SMTP id d9443c01a7336-2d6e05187ecmr6241535ad.6.1787653555477; Tue, 25 Aug 2026 03:25:55 -0700 (PDT) Received: from google.com (164.210.142.34.bc.googleusercontent.com. [34.142.210.164]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8520f03b243sm2791227b3a.31.2026.08.25.03.25.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Aug 2026 03:25:54 -0700 (PDT) Date: Tue, 25 Aug 2026 10:25:49 +0000 From: Pranjal Shrivastava To: Vasant Hegde Cc: iommu@lists.linux.dev, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Joerg Roedel , Suravee Suthikulpanit , Ankit Soni , Jason Gunthorpe , Bjorn Helgaas , Samiullah Khawaja Subject: Re: [PATCH v3 1/5] iommu/amd: Refactor device probe and capability initialization Message-ID: References: <20260824122347.1588592-1-praan@google.com> <20260824122347.1588592-2-praan@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Aug 25, 2026 at 12:29:35PM +0530, Vasant Hegde wrote: > > > On 8/24/2026 5:53 PM, Pranjal Shrivastava wrote: > > Restructure the device probe path to improve readability and prepare for > > cleaner error handling. Refactor check_device() into iommu_lookup_device > > to explicitly validate and return the amd_iommu ptr & devid. Refactor > > iommu_init_device() to return the allocated dev_data. Consolidate all > > PCI cap inits (MSI domains, PASID, ATS) into a new helper: > > iommu_init_device_caps(). > > > > Suggested-by: Vasant Hegde > > Signed-off-by: Pranjal Shrivastava > > One minor nit. Otherwise patch looks good. > > Reviewed-by: Vasant Hegde > > > > > --- > > drivers/iommu/amd/iommu.c | 117 +++++++++++++++++++------------------- > > 1 file changed, 60 insertions(+), 57 deletions(-) > > > > diff --git a/drivers/iommu/amd/iommu.c b/drivers/iommu/amd/iommu.c > > index 4c31294fabc5..e1f9fbb63837 100644 > > --- a/drivers/iommu/amd/iommu.c > > +++ b/drivers/iommu/amd/iommu.c > > @@ -675,7 +675,8 @@ static void pdev_disable_caps(struct pci_dev *pdev) > > > .../... > > > static struct iommu_device *amd_iommu_probe_device(struct device *dev) > > { > > struct iommu_device *iommu_dev; > > struct amd_iommu *iommu; > > struct iommu_dev_data *dev_data; > > int ret; > > + u16 devid; > > > > - if (!check_device(dev)) > > - return ERR_PTR(-ENODEV); > > - > > - iommu = rlookup_amd_iommu(dev); > > - if (!iommu) > > - return ERR_PTR(-ENODEV); > > - > > - /* Not registered yet? */ > > - if (!iommu->iommu.ops) > > + if (!iommu_lookup_device(dev, &iommu, &devid)) > > return ERR_PTR(-ENODEV); > > > > if (dev_iommu_priv_get(dev)) > > return &iommu->iommu; > > > > - ret = iommu_init_device(iommu, dev); > > - if (ret) { > > + dev_data = iommu_init_device(iommu, dev, devid); > > + if (IS_ERR(dev_data)) { > > + ret = PTR_ERR(dev_data); > > Instead of this, you can change below iommu_Dev assignment directly. Ack, I'll change iommu_dev assignment directly. > > -Vasant > > > dev_err(dev, "Failed to initialize - trying to proceed anyway\n"); > > iommu_dev = ERR_PTR(ret); > > iommu_ignore_device(iommu, dev); > > goto out_err; > > } > > Thanks, Praan