From: Breno Leitao <leitao@debian.org>
To: Paolo Abeni <pabeni@redhat.com>
Cc: Nicolai Buchwitz <nb@tipi-net.de>,
Jamal Hadi Salim <jhs@mojatatu.com>,
Jiri Pirko <jiri@resnulli.us>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Simon Horman <horms@kernel.org>, Florian Westphal <fw@strlen.de>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-team@meta.com, stable@vger.kernel.org
Subject: Re: [PATCH net] net: fix spurious TX timeout after dev_activate()
Date: Tue, 25 Aug 2026 03:43:45 -0700 [thread overview]
Message-ID: <ao1wnOkX3nUXc9r5@gmail.com> (raw)
In-Reply-To: <7aed7185-d48c-4013-9a85-a8b27cf7eae3@redhat.com>
On Tue, Aug 25, 2026 at 10:47:13AM +0200, Paolo Abeni wrote:
> On 8/24/26 5:13 PM, Nicolai Buchwitz wrote:
> >> diff --git a/net/sched/sch_generic.c b/net/sched/sch_generic.c
> >> index ef2b4bf515641..4539dc2c6d380 100644
> >> --- a/net/sched/sch_generic.c
> >> +++ b/net/sched/sch_generic.c
> >> @@ -1278,7 +1278,7 @@ static void transition_one_qdisc(struct
> >> net_device *dev,
> >>
> >> rcu_assign_pointer(dev_queue->qdisc, new_qdisc);
> >> if (need_watchdog_p) {
> >> - WRITE_ONCE(dev_queue->trans_start, 0);
> >> + WRITE_ONCE(dev_queue->trans_start, jiffies);
> >> *need_watchdog_p = 1;
> >> }
> >> }
> >
> > Follow up or v2: netif_trans_update() in dev_activate() now seems
> > redundant?
>
> IMHO should be a follow-up.
Oops, I replied to the other email too early. I'll respin this one and
send a separate follow-up covering netif_trans_update.
In that follow-up (net-next material0, I can probably simplify
need_watchdog as well.
Thanks for the guidance,
--breno
next prev parent reply other threads:[~2026-08-25 10:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-24 11:45 [PATCH net] net: fix spurious TX timeout after dev_activate() Breno Leitao
2026-08-24 15:13 ` Nicolai Buchwitz
2026-08-25 8:47 ` Paolo Abeni
2026-08-25 10:43 ` Breno Leitao [this message]
2026-08-25 10:36 ` Breno Leitao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ao1wnOkX3nUXc9r5@gmail.com \
--to=leitao@debian.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=horms@kernel.org \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kernel-team@meta.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nb@tipi-net.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox